mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-23 19:57:19 +02:00
Hostile objects located within the installation-time search_path could
capture references in an extension's installation or upgrade script.
If the extension is being installed with superuser privileges, this
opens the door to privilege escalation. While such hazards have existed
all along, their urgency increases with the v13 "trusted extensions"
feature, because that lets a non-superuser control the installation path
for a superuser-privileged script. Therefore, make a number of changes
to make such situations more secure:
* Tweak the construction of the installation-time search_path to ensure
that references to objects in pg_catalog can't be subverted; and
explicitly add pg_temp to the end of the path to prevent attacks using
temporary objects.
* Disable check_function_bodies within installation/upgrade scripts,
so that any security gaps in SQL-language or PL-language function bodies
cannot create a risk of unwanted installation-time code execution.
* Adjust lookup of type input/receive functions and join estimator
functions to complain if there are multiple candidate functions. This
prevents capture of references to functions whose signature is not the
first one checked; and it's arguably more user-friendly anyway.
* Modify various contrib upgrade scripts to ensure that catalog
modification queries are executed with secure search paths. (These
are in-place modifications with no extension version changes, since
it is the update process itself that is at issue, not the end result.)
Extensions that depend on other extensions cannot be made fully secure
by these methods alone; therefore, revert the "trusted" marking that
commit eb67623c9
applied to earthdistance and hstore_plperl, pending
some better solution to that set of issues.
Also add documentation around these issues, to help extension authors
write secure installation scripts.
Patch by me, following an observation by Andres Freund; thanks
to Noah Misch for review.
Security: CVE-2020-14350
214 lines
10 KiB
PL/PgSQL
214 lines
10 KiB
PL/PgSQL
/* contrib/citext/citext--unpackaged--1.0.sql */
|
|
|
|
-- complain if script is sourced in psql, rather than via CREATE EXTENSION
|
|
\echo Use "CREATE EXTENSION citext FROM unpackaged" to load this file. \quit
|
|
|
|
ALTER EXTENSION citext ADD type citext;
|
|
ALTER EXTENSION citext ADD function citextin(cstring);
|
|
ALTER EXTENSION citext ADD function citextout(citext);
|
|
ALTER EXTENSION citext ADD function citextrecv(internal);
|
|
ALTER EXTENSION citext ADD function citextsend(citext);
|
|
ALTER EXTENSION citext ADD function citext(character);
|
|
ALTER EXTENSION citext ADD function citext(boolean);
|
|
ALTER EXTENSION citext ADD function citext(inet);
|
|
ALTER EXTENSION citext ADD cast (citext as text);
|
|
ALTER EXTENSION citext ADD cast (citext as character varying);
|
|
ALTER EXTENSION citext ADD cast (citext as character);
|
|
ALTER EXTENSION citext ADD cast (text as citext);
|
|
ALTER EXTENSION citext ADD cast (character varying as citext);
|
|
ALTER EXTENSION citext ADD cast (character as citext);
|
|
ALTER EXTENSION citext ADD cast (boolean as citext);
|
|
ALTER EXTENSION citext ADD cast (inet as citext);
|
|
ALTER EXTENSION citext ADD function citext_eq(citext,citext);
|
|
ALTER EXTENSION citext ADD function citext_ne(citext,citext);
|
|
ALTER EXTENSION citext ADD function citext_lt(citext,citext);
|
|
ALTER EXTENSION citext ADD function citext_le(citext,citext);
|
|
ALTER EXTENSION citext ADD function citext_gt(citext,citext);
|
|
ALTER EXTENSION citext ADD function citext_ge(citext,citext);
|
|
ALTER EXTENSION citext ADD operator <>(citext,citext);
|
|
ALTER EXTENSION citext ADD operator =(citext,citext);
|
|
ALTER EXTENSION citext ADD operator >(citext,citext);
|
|
ALTER EXTENSION citext ADD operator >=(citext,citext);
|
|
ALTER EXTENSION citext ADD operator <(citext,citext);
|
|
ALTER EXTENSION citext ADD operator <=(citext,citext);
|
|
ALTER EXTENSION citext ADD function citext_cmp(citext,citext);
|
|
ALTER EXTENSION citext ADD function citext_hash(citext);
|
|
ALTER EXTENSION citext ADD operator family citext_ops using btree;
|
|
ALTER EXTENSION citext ADD operator class citext_ops using btree;
|
|
ALTER EXTENSION citext ADD operator family citext_ops using hash;
|
|
ALTER EXTENSION citext ADD operator class citext_ops using hash;
|
|
ALTER EXTENSION citext ADD function citext_smaller(citext,citext);
|
|
ALTER EXTENSION citext ADD function citext_larger(citext,citext);
|
|
ALTER EXTENSION citext ADD function min(citext);
|
|
ALTER EXTENSION citext ADD function max(citext);
|
|
ALTER EXTENSION citext ADD function texticlike(citext,citext);
|
|
ALTER EXTENSION citext ADD function texticnlike(citext,citext);
|
|
ALTER EXTENSION citext ADD function texticregexeq(citext,citext);
|
|
ALTER EXTENSION citext ADD function texticregexne(citext,citext);
|
|
ALTER EXTENSION citext ADD operator !~(citext,citext);
|
|
ALTER EXTENSION citext ADD operator ~(citext,citext);
|
|
ALTER EXTENSION citext ADD operator !~*(citext,citext);
|
|
ALTER EXTENSION citext ADD operator ~*(citext,citext);
|
|
ALTER EXTENSION citext ADD operator !~~(citext,citext);
|
|
ALTER EXTENSION citext ADD operator ~~(citext,citext);
|
|
ALTER EXTENSION citext ADD operator !~~*(citext,citext);
|
|
ALTER EXTENSION citext ADD operator ~~*(citext,citext);
|
|
ALTER EXTENSION citext ADD function texticlike(citext,text);
|
|
ALTER EXTENSION citext ADD function texticnlike(citext,text);
|
|
ALTER EXTENSION citext ADD function texticregexeq(citext,text);
|
|
ALTER EXTENSION citext ADD function texticregexne(citext,text);
|
|
ALTER EXTENSION citext ADD operator !~(citext,text);
|
|
ALTER EXTENSION citext ADD operator ~(citext,text);
|
|
ALTER EXTENSION citext ADD operator !~*(citext,text);
|
|
ALTER EXTENSION citext ADD operator ~*(citext,text);
|
|
ALTER EXTENSION citext ADD operator !~~(citext,text);
|
|
ALTER EXTENSION citext ADD operator ~~(citext,text);
|
|
ALTER EXTENSION citext ADD operator !~~*(citext,text);
|
|
ALTER EXTENSION citext ADD operator ~~*(citext,text);
|
|
ALTER EXTENSION citext ADD function regexp_matches(citext,citext);
|
|
ALTER EXTENSION citext ADD function regexp_matches(citext,citext,text);
|
|
ALTER EXTENSION citext ADD function regexp_replace(citext,citext,text);
|
|
ALTER EXTENSION citext ADD function regexp_replace(citext,citext,text,text);
|
|
ALTER EXTENSION citext ADD function regexp_split_to_array(citext,citext);
|
|
ALTER EXTENSION citext ADD function regexp_split_to_array(citext,citext,text);
|
|
ALTER EXTENSION citext ADD function regexp_split_to_table(citext,citext);
|
|
ALTER EXTENSION citext ADD function regexp_split_to_table(citext,citext,text);
|
|
ALTER EXTENSION citext ADD function strpos(citext,citext);
|
|
ALTER EXTENSION citext ADD function replace(citext,citext,citext);
|
|
ALTER EXTENSION citext ADD function split_part(citext,citext,integer);
|
|
ALTER EXTENSION citext ADD function translate(citext,citext,text);
|
|
|
|
--
|
|
-- As of 9.1, type citext should be marked collatable. There is no ALTER TYPE
|
|
-- command for this, so we have to do it by poking the pg_type entry directly.
|
|
-- We have to poke any derived copies in pg_attribute or pg_index as well,
|
|
-- as well as those for arrays/domains based directly or indirectly on citext.
|
|
-- Notes: 100 is the OID of the "pg_catalog.default" collation --- it seems
|
|
-- easier and more reliable to hard-wire that here than to pull it out of
|
|
-- pg_collation. Also, we don't need to make pg_depend entries since the
|
|
-- default collation is pinned.
|
|
--
|
|
|
|
DO LANGUAGE plpgsql
|
|
$$
|
|
DECLARE
|
|
my_schema pg_catalog.text := pg_catalog.quote_ident(pg_catalog.current_schema());
|
|
old_path pg_catalog.text := pg_catalog.current_setting('search_path');
|
|
BEGIN
|
|
-- for safety, transiently set search_path to just pg_catalog+pg_temp
|
|
PERFORM pg_catalog.set_config('search_path', 'pg_catalog, pg_temp', true);
|
|
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
UPDATE pg_catalog.pg_type SET typcollation = 100
|
|
FROM typeoids
|
|
WHERE oid = typeoids.typoid;
|
|
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
UPDATE pg_catalog.pg_attribute SET attcollation = 100
|
|
FROM typeoids
|
|
WHERE atttypid = typeoids.typoid;
|
|
|
|
-- Updating the index indcollations is particularly tedious, but since we
|
|
-- don't currently allow SQL assignment to individual elements of oidvectors,
|
|
-- there's little choice.
|
|
|
|
UPDATE pg_catalog.pg_index SET indcollation =
|
|
pg_catalog.regexp_replace(indcollation::pg_catalog.text, '^0', '100')::pg_catalog.oidvector
|
|
WHERE indclass[0] IN (
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
SELECT oid FROM pg_catalog.pg_opclass, typeoids
|
|
WHERE opcintype = typeoids.typoid
|
|
);
|
|
|
|
UPDATE pg_catalog.pg_index SET indcollation =
|
|
pg_catalog.regexp_replace(indcollation::pg_catalog.text, E'^(\\d+) 0', E'\\1 100')::pg_catalog.oidvector
|
|
WHERE indclass[1] IN (
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
SELECT oid FROM pg_catalog.pg_opclass, typeoids
|
|
WHERE opcintype = typeoids.typoid
|
|
);
|
|
|
|
UPDATE pg_catalog.pg_index SET indcollation =
|
|
pg_catalog.regexp_replace(indcollation::pg_catalog.text, E'^(\\d+ \\d+) 0', E'\\1 100')::pg_catalog.oidvector
|
|
WHERE indclass[2] IN (
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
SELECT oid FROM pg_catalog.pg_opclass, typeoids
|
|
WHERE opcintype = typeoids.typoid
|
|
);
|
|
|
|
UPDATE pg_catalog.pg_index SET indcollation =
|
|
pg_catalog.regexp_replace(indcollation::pg_catalog.text, E'^(\\d+ \\d+ \\d+) 0', E'\\1 100')::pg_catalog.oidvector
|
|
WHERE indclass[3] IN (
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
SELECT oid FROM pg_catalog.pg_opclass, typeoids
|
|
WHERE opcintype = typeoids.typoid
|
|
);
|
|
|
|
UPDATE pg_catalog.pg_index SET indcollation =
|
|
pg_catalog.regexp_replace(indcollation::pg_catalog.text, E'^(\\d+ \\d+ \\d+ \\d+) 0', E'\\1 100')::pg_catalog.oidvector
|
|
WHERE indclass[4] IN (
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
SELECT oid FROM pg_catalog.pg_opclass, typeoids
|
|
WHERE opcintype = typeoids.typoid
|
|
);
|
|
|
|
UPDATE pg_catalog.pg_index SET indcollation =
|
|
pg_catalog.regexp_replace(indcollation::pg_catalog.text, E'^(\\d+ \\d+ \\d+ \\d+ \\d+) 0', E'\\1 100')::pg_catalog.oidvector
|
|
WHERE indclass[5] IN (
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
SELECT oid FROM pg_catalog.pg_opclass, typeoids
|
|
WHERE opcintype = typeoids.typoid
|
|
);
|
|
|
|
UPDATE pg_catalog.pg_index SET indcollation =
|
|
pg_catalog.regexp_replace(indcollation::pg_catalog.text, E'^(\\d+ \\d+ \\d+ \\d+ \\d+ \\d+) 0', E'\\1 100')::pg_catalog.oidvector
|
|
WHERE indclass[6] IN (
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
SELECT oid FROM pg_catalog.pg_opclass, typeoids
|
|
WHERE opcintype = typeoids.typoid
|
|
);
|
|
|
|
UPDATE pg_catalog.pg_index SET indcollation =
|
|
pg_catalog.regexp_replace(indcollation::pg_catalog.text, E'^(\\d+ \\d+ \\d+ \\d+ \\d+ \\d+ \\d+) 0', E'\\1 100')::pg_catalog.oidvector
|
|
WHERE indclass[7] IN (
|
|
WITH RECURSIVE typeoids(typoid) AS
|
|
( SELECT (my_schema || '.citext')::pg_catalog.regtype UNION
|
|
SELECT oid FROM pg_catalog.pg_type, typeoids
|
|
WHERE typelem = typoid OR typbasetype = typoid )
|
|
SELECT oid FROM pg_catalog.pg_opclass, typeoids
|
|
WHERE opcintype = typeoids.typoid
|
|
);
|
|
|
|
-- somewhat arbitrarily, we assume no citext indexes have more than 8 columns
|
|
|
|
PERFORM pg_catalog.set_config('search_path', old_path, true);
|
|
END
|
|
$$;
|