postgresql/src/port
Andres Freund 311da16439 Add support for optional_argument to our own getopt_long() implementation.
07c8651dd9 currently causes compilation errors on mscv (and
probably some other) compilers because our getopt_long()
implementation doesn't have support for optional_argument.

Thus implement optional_argument in our fallback implemenation. It's
quite possibly also useful in other cases.

Arguably this needs a configure check for optional_argument, but it
has existed pretty much since getopt_long() was introduced and thus
doesn't seem worth the configure runtime.

Normally I'd would not push a patch this fast, but this allows msvc to
build again and has low risk as only optional_argument behaviour has
changed.

Author: Michael Paquier and Andres Freund

Discussion: CAB7nPqS5VeedSCxrK=QouokbawgGKLpyc1Q++RRFCa_sjcSVrg@mail.gmail.com
2014-09-10 17:21:50 +02:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
Makefile Move username lookup functions from /port to /common 2014-01-10 18:03:28 -05:00
README Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
chklocale.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
crypt.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
dirent.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
dirmod.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
erand48.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
fls.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
fseeko.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
getaddrinfo.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
gethostname.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
getopt.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
getopt_long.c Add support for optional_argument to our own getopt_long() implementation. 2014-09-10 17:21:50 +02:00
getpeereid.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
getrusage.c C comments: remove odd blank lines after #ifdef WIN32 lines 2014-03-13 01:34:42 -04:00
gettimeofday.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
inet_aton.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
inet_net_ntop.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
isinf.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
kill.c Report success when Windows kill() emulation signals an exiting process. 2014-07-23 00:35:13 -04:00
mkdtemp.c Add mkdtemp() to libpgport. 2014-06-14 09:41:13 -04:00
noblock.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
open.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
path.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pg_crc.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
pgcheckdir.c Remove MinGW readdir/errno bug workaround fixed on 2003-10-10 2014-03-21 13:47:37 -04:00
pgmkdirp.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pgsleep.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
pgstrcasecmp.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
pqsignal.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
qsort_arg.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
quotes.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
random.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
rint.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
snprintf.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
sprompt.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
srandom.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
system.c Replace SYSTEMQUOTEs with Windows-specific wrapper functions. 2014-05-05 16:07:40 +03:00
tar.c Fix unportable coding in tarCreateHeader(). 2014-02-16 20:01:18 -05:00
thread.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
unsetenv.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
win32error.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
win32setlocale.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
win32ver.rc Stamp HEAD as 9.5devel. 2014-06-10 21:36:13 -04:00

README

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Win32, Linux, and Darwin use an export list to
control the symbols exported by libpq.