mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-23 13:30:39 +02:00
c29a9c37bf
then-delete on the current cursor row. The basic fix is that nodeTidscan.c has to apply heap_get_latest_tid() to the current-scan-TID obtained from the cursor query; this ensures we get the latest row version to work with. However, since that only works if the query plan is a TID scan, we also have to hack the planner to make sure only that type of plan will be selected. (Formerly, the planner might decide to apply a seqscan if the table is very small. This change is probably a Good Thing anyway, since it's hard to see how a seqscan could really win.) That means the execQual.c code to support CurrentOfExpr as a regular expression type is dead code, so replace it with just an elog(). Also, add regression tests covering these cases. Note that the added tests expose the fact that re-fetching an updated row misbehaves if the cursor used FOR UPDATE. That's an independent bug that should be fixed later. Per report from Dharmendra Goyal.
441 lines
9.2 KiB
PL/PgSQL
441 lines
9.2 KiB
PL/PgSQL
--
|
|
-- Cursor regression tests
|
|
--
|
|
|
|
BEGIN;
|
|
|
|
DECLARE foo1 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo2 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo3 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo4 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo5 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo6 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo7 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo8 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo9 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo10 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo11 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo12 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo13 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo14 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo15 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo16 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo17 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo18 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo19 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo20 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo21 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
DECLARE foo22 SCROLL CURSOR FOR SELECT * FROM tenk2;
|
|
|
|
DECLARE foo23 SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
FETCH 1 in foo1;
|
|
|
|
FETCH 2 in foo2;
|
|
|
|
FETCH 3 in foo3;
|
|
|
|
FETCH 4 in foo4;
|
|
|
|
FETCH 5 in foo5;
|
|
|
|
FETCH 6 in foo6;
|
|
|
|
FETCH 7 in foo7;
|
|
|
|
FETCH 8 in foo8;
|
|
|
|
FETCH 9 in foo9;
|
|
|
|
FETCH 10 in foo10;
|
|
|
|
FETCH 11 in foo11;
|
|
|
|
FETCH 12 in foo12;
|
|
|
|
FETCH 13 in foo13;
|
|
|
|
FETCH 14 in foo14;
|
|
|
|
FETCH 15 in foo15;
|
|
|
|
FETCH 16 in foo16;
|
|
|
|
FETCH 17 in foo17;
|
|
|
|
FETCH 18 in foo18;
|
|
|
|
FETCH 19 in foo19;
|
|
|
|
FETCH 20 in foo20;
|
|
|
|
FETCH 21 in foo21;
|
|
|
|
FETCH 22 in foo22;
|
|
|
|
FETCH 23 in foo23;
|
|
|
|
FETCH backward 1 in foo23;
|
|
|
|
FETCH backward 2 in foo22;
|
|
|
|
FETCH backward 3 in foo21;
|
|
|
|
FETCH backward 4 in foo20;
|
|
|
|
FETCH backward 5 in foo19;
|
|
|
|
FETCH backward 6 in foo18;
|
|
|
|
FETCH backward 7 in foo17;
|
|
|
|
FETCH backward 8 in foo16;
|
|
|
|
FETCH backward 9 in foo15;
|
|
|
|
FETCH backward 10 in foo14;
|
|
|
|
FETCH backward 11 in foo13;
|
|
|
|
FETCH backward 12 in foo12;
|
|
|
|
FETCH backward 13 in foo11;
|
|
|
|
FETCH backward 14 in foo10;
|
|
|
|
FETCH backward 15 in foo9;
|
|
|
|
FETCH backward 16 in foo8;
|
|
|
|
FETCH backward 17 in foo7;
|
|
|
|
FETCH backward 18 in foo6;
|
|
|
|
FETCH backward 19 in foo5;
|
|
|
|
FETCH backward 20 in foo4;
|
|
|
|
FETCH backward 21 in foo3;
|
|
|
|
FETCH backward 22 in foo2;
|
|
|
|
FETCH backward 23 in foo1;
|
|
|
|
CLOSE foo1;
|
|
|
|
CLOSE foo2;
|
|
|
|
CLOSE foo3;
|
|
|
|
CLOSE foo4;
|
|
|
|
CLOSE foo5;
|
|
|
|
CLOSE foo6;
|
|
|
|
CLOSE foo7;
|
|
|
|
CLOSE foo8;
|
|
|
|
CLOSE foo9;
|
|
|
|
CLOSE foo10;
|
|
|
|
CLOSE foo11;
|
|
|
|
CLOSE foo12;
|
|
|
|
-- leave some cursors open, to test that auto-close works.
|
|
|
|
-- record this in the system view as well (don't query the time field there
|
|
-- however)
|
|
SELECT name, statement, is_holdable, is_binary, is_scrollable FROM pg_cursors;
|
|
|
|
END;
|
|
|
|
SELECT name, statement, is_holdable, is_binary, is_scrollable FROM pg_cursors;
|
|
|
|
--
|
|
-- NO SCROLL disallows backward fetching
|
|
--
|
|
|
|
BEGIN;
|
|
|
|
DECLARE foo24 NO SCROLL CURSOR FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
FETCH 1 FROM foo24;
|
|
|
|
FETCH BACKWARD 1 FROM foo24; -- should fail
|
|
|
|
END;
|
|
|
|
--
|
|
-- Cursors outside transaction blocks
|
|
--
|
|
|
|
|
|
SELECT name, statement, is_holdable, is_binary, is_scrollable FROM pg_cursors;
|
|
|
|
BEGIN;
|
|
|
|
DECLARE foo25 SCROLL CURSOR WITH HOLD FOR SELECT * FROM tenk2;
|
|
|
|
FETCH FROM foo25;
|
|
|
|
FETCH FROM foo25;
|
|
|
|
COMMIT;
|
|
|
|
FETCH FROM foo25;
|
|
|
|
FETCH BACKWARD FROM foo25;
|
|
|
|
FETCH ABSOLUTE -1 FROM foo25;
|
|
|
|
SELECT name, statement, is_holdable, is_binary, is_scrollable FROM pg_cursors;
|
|
|
|
CLOSE foo25;
|
|
|
|
--
|
|
-- ROLLBACK should close holdable cursors
|
|
--
|
|
|
|
BEGIN;
|
|
|
|
DECLARE foo26 CURSOR WITH HOLD FOR SELECT * FROM tenk1 ORDER BY unique2;
|
|
|
|
ROLLBACK;
|
|
|
|
-- should fail
|
|
FETCH FROM foo26;
|
|
|
|
--
|
|
-- Parameterized DECLARE needs to insert param values into the cursor portal
|
|
--
|
|
|
|
BEGIN;
|
|
|
|
CREATE FUNCTION declares_cursor(text)
|
|
RETURNS void
|
|
AS 'DECLARE c CURSOR FOR SELECT stringu1 FROM tenk1 WHERE stringu1 LIKE $1;'
|
|
LANGUAGE SQL;
|
|
|
|
SELECT declares_cursor('AB%');
|
|
|
|
FETCH ALL FROM c;
|
|
|
|
ROLLBACK;
|
|
|
|
--
|
|
-- Test behavior of both volatile and stable functions inside a cursor;
|
|
-- in particular we want to see what happens during commit of a holdable
|
|
-- cursor
|
|
--
|
|
|
|
create temp table tt1(f1 int);
|
|
|
|
create function count_tt1_v() returns int8 as
|
|
'select count(*) from tt1' language sql volatile;
|
|
|
|
create function count_tt1_s() returns int8 as
|
|
'select count(*) from tt1' language sql stable;
|
|
|
|
begin;
|
|
|
|
insert into tt1 values(1);
|
|
|
|
declare c1 cursor for select count_tt1_v(), count_tt1_s();
|
|
|
|
insert into tt1 values(2);
|
|
|
|
fetch all from c1;
|
|
|
|
rollback;
|
|
|
|
begin;
|
|
|
|
insert into tt1 values(1);
|
|
|
|
declare c2 cursor with hold for select count_tt1_v(), count_tt1_s();
|
|
|
|
insert into tt1 values(2);
|
|
|
|
commit;
|
|
|
|
delete from tt1;
|
|
|
|
fetch all from c2;
|
|
|
|
drop function count_tt1_v();
|
|
drop function count_tt1_s();
|
|
|
|
|
|
-- Create a cursor with the BINARY option and check the pg_cursors view
|
|
BEGIN;
|
|
SELECT name, statement, is_holdable, is_binary, is_scrollable FROM pg_cursors;
|
|
DECLARE bc BINARY CURSOR FOR SELECT * FROM tenk1;
|
|
SELECT name, statement, is_holdable, is_binary, is_scrollable FROM pg_cursors;
|
|
ROLLBACK;
|
|
|
|
-- We should not see the portal that is created internally to
|
|
-- implement EXECUTE in pg_cursors
|
|
PREPARE cprep AS
|
|
SELECT name, statement, is_holdable, is_binary, is_scrollable FROM pg_cursors;
|
|
EXECUTE cprep;
|
|
|
|
-- test CLOSE ALL;
|
|
SELECT name FROM pg_cursors ORDER BY 1;
|
|
CLOSE ALL;
|
|
SELECT name FROM pg_cursors ORDER BY 1;
|
|
BEGIN;
|
|
DECLARE foo1 CURSOR WITH HOLD FOR SELECT 1;
|
|
DECLARE foo2 CURSOR WITHOUT HOLD FOR SELECT 1;
|
|
SELECT name FROM pg_cursors ORDER BY 1;
|
|
CLOSE ALL;
|
|
SELECT name FROM pg_cursors ORDER BY 1;
|
|
COMMIT;
|
|
|
|
--
|
|
-- Tests for updatable cursors
|
|
--
|
|
|
|
CREATE TEMP TABLE uctest(f1 int, f2 text);
|
|
INSERT INTO uctest VALUES (1, 'one'), (2, 'two'), (3, 'three');
|
|
SELECT * FROM uctest;
|
|
|
|
-- Check DELETE WHERE CURRENT
|
|
BEGIN;
|
|
DECLARE c1 CURSOR FOR SELECT * FROM uctest;
|
|
FETCH 2 FROM c1;
|
|
DELETE FROM uctest WHERE CURRENT OF c1;
|
|
-- should show deletion
|
|
SELECT * FROM uctest;
|
|
-- cursor did not move
|
|
FETCH ALL FROM c1;
|
|
-- cursor is insensitive
|
|
MOVE BACKWARD ALL IN c1;
|
|
FETCH ALL FROM c1;
|
|
COMMIT;
|
|
-- should still see deletion
|
|
SELECT * FROM uctest;
|
|
|
|
-- Check UPDATE WHERE CURRENT; this time use FOR UPDATE
|
|
BEGIN;
|
|
DECLARE c1 CURSOR FOR SELECT * FROM uctest FOR UPDATE;
|
|
FETCH c1;
|
|
UPDATE uctest SET f1 = 8 WHERE CURRENT OF c1;
|
|
SELECT * FROM uctest;
|
|
COMMIT;
|
|
SELECT * FROM uctest;
|
|
|
|
-- Check repeated-update and update-then-delete cases
|
|
BEGIN;
|
|
DECLARE c1 CURSOR FOR SELECT * FROM uctest;
|
|
FETCH c1;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1;
|
|
SELECT * FROM uctest;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1;
|
|
SELECT * FROM uctest;
|
|
-- insensitive cursor should not show effects of updates or deletes
|
|
FETCH RELATIVE 0 FROM c1;
|
|
DELETE FROM uctest WHERE CURRENT OF c1;
|
|
SELECT * FROM uctest;
|
|
DELETE FROM uctest WHERE CURRENT OF c1; -- no-op
|
|
SELECT * FROM uctest;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1; -- no-op
|
|
SELECT * FROM uctest;
|
|
FETCH RELATIVE 0 FROM c1;
|
|
ROLLBACK;
|
|
SELECT * FROM uctest;
|
|
|
|
BEGIN;
|
|
DECLARE c1 CURSOR FOR SELECT * FROM uctest FOR UPDATE;
|
|
FETCH c1;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1;
|
|
SELECT * FROM uctest;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1;
|
|
SELECT * FROM uctest;
|
|
-- sensitive cursor should show effects of updates or deletes
|
|
-- XXX current behavior is WRONG
|
|
FETCH RELATIVE 0 FROM c1;
|
|
DELETE FROM uctest WHERE CURRENT OF c1;
|
|
SELECT * FROM uctest;
|
|
DELETE FROM uctest WHERE CURRENT OF c1; -- no-op
|
|
SELECT * FROM uctest;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1; -- no-op
|
|
SELECT * FROM uctest;
|
|
FETCH RELATIVE 0 FROM c1;
|
|
ROLLBACK;
|
|
SELECT * FROM uctest;
|
|
|
|
-- Check inheritance cases
|
|
CREATE TEMP TABLE ucchild () inherits (uctest);
|
|
INSERT INTO ucchild values(100, 'hundred');
|
|
SELECT * FROM uctest;
|
|
|
|
BEGIN;
|
|
DECLARE c1 CURSOR FOR SELECT * FROM uctest;
|
|
FETCH 1 FROM c1;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1;
|
|
FETCH 1 FROM c1;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1;
|
|
FETCH 1 FROM c1;
|
|
UPDATE uctest SET f1 = f1 + 10 WHERE CURRENT OF c1;
|
|
FETCH 1 FROM c1;
|
|
COMMIT;
|
|
SELECT * FROM uctest;
|
|
|
|
-- Check various error cases
|
|
|
|
DELETE FROM uctest WHERE CURRENT OF c1; -- fail, no such cursor
|
|
DECLARE cx CURSOR WITH HOLD FOR SELECT * FROM uctest;
|
|
DELETE FROM uctest WHERE CURRENT OF cx; -- fail, can't use held cursor
|
|
BEGIN;
|
|
DECLARE c CURSOR FOR SELECT * FROM tenk2;
|
|
DELETE FROM uctest WHERE CURRENT OF c; -- fail, cursor on wrong table
|
|
ROLLBACK;
|
|
BEGIN;
|
|
DECLARE c CURSOR FOR SELECT * FROM tenk1 JOIN tenk2 USING (unique1);
|
|
DELETE FROM tenk1 WHERE CURRENT OF c; -- fail, cursor is on a join
|
|
ROLLBACK;
|
|
BEGIN;
|
|
DECLARE c CURSOR FOR SELECT f1,count(*) FROM uctest GROUP BY f1;
|
|
DELETE FROM uctest WHERE CURRENT OF c; -- fail, cursor is on aggregation
|
|
ROLLBACK;
|
|
BEGIN;
|
|
DECLARE c1 CURSOR FOR SELECT * FROM uctest;
|
|
DELETE FROM uctest WHERE CURRENT OF c1; -- fail, no current row
|
|
ROLLBACK;
|
|
|
|
-- WHERE CURRENT OF may someday work with views, but today is not that day.
|
|
-- For now, just make sure it errors out cleanly.
|
|
CREATE TEMP VIEW ucview AS SELECT * FROM uctest;
|
|
CREATE RULE ucrule AS ON DELETE TO ucview DO INSTEAD
|
|
DELETE FROM uctest WHERE f1 = OLD.f1;
|
|
BEGIN;
|
|
DECLARE c1 CURSOR FOR SELECT * FROM ucview;
|
|
FETCH FROM c1;
|
|
DELETE FROM ucview WHERE CURRENT OF c1; -- fail, views not supported
|
|
ROLLBACK;
|