mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-23 22:07:19 +02:00
To ensure that "make installcheck" can be used safely against an existing installation, we need to be careful about what global object names (database, role, and tablespace names) we use; otherwise we might accidentally clobber important objects. There's been a weak consensus that test databases should have names including "regression", and that test role names should start with "regress_", but we didn't have any particular rule about tablespace names; and neither of the other rules was followed with any consistency either. This commit moves us a long way towards having a hard-and-fast rule that regression test databases must have names including "regression", and that test role and tablespace names must start with "regress_". It's not completely there because I did not touch some test cases in rolenames.sql that test creation of special role names like "session_user". That will require some rethinking of exactly what we want to test, whereas the intent of this patch is just to hit all the cases in which the needed renamings are cosmetic. There is no enforcement mechanism in this patch either, but if we don't add one we can expect that the tests will soon be violating the convention again. Again, that's not such a cosmetic change and it will require discussion. (But I did use a quick-hack enforcement patch to find these cases.) Discussion: <16638.1468620817@sss.pgh.pa.us>
137 lines
5.2 KiB
PL/PgSQL
137 lines
5.2 KiB
PL/PgSQL
--
|
|
-- Test for various ALTER statements
|
|
--
|
|
|
|
-- clean-up in case a prior regression run failed
|
|
SET client_min_messages TO 'warning';
|
|
DROP DATABASE IF EXISTS sepgsql_test_regression_1;
|
|
DROP DATABASE IF EXISTS sepgsql_test_regression;
|
|
DROP USER IF EXISTS regress_sepgsql_test_user;
|
|
RESET client_min_messages;
|
|
|
|
-- @SECURITY-CONTEXT=unconfined_u:unconfined_r:sepgsql_regtest_superuser_t:s0
|
|
|
|
--
|
|
-- CREATE Objects to be altered (with debug_audit being silent)
|
|
--
|
|
CREATE DATABASE sepgsql_test_regression_1;
|
|
|
|
CREATE USER regress_sepgsql_test_user;
|
|
|
|
CREATE SCHEMA regtest_schema_1;
|
|
CREATE SCHEMA regtest_schema_2;
|
|
|
|
GRANT ALL ON SCHEMA regtest_schema_1 TO public;
|
|
GRANT ALL ON SCHEMA regtest_schema_2 TO public;
|
|
|
|
SET search_path = regtest_schema_1, regtest_schema_2, public;
|
|
|
|
CREATE TABLE regtest_table_1 (a int, b text);
|
|
|
|
CREATE TABLE regtest_table_2 (c text) inherits (regtest_table_1);
|
|
|
|
CREATE TABLE regtest_table_3 (x int primary key, y text);
|
|
|
|
CREATE SEQUENCE regtest_seq_1;
|
|
|
|
CREATE VIEW regtest_view_1 AS SELECT * FROM regtest_table_1 WHERE a > 0;
|
|
|
|
CREATE FUNCTION regtest_func_1 (text) RETURNS bool
|
|
AS 'BEGIN RETURN true; END' LANGUAGE 'plpgsql';
|
|
|
|
-- switch on debug_audit
|
|
SET sepgsql.debug_audit = true;
|
|
SET client_min_messages = LOG;
|
|
|
|
--
|
|
-- ALTER xxx OWNER TO
|
|
--
|
|
-- XXX: It should take db_xxx:{setattr} permission checks even if
|
|
-- owner is not actually changed.
|
|
--
|
|
ALTER DATABASE sepgsql_test_regression_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER DATABASE sepgsql_test_regression_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER SCHEMA regtest_schema_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER SCHEMA regtest_schema_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER TABLE regtest_table_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER TABLE regtest_table_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER SEQUENCE regtest_seq_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER SEQUENCE regtest_seq_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER VIEW regtest_view_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER VIEW regtest_view_1 OWNER TO regress_sepgsql_test_user;
|
|
ALTER FUNCTION regtest_func_1(text) OWNER TO regress_sepgsql_test_user;
|
|
ALTER FUNCTION regtest_func_1(text) OWNER TO regress_sepgsql_test_user;
|
|
|
|
--
|
|
-- ALTER xxx SET SCHEMA
|
|
--
|
|
ALTER TABLE regtest_table_1 SET SCHEMA regtest_schema_2;
|
|
ALTER SEQUENCE regtest_seq_1 SET SCHEMA regtest_schema_2;
|
|
ALTER VIEW regtest_view_1 SET SCHEMA regtest_schema_2;
|
|
ALTER FUNCTION regtest_func_1(text) SET SCHEMA regtest_schema_2;
|
|
|
|
--
|
|
-- ALTER xxx RENAME TO
|
|
--
|
|
ALTER DATABASE sepgsql_test_regression_1 RENAME TO sepgsql_test_regression;
|
|
ALTER SCHEMA regtest_schema_1 RENAME TO regtest_schema;
|
|
ALTER TABLE regtest_table_1 RENAME TO regtest_table;
|
|
ALTER SEQUENCE regtest_seq_1 RENAME TO regtest_seq;
|
|
ALTER VIEW regtest_view_1 RENAME TO regtest_view;
|
|
ALTER FUNCTION regtest_func_1(text) RENAME TO regtest_func;
|
|
|
|
SET search_path = regtest_schema, regtest_schema_2, public;
|
|
|
|
--
|
|
-- misc ALTER commands
|
|
--
|
|
ALTER DATABASE sepgsql_test_regression CONNECTION LIMIT 999;
|
|
ALTER DATABASE sepgsql_test_regression SET search_path TO regtest_schema, public; -- not supported yet
|
|
|
|
ALTER TABLE regtest_table ADD COLUMN d float;
|
|
ALTER TABLE regtest_table DROP COLUMN d;
|
|
ALTER TABLE regtest_table ALTER b SET DEFAULT 'abcd'; -- not supported yet
|
|
ALTER TABLE regtest_table ALTER b SET DEFAULT 'XYZ'; -- not supported yet
|
|
ALTER TABLE regtest_table ALTER b DROP DEFAULT; -- not supported yet
|
|
ALTER TABLE regtest_table ALTER b SET NOT NULL;
|
|
ALTER TABLE regtest_table ALTER b DROP NOT NULL;
|
|
ALTER TABLE regtest_table ALTER b SET STATISTICS -1;
|
|
ALTER TABLE regtest_table ALTER b SET (n_distinct = 999);
|
|
ALTER TABLE regtest_table ALTER b SET STORAGE PLAIN;
|
|
ALTER TABLE regtest_table ADD CONSTRAINT test_fk FOREIGN KEY (a) REFERENCES regtest_table_3(x); -- not supported
|
|
ALTER TABLE regtest_table ADD CONSTRAINT test_ck CHECK (b like '%abc%') NOT VALID; -- not supported
|
|
ALTER TABLE regtest_table VALIDATE CONSTRAINT test_ck; -- not supported
|
|
ALTER TABLE regtest_table DROP CONSTRAINT test_ck; -- not supported
|
|
|
|
CREATE TRIGGER regtest_test_trig BEFORE UPDATE ON regtest_table
|
|
FOR EACH ROW EXECUTE PROCEDURE suppress_redundant_updates_trigger();
|
|
|
|
ALTER TABLE regtest_table DISABLE TRIGGER regtest_test_trig; -- not supported
|
|
ALTER TABLE regtest_table ENABLE TRIGGER regtest_test_trig; -- not supported
|
|
|
|
CREATE RULE regtest_test_rule AS ON INSERT TO regtest_table_3 DO ALSO NOTHING;
|
|
ALTER TABLE regtest_table_3 DISABLE RULE regtest_test_rule; -- not supported
|
|
ALTER TABLE regtest_table_3 ENABLE RULE regtest_test_rule; -- not supported
|
|
|
|
ALTER TABLE regtest_table SET WITH OIDS;
|
|
ALTER TABLE regtest_table SET WITHOUT OIDS;
|
|
ALTER TABLE regtest_table SET (fillfactor = 75);
|
|
ALTER TABLE regtest_table RESET (fillfactor);
|
|
ALTER TABLE regtest_table_2 NO INHERIT regtest_table; -- not supported
|
|
ALTER TABLE regtest_table_2 INHERIT regtest_table; -- not supported
|
|
ALTER TABLE regtest_table SET TABLESPACE pg_default;
|
|
|
|
ALTER VIEW regtest_view SET (security_barrier);
|
|
|
|
ALTER SEQUENCE regtest_seq INCREMENT BY 10 START WITH 1000;
|
|
|
|
--
|
|
-- clean-up objects
|
|
--
|
|
RESET sepgsql.debug_audit;
|
|
RESET client_min_messages;
|
|
DROP DATABASE sepgsql_test_regression;
|
|
DROP SCHEMA regtest_schema CASCADE;
|
|
DROP SCHEMA regtest_schema_2 CASCADE;
|
|
DROP USER regress_sepgsql_test_user;
|