mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-30 03:01:27 +02:00
604f7956b9
There are four weaknesses in728f152e07f998d2cb4fe5f24ec8da2c3bda98f2: * append_init() in heapdesc.c was ugly and required that rm_identify return values are only valid till the next call. Instead just add a couple more switch() cases for the INIT_PAGE cases. Now the returned value will always be valid. * a couple rm_identify() callbacks missed masking xl_info with ~XLR_INFO_MASK. * pg_xlogdump didn't map a NULL rm_identify to UNKNOWN or a similar string. * append_init() was called when id=NULL - which should never actually happen. But it's better to be careful.
52 lines
1019 B
C
52 lines
1019 B
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* clogdesc.c
|
|
* rmgr descriptor routines for access/transam/clog.c
|
|
*
|
|
* Portions Copyright (c) 1996-2014, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
*
|
|
* IDENTIFICATION
|
|
* src/backend/access/rmgrdesc/clogdesc.c
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#include "postgres.h"
|
|
|
|
#include "access/clog.h"
|
|
|
|
|
|
void
|
|
clog_desc(StringInfo buf, XLogRecord *record)
|
|
{
|
|
char *rec = XLogRecGetData(record);
|
|
uint8 info = record->xl_info & ~XLR_INFO_MASK;
|
|
|
|
if (info == CLOG_ZEROPAGE || info == CLOG_TRUNCATE)
|
|
{
|
|
int pageno;
|
|
|
|
memcpy(&pageno, rec, sizeof(int));
|
|
appendStringInfo(buf, "%d", pageno);
|
|
}
|
|
}
|
|
|
|
const char *
|
|
clog_identify(uint8 info)
|
|
{
|
|
const char *id = NULL;
|
|
|
|
switch (info & ~XLR_INFO_MASK)
|
|
{
|
|
case CLOG_ZEROPAGE:
|
|
id = "ZEROPAGE";
|
|
break;
|
|
case CLOG_TRUNCATE:
|
|
id = "TRUNCATE";
|
|
break;
|
|
}
|
|
|
|
return id;
|
|
}
|