swap_relation_files() calls toast_get_valid_index() to find and lock this index, just before swapping with the rebuilt TOAST index. The latter function releases the lock before returning. Potential for mischief is low; a concurrent session can issue ALTER INDEX ... SET (fillfactor = ...), which is not alarming. Nonetheless, changing pg_class.relfilenode without a lock is unconventional. Back-patch to 9.5 (all supported versions), because another fix needs this. Discussion: https://postgr.es/m/20191226001521.GA1772687@rfd.leadboat.com |
||
---|---|---|
.. | ||
Makefile | ||
attmap.c | ||
bufmask.c | ||
detoast.c | ||
heaptuple.c | ||
indextuple.c | ||
printsimple.c | ||
printtup.c | ||
relation.c | ||
reloptions.c | ||
scankey.c | ||
session.c | ||
toast_internals.c | ||
tupconvert.c | ||
tupdesc.c |