mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-27 22:32:05 +02:00
7d7cc7fd6f
Fix pthread-win32.h and pthread-win32.c to provide a more complete emulation of POSIX pthread mutexes: define PTHREAD_MUTEX_INITIALIZER and make sure that pthread_mutex_lock() can operate on a mutex object that's been initialized that way. Then we don't need the duplicative platform-specific logic in default_threadlock() and pgtls_init(), which we'd otherwise need yet a third copy of for an upcoming bug fix. Also, since default_threadlock() supposes that pthread_mutex_lock() cannot fail, try to ensure that that's actually true, by getting rid of the malloc call that was formerly involved in initializing an emulated mutex. We can define an extra state for the spinlock field instead. Also, replace the similar code in ecpglib/misc.c with this version. While ecpglib's version at least had a POSIX-compliant API, it also had the potential of failing during mutex init (but here, because of CreateMutex failure rather than malloc failure). Since all of misc.c's callers ignore failures, it seems like a wise idea to avoid failures here too. A further improvement in this area could be to unify libpq's and ecpglib's implementations into a src/port/pthread-win32.c file. But that doesn't seem like a bug fix, so I'll desist for now. In preparation for the aforementioned bug fix, back-patch to all supported branches. Discussion: https://postgr.es/m/264860.1707163416@sss.pgh.pa.us |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| bsearch_arg.c | ||
| chklocale.c | ||
| dirent.c | ||
| dirmod.c | ||
| dlopen.c | ||
| erand48.c | ||
| explicit_bzero.c | ||
| fls.c | ||
| getaddrinfo.c | ||
| getopt_long.c | ||
| getopt.c | ||
| getpeereid.c | ||
| getrusage.c | ||
| gettimeofday.c | ||
| inet_aton.c | ||
| inet_net_ntop.c | ||
| kill.c | ||
| link.c | ||
| Makefile | ||
| mkdtemp.c | ||
| noblock.c | ||
| open.c | ||
| path.c | ||
| pg_bitutils.c | ||
| pg_crc32c_armv8_choose.c | ||
| pg_crc32c_armv8.c | ||
| pg_crc32c_sb8.c | ||
| pg_crc32c_sse42_choose.c | ||
| pg_crc32c_sse42.c | ||
| pg_strong_random.c | ||
| pgcheckdir.c | ||
| pgmkdirp.c | ||
| pgsleep.c | ||
| pgstrcasecmp.c | ||
| pgstrsignal.c | ||
| pqsignal.c | ||
| pread.c | ||
| preadv.c | ||
| pthread_barrier_wait.c | ||
| pthread-win32.h | ||
| pwrite.c | ||
| pwritev.c | ||
| qsort_arg.c | ||
| qsort.c | ||
| quotes.c | ||
| random.c | ||
| README | ||
| setenv.c | ||
| snprintf.c | ||
| srandom.c | ||
| strerror.c | ||
| strlcat.c | ||
| strlcpy.c | ||
| strnlen.c | ||
| strtof.c | ||
| system.c | ||
| tar.c | ||
| thread.c | ||
| unsetenv.c | ||
| win32.ico | ||
| win32common.c | ||
| win32env.c | ||
| win32error.c | ||
| win32fseek.c | ||
| win32security.c | ||
| win32setlocale.c | ||
| win32stat.c | ||
| win32ver.rc | ||
src/port/README
libpgport
=========
libpgport must have special behavior. It supplies functions to both
libraries and applications. However, there are two complexities:
1) Libraries need to use object files that are compiled with exactly
the same flags as the library. libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries. This is done by removing -lpgport from the link line:
# Need to recompile any libpgport object files
LIBS := $(filter-out -lpgport, $(LIBS))
and adding infrastructure to recompile the object files:
OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
connect.o misc.o path.o exec.o \
$(filter strlcat.o, $(LIBOBJS))
The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.
2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first. This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq. libpq's libpgport usage changes over time, so such a
dependency is a problem. Windows, Linux, AIX, and macOS use an export
list to control the symbols exported by libpq.