mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-23 23:57:18 +02:00
9c2f0a6c3c
Previously it was possible that a tuple was not pruned during vacuum,
even though its update xmax (i.e. the updating xid in a multixact with
both key share lockers and an updater) was below the cutoff horizon.
As the freezing code assumed, rightly so, that that's not supposed to
happen, xmax would be preserved (as a member of a new multixact or
xmax directly). That causes two problems: For one the tuple is below
the xmin horizon, which can cause problems if the clog is truncated or
once there's an xid wraparound. The bigger problem is that that will
break HOT chains, which in turn can lead two to breakages: First,
failing index lookups, which in turn can e.g lead to constraints being
violated. Second, future hot prunes / vacuums can end up making
invisible tuples visible again. There's other harmful scenarios.
Fix the problem by recognizing that tuples can be DEAD instead of
RECENTLY_DEAD, even if the multixactid has alive members, if the
update_xid is below the xmin horizon. That's safe because newer
versions of the tuple will contain the locking xids.
A followup commit will harden the code somewhat against future similar
bugs and already corrupted data.
Author: Andres Freund, with changes by Alvaro Herrera
Reported-By: Daniel Wood
Analyzed-By: Andres Freund, Alvaro Herrera, Robert Haas, Peter
Geoghegan, Daniel Wood, Yi Wen Wong, Michael Paquier
Reviewed-By: Alvaro Herrera, Robert Haas, Michael Paquier
Discussion:
https://postgr.es/m/E5711E62-8FDF-4DCA-A888-C200BF6B5742@amazon.com
https://postgr.es/m/20171102112019.33wb7g5wp4zpjelu@alap3.anarazel.de
Backpatch: 9.3-
67 lines
1.5 KiB
Plaintext
67 lines
1.5 KiB
Plaintext
test: read-only-anomaly
|
|
test: read-only-anomaly-2
|
|
test: read-only-anomaly-3
|
|
test: read-write-unique
|
|
test: read-write-unique-2
|
|
test: read-write-unique-3
|
|
test: read-write-unique-4
|
|
test: simple-write-skew
|
|
test: receipt-report
|
|
test: temporal-range-integrity
|
|
test: project-manager
|
|
test: classroom-scheduling
|
|
test: total-cash
|
|
test: referential-integrity
|
|
test: ri-trigger
|
|
test: partial-index
|
|
test: two-ids
|
|
test: multiple-row-versions
|
|
test: index-only-scan
|
|
test: deadlock-simple
|
|
test: deadlock-hard
|
|
test: deadlock-soft
|
|
test: deadlock-soft-2
|
|
test: fk-contention
|
|
test: fk-deadlock
|
|
test: fk-deadlock2
|
|
test: eval-plan-qual
|
|
test: lock-update-delete
|
|
test: lock-update-traversal
|
|
test: insert-conflict-do-nothing
|
|
test: insert-conflict-do-nothing-2
|
|
test: insert-conflict-do-update
|
|
test: insert-conflict-do-update-2
|
|
test: insert-conflict-do-update-3
|
|
test: insert-conflict-toast
|
|
test: delete-abort-savept
|
|
test: delete-abort-savept-2
|
|
test: aborted-keyrevoke
|
|
test: multixact-no-deadlock
|
|
test: multixact-no-forget
|
|
test: lock-committed-update
|
|
test: lock-committed-keyupdate
|
|
test: update-locked-tuple
|
|
test: propagate-lock-delete
|
|
test: tuplelock-conflict
|
|
test: tuplelock-update
|
|
test: freeze-the-dead
|
|
test: nowait
|
|
test: nowait-2
|
|
test: nowait-3
|
|
test: nowait-4
|
|
test: nowait-5
|
|
test: skip-locked
|
|
test: skip-locked-2
|
|
test: skip-locked-3
|
|
test: skip-locked-4
|
|
test: drop-index-concurrently-1
|
|
test: alter-table-1
|
|
test: alter-table-2
|
|
test: alter-table-3
|
|
test: create-trigger
|
|
test: sequence-ddl
|
|
test: async-notify
|
|
test: vacuum-reltuples
|
|
test: timeouts
|
|
test: vacuum-concurrent-drop
|