mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-22 07:33:22 +02:00
Because of gcc -Wmissing-prototypes, all functions in dynamically loadable modules must have a separate prototype declaration. This is meant to detect global functions that are not declared in header files, but in cases where the function is called via dfmgr, this is redundant. Besides filling up space with boilerplate, this is a frequent source of compiler warnings in extension modules. We can fix that by creating the function prototype as part of the PG_FUNCTION_INFO_V1 macro, which such modules have to use anyway. That makes the code of modules cleaner, because there is one less place where the entry points have to be listed, and creates an additional check that functions have the right prototype. Remove now redundant prototypes from contrib and other modules.
59 lines
1.5 KiB
C
59 lines
1.5 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* fsmfuncs.c
|
|
* Functions to investigate FSM pages
|
|
*
|
|
* These functions are restricted to superusers for the fear of introducing
|
|
* security holes if the input checking isn't as water-tight as it should.
|
|
* You'd need to be superuser to obtain a raw page image anyway, so
|
|
* there's hardly any use case for using these without superuser-rights
|
|
* anyway.
|
|
*
|
|
* Copyright (c) 2007-2014, PostgreSQL Global Development Group
|
|
*
|
|
* IDENTIFICATION
|
|
* contrib/pageinspect/fsmfuncs.c
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
|
|
#include "postgres.h"
|
|
|
|
#include "funcapi.h"
|
|
#include "lib/stringinfo.h"
|
|
#include "miscadmin.h"
|
|
#include "storage/fsm_internals.h"
|
|
#include "utils/builtins.h"
|
|
|
|
/*
|
|
* Dumps the contents of a FSM page.
|
|
*/
|
|
PG_FUNCTION_INFO_V1(fsm_page_contents);
|
|
|
|
Datum
|
|
fsm_page_contents(PG_FUNCTION_ARGS)
|
|
{
|
|
bytea *raw_page = PG_GETARG_BYTEA_P(0);
|
|
StringInfoData sinfo;
|
|
FSMPage fsmpage;
|
|
int i;
|
|
|
|
if (!superuser())
|
|
ereport(ERROR,
|
|
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
|
|
(errmsg("must be superuser to use raw page functions"))));
|
|
|
|
fsmpage = (FSMPage) PageGetContents(VARDATA(raw_page));
|
|
|
|
initStringInfo(&sinfo);
|
|
|
|
for (i = 0; i < NodesPerPage; i++)
|
|
{
|
|
if (fsmpage->fp_nodes[i] != 0)
|
|
appendStringInfo(&sinfo, "%d: %d\n", i, fsmpage->fp_nodes[i]);
|
|
}
|
|
appendStringInfo(&sinfo, "fp_next_slot: %d\n", fsmpage->fp_next_slot);
|
|
|
|
PG_RETURN_TEXT_P(cstring_to_text_with_len(sinfo.data, sinfo.len));
|
|
}
|