d6c55de1f9
I started out with the idea that we needed to detect use of %m format specs
in contexts other than elog/ereport calls, because we couldn't rely on that
working in *printf calls. But a better answer is to fix things so that it
does work. Now that we're using snprintf.c all the time, we can implement
%m in that and we've fixed the problem.
This requires also adjusting our various printf-wrapping functions so that
they ensure "errno" is preserved when they call snprintf.c.
Remove elog.c's handmade implementation of %m, and let it rely on
snprintf to support the feature. That should provide some performance
gain, though I've not attempted to measure it.
There are a lot of places where we could now simplify 'printf("%s",
strerror(errno))' into 'printf("%m")', but I'm not in any big hurry
to make that happen.
Patch by me, reviewed by Michael Paquier
Discussion: https://postgr.es/m/2975.1526862605@sss.pgh.pa.us
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| README | ||
| binaryheap.c | ||
| bipartite_match.c | ||
| bloomfilter.c | ||
| dshash.c | ||
| hyperloglog.c | ||
| ilist.c | ||
| knapsack.c | ||
| pairingheap.c | ||
| rbtree.c | ||
| stringinfo.c | ||
README
This directory contains a general purpose data structures, for use anywhere in the backend: binaryheap.c - a binary heap bipartite_match.c - Hopcroft-Karp maximum cardinality algorithm for bipartite graphs bloomfilter.c - probabilistic, space-efficient set membership testing dshash.c - concurrent hash tables backed by dynamic shared memory areas hyperloglog.c - a streaming cardinality estimator ilist.c - single and double-linked lists knapsack.c - knapsack problem solver pairingheap.c - a pairing heap rbtree.c - a red-black tree stringinfo.c - an extensible string type Aside from the inherent characteristics of the data structures, there are a few practical differences between the binary heap and the pairing heap. The binary heap is fully allocated at creation, and cannot be expanded beyond the allocated size. The pairing heap on the other hand has no inherent maximum size, but the caller needs to allocate each element being stored in the heap, while the binary heap works with plain Datums or pointers. The linked-lists in ilist.c can be embedded directly into other structs, as opposed to the List interface in nodes/pg_list.h.