rdelaage/postgresql
1
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-08-12 15:33:26 +02:00
Code Issues Packages Projects Releases Wiki Activity
a363bc6da9
postgresql/contrib/postgres_fdw
History
Etsuro Fujita a363bc6da9 Fix EXPLAIN ANALYZE for async-capable nodes. 
EXPLAIN ANALYZE for an async-capable ForeignScan node associated with
postgres_fdw is done just by using instrumentation for ExecProcNode()
called from the node's callbacks, causing the following problems:

1) If the remote table to scan is empty, the node is incorrectly
   considered as "never executed" by the command even if the node is
   executed, as ExecProcNode() isn't called from the node's callbacks at
   all in that case.
2) The command fails to collect timings for things other than
   ExecProcNode() done in the node, such as creating a cursor for the
   node's remote query.

To fix these problems, add instrumentation for async-capable nodes, and
modify postgres_fdw accordingly.

My oversight in commit 27e1f1456.

While at it, update a comment for the AsyncRequest struct in execnodes.h
and the documentation for the ForeignAsyncRequest API in fdwhandler.sgml
to match the code in ExecAsyncAppendResponse() in nodeAppend.c, and fix
typos in comments in nodeAppend.c.

Per report from Andrey Lepikhov, though I didn't use his patch.

Reviewed-by: Andrey Lepikhov
Discussion: https://postgr.es/m/2eb662bb-105d-fc20-7412-2f027cc3ca72%40postgrespro.ru
2021-05-12 14:00:00 +09:00
..
expected Fix EXPLAIN ANALYZE for async-capable nodes. 2021-05-12 14:00:00 +09:00
sql Fix EXPLAIN ANALYZE for async-capable nodes. 2021-05-12 14:00:00 +09:00
.gitignore Add postgres_fdw contrib module. 2013-02-21 05:27:16 -05:00
connection.c Allow TRUNCATE command to truncate foreign tables. 2021-04-08 20:56:08 +09:00
deparse.c Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper. 2021-04-27 14:41:27 +09:00
Makefile postgres_fdw: Add function to list cached connections to foreign servers. 2021-01-18 15:11:08 +09:00
option.c Allow TRUNCATE command to truncate foreign tables. 2021-04-08 20:56:08 +09:00
postgres_fdw--1.0--1.1.sql postgres_fdw: Add functions to discard cached connections. 2021-01-26 15:35:54 +09:00
postgres_fdw--1.0.sql Add postgres_fdw contrib module. 2013-02-21 05:27:16 -05:00
postgres_fdw.c Fix EXPLAIN ANALYZE for async-capable nodes. 2021-05-12 14:00:00 +09:00
postgres_fdw.control postgres_fdw: Add function to list cached connections to foreign servers. 2021-01-18 15:11:08 +09:00
postgres_fdw.h Don't pass "ONLY" options specified in TRUNCATE to foreign data wrapper. 2021-04-27 14:41:27 +09:00
shippable.c Replace remaining uses of "whitelist". 2021-01-05 14:00:16 +13:00