postgresql/src/port
Heikki Linnakangas a692ee5870 Replace SYSTEMQUOTEs with Windows-specific wrapper functions.
It's easy to forget using SYSTEMQUOTEs when constructing command strings
for system() or popen(). Even if we fix all the places missing it now, it is
bound to be forgotten again in the future. Introduce wrapper functions that
do the the extra quoting for you, and get rid of SYSTEMQUOTEs in all the
callers.

We previosly used SYSTEMQUOTEs in all the hard-coded command strings, and
this doesn't change the behavior of those. But user-supplied commands, like
archive_command, restore_command, COPY TO/FROM PROGRAM calls, as well as
pgbench's \shell, will now gain an extra pair of quotes. That is desirable,
but if you have existing scripts or config files that include an extra
pair of quotes, those might need to be adjusted.

Reviewed by Amit Kapila and Tom Lane
2014-05-05 16:07:40 +03:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
chklocale.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
crypt.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
dirent.c Properly check for readdir/closedir() failures 2014-03-21 13:45:11 -04:00
dirmod.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
erand48.c Run pgindent on 9.2 source tree in preparation for first 9.3 2012-06-10 15:20:04 -04:00
fls.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
fseeko.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
getaddrinfo.c Fix assorted issues in client host name lookup. 2014-04-02 17:11:24 -04:00
gethostname.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
getopt_long.c Remove optreset from src/port/ implementations of getopt and getopt_long. 2010-12-16 16:23:05 -05:00
getopt.c Centralize getopt-related declarations in a new header file pg_getopt.h. 2014-02-15 14:31:30 -05:00
getpeereid.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
getrusage.c C comments: remove odd blank lines after #ifdef WIN32 lines 2014-03-13 01:34:42 -04:00
gettimeofday.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
inet_aton.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
inet_net_ntop.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
isinf.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
kill.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
Makefile Move username lookup functions from /port to /common 2014-01-10 18:03:28 -05:00
noblock.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
open.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
path.c Preserve errno across free(). 2014-04-04 19:07:37 -04:00
pg_crc.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
pgcheckdir.c Remove MinGW readdir/errno bug workaround fixed on 2003-10-10 2014-03-21 13:47:37 -04:00
pgmkdirp.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
pgsleep.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
pgstrcasecmp.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
pqsignal.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort_arg.c Speed up in-memory tuplesorting. 2012-02-15 12:13:32 -05:00
qsort.c Make new event trigger facility actually do something. 2012-07-20 11:39:01 -04:00
quotes.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
random.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
README Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
rint.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
snprintf.c Allow use of "z" flag in our printf calls, and use it where appropriate. 2014-01-23 17:18:33 -05:00
sprompt.c C comments: remove odd blank lines after #ifdef WIN32 lines 2014-03-13 01:34:42 -04:00
srandom.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcpy.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
system.c Replace SYSTEMQUOTEs with Windows-specific wrapper functions. 2014-05-05 16:07:40 +03:00
tar.c Fix unportable coding in tarCreateHeader(). 2014-02-16 20:01:18 -05:00
thread.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
unsetenv.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
win32error.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
win32setlocale.c Update copyright for 2014 2014-01-07 16:05:30 -05:00
win32ver.rc Update copyright for 2014 2014-01-07 16:05:30 -05:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Win32, Linux, and Darwin use an export list to
control the symbols exported by libpq.