postgresql/src/port
Tom Lane a7a7387575 Further improve code for probing the availability of ARM CRC instructions.
Andrew Gierth pointed out that commit 1c72ec6f4 would yield the wrong
answer on big-endian ARM systems, because the data being CRC'd would be
different.  To fix that, and avoid the rather unsightly hard-wired
constant, simply compare the hardware and software implementations'
results.

While we're at it, also log the resulting decision at DEBUG1, and error
out if the hw and sw results unexpectedly differ.  Also, since this
file must compile for both frontend and backend, avoid incorrect
dependencies on backend-only headers.

In passing, add a comment to postmaster.c about when the CRC function
pointer will get initialized.

Thomas Munro, based on complaints from Andrew Gierth and Tom Lane

Discussion: https://postgr.es/m/HE1PR0801MB1323D171938EABC04FFE7FA9E3110@HE1PR0801MB1323.eurprd08.prod.outlook.com
2018-05-03 11:32:57 -04:00
..
.gitignore
chklocale.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
crypt.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
dirent.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
dirmod.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
erand48.c Replace PostmasterRandom() with a stronger source, second attempt. 2016-12-05 13:42:59 +02:00
fls.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
fseeko.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
getaddrinfo.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
getopt_long.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
getopt.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
getpeereid.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
getrusage.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
gettimeofday.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
inet_aton.c Correct include file name in inet_aton fallback. 2017-10-01 17:41:00 -07:00
inet_net_ntop.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
isinf.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
kill.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
Makefile Fix partial-build problems introduced by having more generated headers. 2018-04-09 16:42:10 -04:00
mkdtemp.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
noblock.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
open.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
path.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_crc32c_armv8_choose.c Further improve code for probing the availability of ARM CRC instructions. 2018-05-03 11:32:57 -04:00
pg_crc32c_armv8.c Preliminary work for pgindent run. 2018-04-26 14:45:04 -04:00
pg_crc32c_sb8.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_crc32c_sse42_choose.c Use ARMv8 CRC instructions where available. 2018-04-04 12:22:45 +03:00
pg_crc32c_sse42.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_strong_random.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pgcheckdir.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pgstrcasecmp.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pqsignal.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pthread-win32.h
qsort_arg.c Fix a low-probability crash in our qsort implementation. 2015-07-16 22:57:46 -04:00
qsort.c Fix a low-probability crash in our qsort implementation. 2015-07-16 22:57:46 -04:00
quotes.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
random.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
README Refer to OS X as "macOS", except for the port name which is still "darwin". 2016-09-25 15:40:57 -04:00
rint.c Upgrade src/port/rint.c to be POSIX-compliant. 2015-03-25 15:54:18 -04:00
snprintf.c Add an assertion that we don't pass NULL to snprintf("%s"). 2018-02-14 15:06:01 -05:00
sprompt.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
srandom.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
strerror.c
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
strnlen.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
system.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
tar.c Allow pg_basebackup to stream transaction log in tar mode 2016-10-23 15:23:11 +02:00
thread.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
unsetenv.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32error.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32security.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32setlocale.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32ver.rc Update copyright for 2018 2018-01-02 23:30:12 -05:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export list to
control the symbols exported by libpq.