mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-01 05:17:23 +02:00
It's possible to drop a column from an input table of a JOIN clause in a view, if that column is nowhere actually referenced in the view. But it will still be there in the JOIN clause's joinaliasvars list. We used to replace such entries with NULL Const nodes, which is handy for generation of RowExpr expansion of a whole-row reference to the view. The trouble with that is that it can't be distinguished from the situation after subquery pull-up of a constant subquery output expression below the JOIN. Instead, replace such joinaliasvars with null pointers (empty expression trees), which can't be confused with pulled-up expressions. expandRTE() still emits the old convention, though, for convenience of RowExpr generation and to reduce the risk of breaking extension code. In HEAD and 9.3, this patch also fixes a problem with some new code in ruleutils.c that was failing to cope with implicitly-casted joinaliasvars entries, as per recent report from Feike Steenbergen. That oversight was because of an inadequate description of the data structure in parsenodes.h, which I've now corrected. There were some pre-existing oversights of the same ilk elsewhere, which I believe are now all fixed. |
||
---|---|---|
.. | ||
adt | ||
cache | ||
error | ||
fmgr | ||
hash | ||
init | ||
mb | ||
misc | ||
mmgr | ||
resowner | ||
sort | ||
time | ||
.gitignore | ||
errcodes.txt | ||
Gen_dummy_probes.sed | ||
Gen_fmgrtab.pl | ||
generate-errcodes.pl | ||
Makefile | ||
probes.d |