postgresql/src/bin
Tom Lane a8d0732ac2 Remove manual tracking of file position in pg_dump/pg_backup_custom.c.
We do not really need to track the file position by hand.  We were
already relying on ftello() whenever the archive file is seekable,
while if it's not seekable we don't need the file position info
anyway because we're not going to be able to re-write the TOC.

Moreover, that tracking was buggy since it failed to account for
the effects of fseeko().  Somewhat remarkably, that seems not to
have made for any live bugs up to now.  We could fix the oversights,
but it seems better to just get rid of the whole error-prone mess.

In itself this is merely code cleanup.  However, it's necessary
infrastructure for an upcoming bug-fix patch (because that code
*does* need valid file position after fseeko).  The bug fix
needs to go back as far as v12; hence, back-patch that far.

Discussion: https://postgr.es/m/CALBH9DDuJ+scZc4MEvw5uO-=vRyR2=QF9+Yh=3hPEnKHWfS81A@mail.gmail.com
2020-07-17 13:04:05 -04:00
..
initdb Change default of password_encryption to scram-sha-256 2020-06-10 16:42:55 +02:00
pg_archivecleanup Translation updates 2020-05-18 12:49:30 +02:00
pg_basebackup Enable almost all TAP tests involving symlinks on Windows 2020-07-16 15:51:52 -04:00
pg_checksums Translation updates 2020-05-18 12:49:30 +02:00
pg_config Translation updates 2020-05-18 12:49:30 +02:00
pg_controldata Translation updates 2020-05-18 12:49:30 +02:00
pg_ctl Add test coverage for pg_current_logfile() function. 2020-07-08 13:41:52 -04:00
pg_dump Remove manual tracking of file position in pg_dump/pg_backup_custom.c. 2020-07-17 13:04:05 -04:00
pg_resetwal Translation updates 2020-05-18 12:49:30 +02:00
pg_rewind Enable almost all TAP tests involving symlinks on Windows 2020-07-16 15:51:52 -04:00
pg_test_fsync Switch pg_test_fsync to use binary mode on Windows 2020-07-16 15:52:37 +09:00
pg_test_timing Translation updates 2020-05-18 12:49:30 +02:00
pg_upgrade pg_upgrade: set vacuum_defer_cleanup_age to zero 2020-06-15 20:59:40 -04:00
pg_verifybackup tap tests: replace 'master' with 'primary'. 2020-07-08 12:39:56 -07:00
pg_waldump Translation updates 2020-05-18 12:49:30 +02:00
pgbench Initial pgindent and pgperltidy run for v13. 2020-05-14 13:06:50 -04:00
pgevent Remove libpq.rc, use win32ver.rc for libpq 2020-01-15 15:06:12 +01:00
psql Improvements to psql \dAo and \dAp commands 2020-07-13 18:53:20 +03:00
scripts Add --no-index-cleanup and --no-truncate to vacuumdb. 2020-06-22 13:23:38 +09:00
Makefile Rename pg_validatebackup to pg_verifybackup. 2020-04-12 11:26:05 -04:00