Tom Lane ae320fc216 Fix oversights in array manipulation. ... The nested-arrays code path in ExecEvalArrayExpr() used palloc to allocate the result array, whereas every other array-creating function has used palloc0 since 18c0b4ecc. This mostly works, but unused bits past the end of the nulls bitmap may end up undefined. That causes valgrind complaints with -DWRITE_READ_PARSE_PLAN_TREES, and could cause planner misbehavior as cited in 18c0b4ecc. There seems no very good reason why we should strive to avoid palloc0 in just this one case, so fix it the easy way with s/palloc/palloc0/. While looking at that I noted that we also failed to check for overflow of "nbytes" and "nitems" while summing the sizes of the sub-arrays, potentially allowing a crash due to undersized output allocation. For "nbytes", follow the policy used by other array-munging code of checking for overflow after each addition. (As elsewhere, the last addition of the array's overhead space doesn't need an extra check, since palloc itself will catch a value between 1Gb and 2Gb.) For "nitems", there's no very good reason to sum the inputs at all, since we can perfectly well use ArrayGetNItems' result instead of ignoring it. Per discussion of this bug, also remove redundant zeroing of the nulls bitmap in array_set_element and array_set_slice. Patch by Alexander Lakhin and myself, per bug #17858 from Alexander Lakhin; thanks also to Richard Guo. These bugs are a dozen years old, so back-patch to all supported branches. Discussion: https://postgr.es/m/17858-8fd287fd3663d051@postgresql.org		2023-03-26 13:41:06 -04:00
..
backend	Fix oversights in array manipulation.	2023-03-26 13:41:06 -04:00
bin	Fix pg_dump for hash partitioning on enum columns.	2023-03-17 13:31:40 -04:00
common	Inhibit mingw CRT's auto-globbing of command line arguments	2022-04-25 15:51:27 -04:00
fe_utils	Clean up assorted failures under clang's -fsanitize=undefined checks.	2022-03-03 18:13:24 -05:00
include	Fix race in parallel hash join batch cleanup, take II.	2023-03-21 14:43:07 +13:00
interfaces	Fix handling of SCRAM-SHA-256's channel binding with RSA-PSS certificates	2023-02-15 10:12:40 +09:00
makefiles	Select CFLAGS_SL at configure time, not in platform-specific Makefiles.	2019-10-21 12:32:36 -04:00
pl	Translation updates	2023-02-06 12:22:35 +01:00
port	Stamp 11.19.	2023-02-06 16:46:39 -05:00
template	On NetBSD, force dynamic symbol resolution at postmaster start.	2022-08-30 17:29:17 -04:00
test	Ignore dropped columns during apply of update/delete.	2023-03-21 08:39:00 +05:30
timezone	Update time zone data files to tzdata release 2022g.	2023-01-31 17:37:34 -05:00
tools	Don't force SQL_ASCII/no-locale for installcheck in vcregress.pl	2023-02-26 06:55:59 -05:00
tutorial	Doc: sync src/tutorial/basics.source with SGML documentation.	2022-11-19 13:09:14 -05:00
.gitignore	…
DEVELOPERS	…
Makefile	Fix partial-build problems introduced by having more generated headers.	2018-04-09 16:42:10 -04:00
Makefile.global.in	Prevent port collisions between concurrent TAP tests	2022-11-22 10:53:01 -05:00
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	2018-11-29 15:53:44 -05:00
nls-global.mk	nls-global.mk: search build dir for source files, too	2016-06-07 18:55:18 -04:00