5c02a00d44
This makes it much more convenient to build tools for Postgres that are separately compiled and require a matching CRC implementation. To prevent multiple copies of the CRC polynomial tables being introduced into the postgres binaries, they are now included in the static library libpgport that is mainly meant for replacement system functions. That seems like a bit of a kludge, but there's no better place. This cleans up building of the tools pg_controldata and pg_resetxlog, which previously had to build their own copies of pg_crc.o. In the future, external programs that need access to the CRC tables can include the tables directly from the new header file pg_crc_tables.h. Daniel Farina, reviewed by Abhijit Menon-Sen and Tom Lane |
||
---|---|---|
.. | ||
.gitignore | ||
Makefile | ||
README | ||
chklocale.c | ||
crypt.c | ||
dirent.c | ||
dirmod.c | ||
erand48.c | ||
exec.c | ||
fls.c | ||
fseeko.c | ||
getaddrinfo.c | ||
gethostname.c | ||
getopt.c | ||
getopt_long.c | ||
getpeereid.c | ||
getrusage.c | ||
gettimeofday.c | ||
inet_aton.c | ||
inet_net_ntop.c | ||
isinf.c | ||
kill.c | ||
memcmp.c | ||
noblock.c | ||
open.c | ||
path.c | ||
pg_crc.c | ||
pgcheckdir.c | ||
pgmkdirp.c | ||
pgsleep.c | ||
pgstrcasecmp.c | ||
pthread-win32.h | ||
qsort.c | ||
qsort_arg.c | ||
random.c | ||
rint.c | ||
snprintf.c | ||
sprompt.c | ||
srandom.c | ||
strdup.c | ||
strerror.c | ||
strlcat.c | ||
strlcpy.c | ||
strtol.c | ||
strtoul.c | ||
thread.c | ||
unsetenv.c | ||
win32.ico | ||
win32env.c | ||
win32error.c | ||
win32setlocale.c | ||
win32ver.rc |
README
src/port/README libpgport ========= libpgport must have special behavior. It supplies functions to both libraries and applications. However, there are two complexities: 1) Libraries need to use object files that are compiled with exactly the same flags as the library. libpgport might not use the same flags, so it is necessary to recompile the object files for individual libraries. This is done by removing -lpgport from the link line: # Need to recompile any libpgport object files LIBS := $(filter-out -lpgport, $(LIBS)) and adding infrastructure to recompile the object files: OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \ connect.o misc.o path.o exec.o \ $(filter snprintf.o, $(LIBOBJS)) The problem is that there is no testing of which object files need to be added, but missing functions usually show up when linking user applications. 2) For applications, we use -lpgport before -lpq, so the static files from libpgport are linked first. This avoids having applications dependent on symbols that are _used_ by libpq, but not intended to be exported by libpq. libpq's libpgport usage changes over time, so such a dependency is a problem. Win32, Linux, and Darwin use an export list to control the symbols exported by libpq.