mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-27 06:47:19 +02:00
Previously tables declared WITH OIDS, including a significant fraction of the catalog tables, stored the oid column not as a normal column, but as part of the tuple header. This special column was not shown by default, which was somewhat odd, as it's often (consider e.g. pg_class.oid) one of the more important parts of a row. Neither pg_dump nor COPY included the contents of the oid column by default. The fact that the oid column was not an ordinary column necessitated a significant amount of special case code to support oid columns. That already was painful for the existing, but upcoming work aiming to make table storage pluggable, would have required expanding and duplicating that "specialness" significantly. WITH OIDS has been deprecated since 2005 (commit ff02d0a05280e0). Remove it. Removing includes: - CREATE TABLE and ALTER TABLE syntax for declaring the table to be WITH OIDS has been removed (WITH (oids[ = true]) will error out) - pg_dump does not support dumping tables declared WITH OIDS and will issue a warning when dumping one (and ignore the oid column). - restoring an pg_dump archive with pg_restore will warn when restoring a table with oid contents (and ignore the oid column) - COPY will refuse to load binary dump that includes oids. - pg_upgrade will error out when encountering tables declared WITH OIDS, they have to be altered to remove the oid column first. - Functionality to access the oid of the last inserted row (like plpgsql's RESULT_OID, spi's SPI_lastoid, ...) has been removed. The syntax for declaring a table WITHOUT OIDS (or WITH (oids = false) for CREATE TABLE) is still supported. While that requires a bit of support code, it seems unnecessary to break applications / dumps that do not use oids, and are explicit about not using them. The biggest user of WITH OID columns was postgres' catalog. This commit changes all 'magic' oid columns to be columns that are normally declared and stored. To reduce unnecessary query breakage all the newly added columns are still named 'oid', even if a table's column naming scheme would indicate 'reloid' or such. This obviously requires adapting a lot code, mostly replacing oid access via HeapTupleGetOid() with access to the underlying Form_pg_*->oid column. The bootstrap process now assigns oids for all oid columns in genbki.pl that do not have an explicit value (starting at the largest oid previously used), only oids assigned later by oids will be above FirstBootstrapObjectId. As the oid column now is a normal column the special bootstrap syntax for oids has been removed. Oids are not automatically assigned during insertion anymore, all backend code explicitly assigns oids with GetNewOidWithIndex(). For the rare case that insertions into the catalog via SQL are called for the new pg_nextoid() function can be used (which only works on catalog tables). The fact that oid columns on system tables are now normal columns means that they will be included in the set of columns expanded by * (i.e. SELECT * FROM pg_class will now include the table's oid, previously it did not). It'd not technically be hard to hide oid column by default, but that'd mean confusing behavior would either have to be carried forward forever, or it'd cause breakage down the line. While it's not unlikely that further adjustments are needed, the scope/invasiveness of the patch makes it worthwhile to get merge this now. It's painful to maintain externally, too complicated to commit after the code code freeze, and a dependency of a number of other patches. Catversion bump, for obvious reasons. Author: Andres Freund, with contributions by John Naylor Discussion: https://postgr.es/m/20180930034810.ywp2c7awz7opzcfr@alap3.anarazel.de
126 lines
4.1 KiB
PL/PgSQL
126 lines
4.1 KiB
PL/PgSQL
--
|
|
-- Regression Test for DDL of Object Permission Checks
|
|
--
|
|
|
|
-- clean-up in case a prior regression run failed
|
|
SET client_min_messages TO 'warning';
|
|
DROP DATABASE IF EXISTS sepgsql_test_regression;
|
|
DROP USER IF EXISTS regress_sepgsql_test_user;
|
|
RESET client_min_messages;
|
|
|
|
-- confirm required permissions using audit messages
|
|
-- @SECURITY-CONTEXT=unconfined_u:unconfined_r:sepgsql_regtest_superuser_t:s0
|
|
SET sepgsql.debug_audit = true;
|
|
SET client_min_messages = LOG;
|
|
|
|
--
|
|
-- CREATE Permission checks
|
|
--
|
|
CREATE DATABASE sepgsql_test_regression;
|
|
|
|
CREATE USER regress_sepgsql_test_user;
|
|
|
|
CREATE SCHEMA regtest_schema;
|
|
|
|
GRANT ALL ON SCHEMA regtest_schema TO regress_sepgsql_test_user;
|
|
|
|
SET search_path = regtest_schema, public;
|
|
|
|
CREATE TABLE regtest_table (x serial primary key, y text);
|
|
|
|
ALTER TABLE regtest_table ADD COLUMN z int;
|
|
|
|
CREATE TABLE regtest_table_2 (a int);
|
|
|
|
CREATE TABLE regtest_ptable (a int) PARTITION BY RANGE (a);
|
|
CREATE TABLE regtest_ptable_ones PARTITION OF regtest_ptable FOR VALUES FROM ('0') TO ('10');
|
|
CREATE TABLE regtest_ptable_tens PARTITION OF regtest_ptable FOR VALUES FROM ('10') TO ('100');
|
|
|
|
ALTER TABLE regtest_ptable ADD COLUMN q int;
|
|
|
|
-- corresponding toast table should not have label and permission checks
|
|
ALTER TABLE regtest_table_2 ADD COLUMN b text;
|
|
|
|
-- VACUUM FULL internally create a new table and swap them later.
|
|
VACUUM FULL regtest_table;
|
|
VACUUM FULL regtest_ptable;
|
|
|
|
CREATE VIEW regtest_view AS SELECT * FROM regtest_table WHERE x < 100;
|
|
CREATE VIEW regtest_pview AS SELECT * FROM regtest_ptable WHERE a < 99;
|
|
|
|
CREATE SEQUENCE regtest_seq;
|
|
|
|
CREATE TYPE regtest_comptype AS (a int, b text);
|
|
|
|
CREATE FUNCTION regtest_func(text,int[]) RETURNS bool LANGUAGE plpgsql
|
|
AS 'BEGIN RAISE NOTICE ''regtest_func => %'', $1; RETURN true; END';
|
|
|
|
CREATE AGGREGATE regtest_agg (
|
|
sfunc1 = int4pl, basetype = int4, stype1 = int4, initcond1 = '0'
|
|
);
|
|
|
|
-- CREATE objects owned by others
|
|
SET SESSION AUTHORIZATION regress_sepgsql_test_user;
|
|
|
|
SET search_path = regtest_schema, public;
|
|
|
|
CREATE TABLE regtest_table_3 (x int, y serial);
|
|
CREATE TABLE regtest_ptable_3 (o int, p serial) PARTITION BY RANGE (o);
|
|
CREATE TABLE regtest_ptable_3_ones PARTITION OF regtest_ptable_3 FOR VALUES FROM ('0') to ('10');
|
|
CREATE TABLE regtest_ptable_3_tens PARTITION OF regtest_ptable_3 FOR VALUES FROM ('10') to ('100');
|
|
|
|
CREATE VIEW regtest_view_2 AS SELECT * FROM regtest_table_3 WHERE x < y;
|
|
CREATE VIEW regtest_pview_2 AS SELECT * FROM regtest_ptable_3 WHERE o < p;
|
|
|
|
CREATE FUNCTION regtest_func_2(int) RETURNS bool LANGUAGE plpgsql
|
|
AS 'BEGIN RETURN $1 * $1 < 100; END';
|
|
|
|
RESET SESSION AUTHORIZATION;
|
|
|
|
--
|
|
-- ALTER and CREATE/DROP extra attribute permissions
|
|
--
|
|
CREATE TABLE regtest_table_4 (x int primary key, y int, z int);
|
|
CREATE INDEX regtest_index_tbl4_y ON regtest_table_4(y);
|
|
CREATE INDEX regtest_index_tbl4_z ON regtest_table_4(z);
|
|
ALTER TABLE regtest_table_4 ALTER COLUMN y TYPE float;
|
|
DROP INDEX regtest_index_tbl4_y;
|
|
ALTER TABLE regtest_table_4
|
|
ADD CONSTRAINT regtest_tbl4_con EXCLUDE USING btree (z WITH =);
|
|
DROP TABLE regtest_table_4 CASCADE;
|
|
|
|
-- For partitioned tables
|
|
CREATE TABLE regtest_ptable_4 (x int, y int, z int) PARTITION BY RANGE (x);
|
|
CREATE TABLE regtest_ptable_4_ones PARTITION OF regtest_ptable_4 FOR VALUES FROM ('0') TO ('10');
|
|
|
|
CREATE INDEX regtest_pindex_tbl4_y ON regtest_ptable_4_ones(y);
|
|
CREATE INDEX regtest_pindex_tbl4_z ON regtest_ptable_4_ones(z);
|
|
ALTER TABLE regtest_ptable_4 ALTER COLUMN y TYPE float;
|
|
DROP INDEX regtest_pindex_tbl4_y;
|
|
ALTER TABLE regtest_ptable_4_ones
|
|
ADD CONSTRAINT regtest_ptbl4_con EXCLUDE USING btree (z WITH =);
|
|
DROP TABLE regtest_ptable_4 CASCADE;
|
|
|
|
--
|
|
-- DROP Permission checks (with clean-up)
|
|
--
|
|
|
|
DROP FUNCTION regtest_func(text,int[]);
|
|
DROP AGGREGATE regtest_agg(int);
|
|
|
|
DROP SEQUENCE regtest_seq;
|
|
DROP VIEW regtest_view;
|
|
|
|
ALTER TABLE regtest_table DROP COLUMN y;
|
|
|
|
ALTER TABLE regtest_ptable DROP COLUMN q CASCADE;
|
|
|
|
DROP TABLE regtest_table;
|
|
DROP TABLE regtest_ptable CASCADE;
|
|
|
|
DROP OWNED BY regress_sepgsql_test_user;
|
|
|
|
DROP DATABASE sepgsql_test_regression;
|
|
DROP USER regress_sepgsql_test_user;
|
|
DROP SCHEMA IF EXISTS regtest_schema CASCADE;
|