postgresql/src/port
Tom Lane f145454d57 Ensure _dosmaperr() actually sets errno correctly.
If logging is enabled, either ereport() or fprintf() might stomp on errno
internally, causing this function to return the wrong result.  That might
only end in a misleading error report, but in any code that's examining
errno to decide what to do next, the consequences could be far graver.

This has been broken since the very first version of this file in 2006
... it's a bit astonishing that we didn't identify this long ago.

Reported by Amit Kapila, though this isn't his proposed fix.
2013-11-23 18:24:26 -05:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
Makefile Switch dependency order of libpgcommon and libpgport 2013-10-17 22:02:35 -04:00
README Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
chklocale.c Renovate display of non-ASCII messages on Windows. 2013-06-26 11:17:33 -04:00
crypt.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
dirent.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
dirmod.c Move rmtree() from libpgport to libpgcommon 2013-10-19 10:20:51 -04:00
erand48.c Run pgindent on 9.2 source tree in preparation for first 9.3 2012-06-10 15:20:04 -04:00
fls.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
fseeko.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
getaddrinfo.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
gethostname.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
getopt.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
getopt_long.c Remove optreset from src/port/ implementations of getopt and getopt_long. 2010-12-16 16:23:05 -05:00
getpeereid.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
getrusage.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
gettimeofday.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
inet_aton.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
inet_net_ntop.c Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
isinf.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
kill.c Send SIGKILL to children if they don't die quickly in immediate shutdown 2013-06-28 17:49:46 -04:00
memcmp.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
noblock.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
open.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
path.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
pg_crc.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
pgcheckdir.c pgindent run for release 9.3 2013-05-29 16:58:43 -04:00
pgmkdirp.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
pgsleep.c Add a comment warning against use of pg_usleep() for long sleeps. 2013-06-23 14:43:10 -04:00
pgstrcasecmp.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
pqsignal.c Use SA_RESTART for all signals, including SIGALRM. 2013-06-15 15:39:51 -04:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort.c Make new event trigger facility actually do something. 2012-07-20 11:39:01 -04:00
qsort_arg.c Speed up in-memory tuplesorting. 2012-02-15 12:13:32 -05:00
quotes.c Add standard file header comment to quotes.c. 2013-02-27 18:42:40 +02:00
random.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
rint.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
snprintf.c pgindent run before PG 9.1 beta 1. 2011-04-10 11:42:00 -04:00
sprompt.c pgindent run for release 9.3 2013-05-29 16:58:43 -04:00
srandom.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcpy.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
tar.c Move tar function headers to pgtar.h 2013-01-02 20:34:08 +01:00
thread.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
unsetenv.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Enable building with Microsoft Visual Studio 2012. 2013-02-06 14:52:29 -05:00
win32error.c Ensure _dosmaperr() actually sets errno correctly. 2013-11-23 18:24:26 -05:00
win32setlocale.c Update copyrights for 2013 2013-01-01 17:15:01 -05:00
win32ver.rc Stamp HEAD as 9.4devel. 2013-06-14 14:41:28 -04:00

README

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Win32, Linux, and Darwin use an export list to
control the symbols exported by libpq.