postgresql/src/backend/utils
Michael Paquier b83dcf7928 Add result size as argument of pg_cryptohash_final() for overflow checks
With its current design, a careless use of pg_cryptohash_final() could
would result in an out-of-bound write in memory as the size of the
destination buffer to store the result digest is not known to the
cryptohash internals, without the caller knowing about that.  This
commit adds a new argument to pg_cryptohash_final() to allow such sanity
checks, and implements such defenses.

The internals of SCRAM for HMAC could be tightened a bit more, but as
everything is based on SCRAM_KEY_LEN with uses particular to this code
there is no need to complicate its interface more than necessary, and
this comes back to the refactoring of HMAC in core.  Except that, this
minimizes the uses of the existing DIGEST_LENGTH variables, relying
instead on sizeof() for the result sizes.  In ossp-uuid, this also makes
the code more defensive, as it already relied on dce_uuid_t being at
least the size of a MD5 digest.

This is in philosophy similar to cfc40d3 for base64.c and aef8948 for
hex.c.

Reported-by: Ranier Vilela
Author: Michael Paquier, Ranier Vilela
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/CAEudQAoqEGmcff3J4sTSV-R_16Monuz-UpJFbf_dnVH=APr02Q@mail.gmail.com
2021-02-15 10:18:34 +09:00
..
adt Add result size as argument of pg_cryptohash_final() for overflow checks 2021-02-15 10:18:34 +09:00
cache Preserve pg_attribute.attstattarget across REINDEX CONCURRENTLY 2021-02-10 13:06:48 +09:00
error Add pg_stat_database counters for sessions and session time 2021-01-17 13:52:31 +01:00
fmgr Fix broken ruleutils support for function TRANSFORM clauses. 2021-01-25 13:03:43 -05:00
hash Update copyright for 2021 2021-01-02 13:06:25 -05:00
init Reduce the default value of vacuum_cost_page_miss. 2021-01-27 15:11:13 -08:00
mb Add direct conversion routines between EUC_TW and Big5. 2021-01-28 14:53:03 +02:00
misc Reduce the default value of vacuum_cost_page_miss. 2021-01-27 15:11:13 -08:00
mmgr Improve performance of repeated CALLs within plpgsql procedures. 2021-01-25 22:28:29 -05:00
resowner Improve performance of repeated CALLs within plpgsql procedures. 2021-01-25 22:28:29 -05:00
sort Update copyright for 2021 2021-01-02 13:06:25 -05:00
time Revive "snapshot too old" with wal_level=minimal and SET TABLESPACE. 2021-01-30 00:12:18 -08:00
.gitignore Rearrange makefile rules for running Gen_fmgrtab.pl. 2018-05-03 17:54:18 -04:00
errcodes.txt Rethink SQLSTATE code for ERRCODE_IDLE_SESSION_TIMEOUT. 2021-01-11 14:53:42 -05:00
Gen_dummy_probes.pl Update copyright for 2021 2021-01-02 13:06:25 -05:00
Gen_dummy_probes.sed Update copyright for 2021 2021-01-02 13:06:25 -05:00
Gen_fmgrtab.pl Update copyright for 2021 2021-01-02 13:06:25 -05:00
generate-errcodes.pl Update copyright for 2021 2021-01-02 13:06:25 -05:00
Makefile Update copyright for 2021 2021-01-02 13:06:25 -05:00
probes.d Update copyright for 2021 2021-01-02 13:06:25 -05:00