postgresql/src/bin
Michael Paquier b83dcf7928 Add result size as argument of pg_cryptohash_final() for overflow checks
With its current design, a careless use of pg_cryptohash_final() could
would result in an out-of-bound write in memory as the size of the
destination buffer to store the result digest is not known to the
cryptohash internals, without the caller knowing about that.  This
commit adds a new argument to pg_cryptohash_final() to allow such sanity
checks, and implements such defenses.

The internals of SCRAM for HMAC could be tightened a bit more, but as
everything is based on SCRAM_KEY_LEN with uses particular to this code
there is no need to complicate its interface more than necessary, and
this comes back to the refactoring of HMAC in core.  Except that, this
minimizes the uses of the existing DIGEST_LENGTH variables, relying
instead on sizeof() for the result sizes.  In ossp-uuid, this also makes
the code more defensive, as it already relied on dce_uuid_t being at
least the size of a MD5 digest.

This is in philosophy similar to cfc40d3 for base64.c and aef8948 for
hex.c.

Reported-by: Ranier Vilela
Author: Michael Paquier, Ranier Vilela
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/CAEudQAoqEGmcff3J4sTSV-R_16Monuz-UpJFbf_dnVH=APr02Q@mail.gmail.com
2021-02-15 10:18:34 +09:00
..
initdb Remove extra Success message at the end of initdb 2021-02-10 18:21:55 +01:00
pg_archivecleanup Improve common/logging.c's support for multiple verbosity levels. 2020-09-17 12:52:18 -04:00
pg_basebackup Remove gratuitous uses of deprecated SELECT INTO 2021-01-28 14:28:41 +01:00
pg_checksums Remove gratuitous uses of deprecated SELECT INTO 2021-01-28 14:28:41 +01:00
pg_config Update copyright for 2021 2021-01-02 13:06:25 -05:00
pg_controldata Update copyright for 2021 2021-01-02 13:06:25 -05:00
pg_ctl Update copyright for 2021 2021-01-02 13:06:25 -05:00
pg_dump pg_dump: Add const decorations 2021-02-10 13:21:47 +01:00
pg_resetwal Update copyright for 2021 2021-01-02 13:06:25 -05:00
pg_rewind Update copyright for 2021 2021-01-02 13:06:25 -05:00
pg_test_fsync Clean up after newly-added tests for pg_test_fsync and pg_test_timing. 2020-10-07 13:27:33 -04:00
pg_test_timing Clean up after newly-added tests for pg_test_fsync and pg_test_timing. 2020-10-07 13:27:33 -04:00
pg_upgrade Avoid redundantly prefixing PQerrorMessage for a connection failure. 2021-01-22 16:52:31 -05:00
pg_verifybackup Add result size as argument of pg_cryptohash_final() for overflow checks 2021-02-15 10:18:34 +09:00
pg_waldump Update copyright for 2021 2021-01-02 13:06:25 -05:00
pgbench pgbench: Remove dead code 2021-01-28 12:50:40 -03:00
pgevent Update copyright for 2021 2021-01-02 13:06:25 -05:00
psql Add option PROCESS_TOAST to VACUUM 2021-02-09 14:13:57 +09:00
scripts Add option PROCESS_TOAST to VACUUM 2021-02-09 14:13:57 +09:00
Makefile Update copyright for 2021 2021-01-02 13:06:25 -05:00