postgresql

mirror of https://git.postgresql.org/git/postgresql.git synced 2024-09-13 22:40:36 +02:00

Go to file

Tom Lane b9515b6287 Use pselect(2) not select(2), if available, to wait in postmaster's loop. Traditionally we've unblocked signals, called select(2), and then blocked signals again. The code expects that the select() will be cancelled with EINTR if an interrupt occurs; but there's a race condition, which is that an already-pending signal will be delivered as soon as we unblock, and then when we reach select() there will be nothing preventing it from waiting. This can result in a long delay before we perform any action that ServerLoop was supposed to have taken in response to the signal. As with the somewhat-similar symptoms fixed by commit `893902085`, the main practical problem is slow launching of parallel workers. The window for trouble is usually pretty short, corresponding to one iteration of ServerLoop; but it's not negligible. To fix, use pselect(2) in place of select(2) where available, as that's designed to solve exactly this problem. Where not available, we continue to use the old way, and are no worse off than before. pselect(2) has been required by POSIX since about 2001, so most modern platforms should have it. A bigger portability issue is that some implementations are said to be non-atomic, ie pselect() isn't really any different from unblock/select/reblock. Still, we're no worse off than before on such a platform. There is talk of rewriting the postmaster to use a WaitEventSet and not do signal response work in signal handlers, at which point this could be reverted, since we'd be using a self-pipe to solve the race condition. But that's not happening before v11 at the earliest. Back-patch to 9.6. The problem exists much further back, but the worst symptom arises only in connection with parallel query, so it does not seem worth taking any portability risks in older branches. Discussion: https://postgr.es/m/9205.1492833041@sss.pgh.pa.us		2017-04-24 14:03:14 -04:00
config	Update config.guess and config.sub	2016-05-06 14:02:44 -04:00
contrib	Further fix pg_trgm's extraction of trigrams from regular expressions.	2017-04-14 14:52:03 -04:00
doc	doc: Update link	2017-04-21 19:43:50 -04:00
src	Use pselect(2) not select(2), if available, to wait in postmaster's loop.	2017-04-24 14:03:14 -04:00
.dir-locals.el
.gitattributes
.gitignore
aclocal.m4
configure	Use pselect(2) not select(2), if available, to wait in postmaster's loop.	2017-04-24 14:03:14 -04:00
configure.in	Use pselect(2) not select(2), if available, to wait in postmaster's loop.	2017-04-24 14:03:14 -04:00
COPYRIGHT	Update copyright for 2017	2017-01-03 12:37:53 -05:00
GNUmakefile.in
HISTORY
Makefile
README
README.git

README

PostgreSQL Database Management System
=====================================

This directory contains the source code distribution of the PostgreSQL
database management system.

PostgreSQL is an advanced object-relational database management system
that supports an extended subset of the SQL standard, including
transactions, foreign keys, subqueries, triggers, user-defined types
and functions.  This distribution also contains C language bindings.

PostgreSQL has many language interfaces, many of which are listed here:

	http://www.postgresql.org/download

See the file INSTALL for instructions on how to build and install
PostgreSQL.  That file also lists supported operating systems and
hardware platforms and contains information regarding any other
software packages that are required to build or run the PostgreSQL
system.  Copyright and license information can be found in the
file COPYRIGHT.  A comprehensive documentation set is included in this
distribution; it can be read as described in the installation
instructions.

The latest version of this software may be obtained at
http://www.postgresql.org/download/.  For more information look at our
web site located at http://www.postgresql.org/.