mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-16 02:11:09 +02:00
2ed532ee8c
Most error messages about a relkind that was not supported or
appropriate for the command was of the pattern
"relation \"%s\" is not a table, foreign table, or materialized view"
This style can become verbose and tedious to maintain. Moreover, it's
not very helpful: If I'm trying to create a comment on a TOAST table,
which is not supported, then the information that I could have created
a comment on a materialized view is pointless.
Instead, write the primary error message shorter and saying more
directly that what was attempted is not possible. Then, in the detail
message, explain that the operation is not supported for the relkind
the object was. To simplify that, add a new function
errdetail_relkind_not_supported() that does this.
In passing, make use of RELKIND_HAS_STORAGE() where appropriate,
instead of listing out the relkinds individually.
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/dc35a398-37d0-75ce-07ea-1dd71d98f8ec@2ndquadrant.com
200 lines
7.1 KiB
Plaintext
200 lines
7.1 KiB
Plaintext
CREATE TABLE heaptest (a integer, b text);
|
|
REVOKE ALL ON heaptest FROM PUBLIC;
|
|
-- Check that invalid skip option is rejected
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'rope');
|
|
ERROR: invalid skip option
|
|
HINT: Valid skip options are "all-visible", "all-frozen", and "none".
|
|
-- Check specifying invalid block ranges when verifying an empty table
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', startblock := 0, endblock := 0);
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', startblock := 5, endblock := 8);
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
-- Check that valid options are not rejected nor corruption reported
|
|
-- for an empty table, and that skip enum-like parameter is case-insensitive
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'none');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'all-frozen');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'all-visible');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'None');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'All-Frozen');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'All-Visible');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'NONE');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'ALL-FROZEN');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'ALL-VISIBLE');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
-- Add some data so subsequent tests are not entirely trivial
|
|
INSERT INTO heaptest (a, b)
|
|
(SELECT gs, repeat('x', gs)
|
|
FROM generate_series(1,50) gs);
|
|
-- Check that valid options are not rejected nor corruption reported
|
|
-- for a non-empty table
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'none');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'all-frozen');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'all-visible');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', startblock := 0, endblock := 0);
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
CREATE ROLE regress_heaptest_role;
|
|
-- verify permissions are checked (error due to function not callable)
|
|
SET ROLE regress_heaptest_role;
|
|
SELECT * FROM verify_heapam(relation := 'heaptest');
|
|
ERROR: permission denied for function verify_heapam
|
|
RESET ROLE;
|
|
GRANT EXECUTE ON FUNCTION verify_heapam(regclass, boolean, boolean, text, bigint, bigint) TO regress_heaptest_role;
|
|
-- verify permissions are now sufficient
|
|
SET ROLE regress_heaptest_role;
|
|
SELECT * FROM verify_heapam(relation := 'heaptest');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
RESET ROLE;
|
|
-- Check specifying invalid block ranges when verifying a non-empty table.
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', startblock := 0, endblock := 10000);
|
|
ERROR: ending block number must be between 0 and 0
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', startblock := 10000, endblock := 11000);
|
|
ERROR: starting block number must be between 0 and 0
|
|
-- Vacuum freeze to change the xids encountered in subsequent tests
|
|
VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) heaptest;
|
|
-- Check that valid options are not rejected nor corruption reported
|
|
-- for a non-empty frozen table
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'none');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'all-frozen');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', skip := 'all-visible');
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
SELECT * FROM verify_heapam(relation := 'heaptest', startblock := 0, endblock := 0);
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
-- Check that partitioned tables (the parent ones) which don't have visibility
|
|
-- maps are rejected
|
|
CREATE TABLE test_partitioned (a int, b text default repeat('x', 5000))
|
|
PARTITION BY list (a);
|
|
SELECT * FROM verify_heapam('test_partitioned',
|
|
startblock := NULL,
|
|
endblock := NULL);
|
|
ERROR: cannot check relation "test_partitioned"
|
|
DETAIL: This operation is not supported for partitioned tables.
|
|
-- Check that valid options are not rejected nor corruption reported
|
|
-- for an empty partition table (the child one)
|
|
CREATE TABLE test_partition partition OF test_partitioned FOR VALUES IN (1);
|
|
SELECT * FROM verify_heapam('test_partition',
|
|
startblock := NULL,
|
|
endblock := NULL);
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
-- Check that valid options are not rejected nor corruption reported
|
|
-- for a non-empty partition table (the child one)
|
|
INSERT INTO test_partitioned (a) (SELECT 1 FROM generate_series(1,1000) gs);
|
|
SELECT * FROM verify_heapam('test_partition',
|
|
startblock := NULL,
|
|
endblock := NULL);
|
|
blkno | offnum | attnum | msg
|
|
-------+--------+--------+-----
|
|
(0 rows)
|
|
|
|
-- Check that indexes are rejected
|
|
CREATE INDEX test_index ON test_partition (a);
|
|
SELECT * FROM verify_heapam('test_index',
|
|
startblock := NULL,
|
|
endblock := NULL);
|
|
ERROR: cannot check relation "test_index"
|
|
DETAIL: This operation is not supported for indexes.
|
|
-- Check that views are rejected
|
|
CREATE VIEW test_view AS SELECT 1;
|
|
SELECT * FROM verify_heapam('test_view',
|
|
startblock := NULL,
|
|
endblock := NULL);
|
|
ERROR: cannot check relation "test_view"
|
|
DETAIL: This operation is not supported for views.
|
|
-- Check that sequences are rejected
|
|
CREATE SEQUENCE test_sequence;
|
|
SELECT * FROM verify_heapam('test_sequence',
|
|
startblock := NULL,
|
|
endblock := NULL);
|
|
ERROR: cannot check relation "test_sequence"
|
|
DETAIL: This operation is not supported for sequences.
|
|
-- Check that foreign tables are rejected
|
|
CREATE FOREIGN DATA WRAPPER dummy;
|
|
CREATE SERVER dummy_server FOREIGN DATA WRAPPER dummy;
|
|
CREATE FOREIGN TABLE test_foreign_table () SERVER dummy_server;
|
|
SELECT * FROM verify_heapam('test_foreign_table',
|
|
startblock := NULL,
|
|
endblock := NULL);
|
|
ERROR: cannot check relation "test_foreign_table"
|
|
DETAIL: This operation is not supported for foreign tables.
|
|
-- cleanup
|
|
DROP TABLE heaptest;
|
|
DROP TABLE test_partition;
|
|
DROP TABLE test_partitioned;
|
|
DROP OWNED BY regress_heaptest_role; -- permissions
|
|
DROP ROLE regress_heaptest_role;
|