rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
postgresql/src/bin/pg_amcheck
History
David Rowley 8b26769bc4 Fix an assortment of improper usages of string functions 
In a similar effort to f736e188c and 110d81728, fixup various usages of
string functions where a more appropriate function is available and more
fit for purpose.

These changes include:

1. Use cstring_to_text_with_len() instead of cstring_to_text() when
   working with a StringInfoData and the length can easily be obtained.
2. Use appendStringInfoString() instead of appendStringInfo() when no
   formatting is required.
3. Use pstrdup(...) instead of psprintf("%s", ...)
4. Use pstrdup(...) instead of psprintf(...) (with no formatting)
5. Use appendPQExpBufferChar() instead of appendPQExpBufferStr() when the
   length of the string being appended is 1.
6. appendStringInfoChar() instead of appendStringInfo() when no formatting
   is required and string is 1 char long.
7. Use appendPQExpBufferStr(b, .) instead of appendPQExpBuffer(b, "%s", .)
8. Don't use pstrdup when it's fine to just point to the string constant.

I (David) did find other cases of #8 but opted to use #4 instead as I
wasn't certain enough that applying #8 was ok (e.g in hba.c)

Author: Ranier Vilela, David Rowley
Discussion: https://postgr.es/m/CAApHDvo2j2+RJBGhNtUz6BxabWWh2Jx16wMUMWKUjv70Ver1vg@mail.gmail.com
 		2022-09-06 13:19:44 +12:00
..
po NLS: Put list of available languages into LINGUAS files 2022-07-13 08:19:17 +02:00
t Pre-beta mechanical code beautification. 2022-05-12 15:17:30 -04:00
.gitignore Add pg_amcheck, a CLI for contrib/amcheck. 2021-03-12 13:00:01 -05:00
Makefile Update copyright for 2022 2022-01-07 19:04:57 -05:00
README Doc: improve README files associated with TAP tests. 2021-10-31 18:12:44 -04:00
nls.mk Revert "Use wildcards instead of manually-maintained file lists in */nls.mk." 2022-07-13 14:29:10 -04:00
pg_amcheck.c Fix an assortment of improper usages of string functions 2022-09-06 13:19:44 +12:00

README 

src/bin/pg_amcheck/README

pg_amcheck is a command-line tool for running the amcheck extension.

Running the regression tests
============================

NOTE: You must have given the --enable-tap-tests argument to configure.
Also, to use "make installcheck", you must have built and installed
contrib/amcheck and contrib/pageinspect in addition to the core code.

Run
    make check
or
    make installcheck
You can use "make installcheck" if you previously did "make install".
In that case, the code in the installation tree is tested.  With
"make check", a temporary installation tree is built from the current
sources and then tested.

See src/test/perl/README for more info about running these tests.