mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-09 12:50:02 +02:00
c7b8998ebb
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4d wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
58 lines
2.2 KiB
C
58 lines
2.2 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* typecmds.h
|
|
* prototypes for typecmds.c.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/commands/typecmds.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef TYPECMDS_H
|
|
#define TYPECMDS_H
|
|
|
|
#include "access/htup.h"
|
|
#include "catalog/dependency.h"
|
|
#include "nodes/parsenodes.h"
|
|
|
|
|
|
#define DEFAULT_TYPDELIM ','
|
|
|
|
extern ObjectAddress DefineType(ParseState *pstate, List *names, List *parameters);
|
|
extern void RemoveTypeById(Oid typeOid);
|
|
extern ObjectAddress DefineDomain(CreateDomainStmt *stmt);
|
|
extern ObjectAddress DefineEnum(CreateEnumStmt *stmt);
|
|
extern ObjectAddress DefineRange(CreateRangeStmt *stmt);
|
|
extern ObjectAddress AlterEnum(AlterEnumStmt *stmt);
|
|
extern ObjectAddress DefineCompositeType(RangeVar *typevar, List *coldeflist);
|
|
extern Oid AssignTypeArrayOid(void);
|
|
|
|
extern ObjectAddress AlterDomainDefault(List *names, Node *defaultRaw);
|
|
extern ObjectAddress AlterDomainNotNull(List *names, bool notNull);
|
|
extern ObjectAddress AlterDomainAddConstraint(List *names, Node *constr,
|
|
ObjectAddress *constrAddr);
|
|
extern ObjectAddress AlterDomainValidateConstraint(List *names, char *constrName);
|
|
extern ObjectAddress AlterDomainDropConstraint(List *names, const char *constrName,
|
|
DropBehavior behavior, bool missing_ok);
|
|
|
|
extern void checkDomainOwner(HeapTuple tup);
|
|
|
|
extern ObjectAddress RenameType(RenameStmt *stmt);
|
|
|
|
extern ObjectAddress AlterTypeOwner(List *names, Oid newOwnerId, ObjectType objecttype);
|
|
extern void AlterTypeOwner_oid(Oid typeOid, Oid newOwnerId, bool hasDependEntry);
|
|
extern void AlterTypeOwnerInternal(Oid typeOid, Oid newOwnerId);
|
|
|
|
extern ObjectAddress AlterTypeNamespace(List *names, const char *newschema,
|
|
ObjectType objecttype, Oid *oldschema);
|
|
extern Oid AlterTypeNamespace_oid(Oid typeOid, Oid nspOid, ObjectAddresses *objsMoved);
|
|
extern Oid AlterTypeNamespaceInternal(Oid typeOid, Oid nspOid,
|
|
bool isImplicitArray,
|
|
bool errorOnTableType,
|
|
ObjectAddresses *objsMoved);
|
|
|
|
#endif /* TYPECMDS_H */
|