postgresql

mirror of https://git.postgresql.org/git/postgresql.git synced 2024-09-06 20:09:21 +02:00

History

Tom Lane c8ab970179 Fix list-munging bug that broke SQL function result coercions. Since commit `913bbd88d`, check_sql_fn_retval() can either insert type coercion steps in-line in the Query that produces the SQL function's results, or generate a new top-level Query to perform the coercions, if modifying the Query's output in-place wouldn't be safe. However, it appears that the latter case has never actually worked, because the code tried to inject the new Query back into the query list it was passed ... which is not the list that will be used for later processing when we execute the SQL function "normally" (without inlining it). So we ended up with no coercion happening at run-time, leading to wrong results or crashes depending on the datatypes involved. While the regression tests look like they cover this area well enough, through a huge bit of bad luck all the test cases that exercise the separate-Query path were checking either inline-able cases (which accidentally didn't have the bug) or cases that are no-ops at runtime (e.g., varchar to text), so that the failure to perform the coercion wasn't obvious. The fact that the cases that don't work weren't allowed at all before v13 probably contributed to not noticing the problem sooner, too. To fix, get rid of the separate "flat" list of Query nodes and instead pass the real two-level list that is going to be used later. I chose to make the same change in check_sql_fn_statements(), although that has no actual bug, just so that we don't need that data structure at all. This is an API change, as evidenced by the adjustments needed to callers outside functions.c. That's a bit scary to be doing in a released branch, but so far as I can tell from a quick search, there are no outside callers of these functions (and they are sufficiently specific to our semantics for SQL-language functions that it's not apparent why any extension would need to call them). In any case, v13 already changed the API of check_sql_fn_retval() compared to prior branches. Per report from pinker. Back-patch to v13 where this code came in. Discussion: https://postgr.es/m/1603050466566-0.post@n3.nabble.com		2020-10-19 14:33:09 -04:00
..
authentication	Make new authentication test case more robust.	2020-09-04 21:01:58 -04:00
examples	Update copyrights for 2020	2020-01-01 12:21:45 -05:00
isolation	Install pg_isolation_regress and isolationtester	2020-10-15 13:09:29 -03:00
kerberos	Correct several behavior descriptions in comments.	2020-08-15 20:21:52 -07:00
ldap	Fix rare failure in LDAP tests.	2020-08-03 12:49:36 +12:00
locale	Use perl warnings pragma consistently	2020-04-13 11:55:45 -04:00
mb	Fix MB regression tests for WAL-logging of hash indexes.	2017-03-15 07:25:36 -04:00
modules	Rethink recent fix for pg_dump's handling of extension config tables.	2020-10-07 12:51:02 -04:00
perl	Put back explicit setting of replication values within TAP tests.	2020-10-01 10:59:20 -04:00
recovery	Try to unbreak 021_row_visibility.pl on mingw.	2020-10-05 19:20:17 -07:00
regress	Fix list-munging bug that broke SQL function result coercions.	2020-10-19 14:33:09 -04:00
ssl	Correct several behavior descriptions in comments.	2020-08-15 20:21:52 -07:00
subscription	Fix query in new test to check tables are synced	2020-10-15 09:48:36 -03:00
thread	Update the Winsock API version requested by libpq.	2020-10-18 12:56:43 -04:00
Makefile	Revert "Allow on-line enabling and disabling of data checksums"	2018-04-09 19:03:42 +02:00
README	Add TAP tests for password-based authentication methods.	2017-03-17 11:34:16 +02:00

README

PostgreSQL tests
================

This directory contains a variety of test infrastructure as well as some of the
tests in PostgreSQL. Not all tests are here -- in particular, there are more in
individual contrib/ modules and in src/bin.

Not all these tests get run by "make check". Check src/test/Makefile to see
which tests get run automatically.

authentication/
  Tests for authentication

examples/
  Demonstration programs for libpq that double as regression tests via
  "make check"

isolation/
  Tests for concurrent behavior at the SQL level

locale/
  Sanity checks for locale data, encodings, etc

mb/
  Tests for multibyte encoding (UTF-8) support

modules/
  Extensions used only or mainly for test purposes, generally not suitable
  for installing in production databases

perl/
  Infrastructure for Perl-based TAP tests

recovery/
  Test suite for recovery and replication

regress/
  PostgreSQL's main regression test suite, pg_regress

ssl/
  Tests to exercise and verify SSL certificate handling

subscription/
  Tests for logical replication

thread/
  A thread-safety-testing utility used by configure