postgresql/src/port
Alvaro Herrera c9d2977519 Clean up newlines following left parentheses
We used to strategically place newlines after some function call left
parentheses to make pgindent move the argument list a few chars to the
left, so that the whole line would fit under 80 chars.  However,
pgindent no longer does that, so the newlines just made the code
vertically longer for no reason.  Remove those newlines, and reflow some
of those lines for some extra naturality.

Reviewed-by: Michael Paquier, Tom Lane
Discussion: https://postgr.es/m/20200129200401.GA6303@alvherre.pgsql
2020-01-30 13:42:14 -03:00
..
.gitignore Build src/port files as a library with -fPIC, and use that in libpq. 2018-09-27 11:23:43 -04:00
chklocale.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
dirent.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
dirmod.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
dlopen.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
erand48.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
explicit_bzero.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
fls.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
fseeko.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
getaddrinfo.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
getopt_long.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
getopt.c Use our own getopt() on OpenBSD. 2019-01-18 15:06:26 -05:00
getpeereid.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
getrusage.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
gettimeofday.c Clean up newlines following left parentheses 2020-01-30 13:42:14 -03:00
inet_aton.c Correct include file name in inet_aton fallback. 2017-10-01 17:41:00 -07:00
inet_net_ntop.c Avoid conflicts with library versions of inet_net_ntop() and friends. 2019-08-18 19:27:23 -04:00
isinf.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
kill.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
Makefile Split all OBJS style lines in makefiles into one-line-per-entry style. 2019-11-05 14:41:07 -08:00
mkdtemp.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
noblock.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
open.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
path.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pg_bitutils.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pg_crc32c_armv8_choose.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pg_crc32c_armv8.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pg_crc32c_sb8.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pg_crc32c_sse42_choose.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pg_crc32c_sse42.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pg_strong_random.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pgcheckdir.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pgstrcasecmp.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pgstrsignal.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pqsignal.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pread.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
pwrite.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
qsort_arg.c Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
qsort.c Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
quotes.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
random.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
README Always use our own versions of *printf(). 2018-09-26 13:13:57 -04:00
rint.c Rethink how to get float.h in old Windows API for isnan/isinf 2018-07-11 09:11:48 -04:00
snprintf.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
sprompt.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
srandom.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
strerror.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
strnlen.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
strtof.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
system.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
tar.c Make the order of the header file includes consistent in non-backend modules. 2019-10-25 07:41:52 +05:30
thread.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
unsetenv.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
win32error.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
win32security.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
win32setlocale.c Update copyrights for 2020 2020-01-01 12:21:45 -05:00
win32ver.rc Remove libpq.rc, use win32ver.rc for libpq 2020-01-15 15:06:12 +01:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter strlcat.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export list to
control the symbols exported by libpq.