rdelaage
/
postgresql
mirror of https://git.postgresql.org/git/postgresql.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
postgresql/src
History
Tom Lane ca129e58c0 Fix regression tests to use only global names beginning with "regress_". 
In commit 18555b132 we tentatively established a rule that regression
tests should use names containing "regression" for databases, and names
starting with "regress_" for all other globally-visible object names, so
as to circumscribe the side-effects that "make installcheck" could have on
an existing installation.  However, no enforcement mechanism was created,
so it's unsurprising that some new violations have crept in since then.

In fact, a whole new *category* of violations has crept in, to wit we now
also have globally-visible subscription and replication origin names, and
"make installcheck" could very easily clobber user-created objects of
those types.  So it's past time to do something about this.

This commit sanitizes the tests enough that they will pass (i.e. not
generate any visible warnings) with the enforcement mechanism I'll add
in the next commit.  There are some TAP tests that still trigger the
warnings, but the warnings do not cause test failure.  Since these tests
do not actually run against a pre-existing installation, there's no need
to worry whether they could conflict with user-created objects.

The problem with rolenames.sql testing special role names like "user"
is still there, and is dealt with only very cosmetically in this patch
(by hiding the warnings :-().  What we actually need to do to be safe is
to take that test script out of "make installcheck" altogether, but that
seems like material for a separate patch.

Discussion: https://postgr.es/m/16638.1468620817@sss.pgh.pa.us
 		2019-06-29 11:09:03 -04:00
..
backend Disallow user-created replication origins named "pg_xxx". 2019-06-29 10:30:08 -04:00
bin Fix regression tests to use only global names beginning with "regress_". 2019-06-29 11:09:03 -04:00
common Make script output more pgindent compatible 2019-06-24 22:50:56 +02:00
fe_utils Update stale comments, and fix comment typos. 2019-06-08 10:12:26 -07:00
include Remove remaining traces of Rand_OpenSSL() from the tree 2019-06-27 08:25:26 +09:00
interfaces Translation updates 2019-06-17 15:30:20 +02:00
makefiles Define WIN32_STACK_RLIMIT throughout win32 and cygwin builds. 2019-04-09 08:25:39 -07:00
pl Translation updates 2019-06-17 15:30:20 +02:00
port Fix more typos and inconsistencies in the tree 2019-06-17 16:13:16 +09:00
template Yet further rethinking of build changes for macOS Mojave. 2018-11-02 18:54:00 -04:00
test Fix regression tests to use only global names beginning with "regress_". 2019-06-29 11:09:03 -04:00
timezone Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
tools Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts 2019-06-26 10:44:46 +09:00
tutorial Phase 2 pgindent run for v12. 2019-05-22 13:04:48 -04:00
.gitignore
…
DEVELOPERS
…
Makefile Fix partial-build problems introduced by having more generated headers. 2018-04-09 16:42:10 -04:00
Makefile.global.in Consistently test for in-use shared memory. 2019-04-12 22:36:38 -07:00
Makefile.shlib Ensure static libraries have correct mod time even if ranlib messes it up. 2018-11-29 15:53:44 -05:00
nls-global.mk Move logging.h and logging.c from src/fe_utils/ to src/common/. 2019-05-14 14:20:10 -04:00