postgresql/contrib/postgres_fdw
Tom Lane ccc286da1d Prevent accidental linking of system-supplied copies of libpq.so etc.
Back-patch commit dddfc4cb2, which broke LDFLAGS and related Makefile
variables into two parts, one for within-build-tree library references and
one for external libraries, to ensure that the order of -L flags has all
of the former before all of the latter.  This turns out to fix a problem
recently noted on buildfarm member peripatus, that we attempted to
incorporate code from libpgport.a into a shared library.  That will fail on
platforms that are sticky about putting non-PIC code into shared libraries.
(It's quite surprising we hadn't seen such failures before, since the code
in question has been like that for a long time.)

I think that peripatus' problem could have been fixed with just a subset
of this patch; but since the previous issue of accidentally linking to the
wrong copy of a Postgres shlib seems likely to bite people in the field,
let's just back-patch the whole change.  Now that commit dddfc4cb2 has
survived some beta testing, I'm less afraid to back-patch it than I was
at the time.

This also fixes undesired inclusion of "-DFRONTEND" in pg_config's CPPFLAGS
output (in 9.6 and up) and undesired inclusion of "-L../../src/common" in
its LDFLAGS output (in all supported branches).

Back-patch to v10 and older branches; this is already in v11.

Discussion: https://postgr.es/m/20180704234304.bq2dxispefl65odz@ler-imac.local
2018-07-09 17:23:31 -04:00
..
expected Fix test case for 'outer pathkeys do not match mergeclauses' fix. 2018-01-30 14:55:14 -05:00
sql Fix test case for 'outer pathkeys do not match mergeclauses' fix. 2018-01-30 14:55:14 -05:00
.gitignore Add postgres_fdw contrib module. 2013-02-21 05:27:16 -05:00
connection.c Re-establish postgres_fdw connections after server or user mapping changes. 2017-07-21 12:51:38 -04:00
deparse.c Fix assorted fallout from IS [NOT] NULL patch. 2016-07-28 16:09:15 -04:00
Makefile Prevent accidental linking of system-supplied copies of libpq.so etc. 2018-07-09 17:23:31 -04:00
option.c pgindent run for 9.6 2016-06-09 18:02:36 -04:00
postgres_fdw--1.0.sql Add postgres_fdw contrib module. 2013-02-21 05:27:16 -05:00
postgres_fdw.c Fix broken extract_actual_join_clauses call in 9.6 postgres_fdw. 2018-04-19 18:29:39 -04:00
postgres_fdw.control Add postgres_fdw contrib module. 2013-02-21 05:27:16 -05:00
postgres_fdw.h pgindent run for 9.6 2016-06-09 18:02:36 -04:00
shippable.c Update copyright for 2016 2016-01-02 13:33:40 -05:00