mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-30 19:47:19 +02:00
Until now, only selected bulk operations (e.g. COPY) did this. If a given relfilenode received both a WAL-skipping COPY and a WAL-logged operation (e.g. INSERT), recovery could lose tuples from the COPY. See src/backend/access/transam/README section "Skipping WAL for New RelFileNode" for the new coding rules. Maintainers of table access methods should examine that section. To maintain data durability, just before commit, we choose between an fsync of the relfilenode and copying its contents to WAL. A new GUC, wal_skip_threshold, guides that choice. If this change slows a workload that creates small, permanent relfilenodes under wal_level=minimal, try adjusting wal_skip_threshold. Users setting a timeout on COMMIT may need to adjust that timeout, and log_min_duration_statement analysis will reflect time consumption moving to COMMIT from commands like COPY. Internally, this requires a reliable determination of whether RollbackAndReleaseCurrentSubTransaction() would unlink a relation's current relfilenode. Introduce rd_firstRelfilenodeSubid. Amend the specification of rd_createSubid such that the field is zero when a new rel has an old rd_node. Make relcache.c retain entries for certain dropped relations until end of transaction. Back-patch to 9.5 (all supported versions). This introduces a new WAL record type, XLOG_GIST_ASSIGN_LSN, without bumping XLOG_PAGE_MAGIC. As always, update standby systems before master systems. This changes sizeof(RelationData) and sizeof(IndexStmt), breaking binary compatibility for affected extensions. (The most recent commit to affect the same class of extensions was 089e4d405d0f3b94c74a2c6a54357a84a681754b.) Kyotaro Horiguchi, reviewed (in earlier, similar versions) by Robert Haas. Heikki Linnakangas and Michael Paquier implemented earlier designs that materially clarified the problem. Reviewed, in earlier designs, by Andrew Dunstan, Andres Freund, Alvaro Herrera, Tom Lane, Fujii Masao, and Simon Riggs. Reported by Martijn van Oosterhout. Discussion: https://postgr.es/m/20150702220524.GA9392@svana.org
178 lines
6.2 KiB
Plaintext
178 lines
6.2 KiB
Plaintext
CREATE EXTENSION pg_visibility;
|
|
--
|
|
-- recently-dropped table
|
|
--
|
|
\set VERBOSITY sqlstate
|
|
BEGIN;
|
|
CREATE TABLE droppedtest (c int);
|
|
SELECT 'droppedtest'::regclass::oid AS oid \gset
|
|
SAVEPOINT q; DROP TABLE droppedtest; RELEASE q;
|
|
SAVEPOINT q; SELECT * FROM pg_visibility_map(:oid); ROLLBACK TO q;
|
|
ERROR: XX000
|
|
-- ERROR: could not open relation with OID 16xxx
|
|
SAVEPOINT q; SELECT 1; ROLLBACK TO q;
|
|
?column?
|
|
----------
|
|
1
|
|
(1 row)
|
|
|
|
SAVEPOINT q; SELECT 1; ROLLBACK TO q;
|
|
?column?
|
|
----------
|
|
1
|
|
(1 row)
|
|
|
|
SELECT pg_relation_size(:oid), pg_relation_filepath(:oid),
|
|
has_table_privilege(:oid, 'SELECT');
|
|
pg_relation_size | pg_relation_filepath | has_table_privilege
|
|
------------------+----------------------+---------------------
|
|
| |
|
|
(1 row)
|
|
|
|
SELECT * FROM pg_visibility_map(:oid);
|
|
ERROR: XX000
|
|
-- ERROR: could not open relation with OID 16xxx
|
|
ROLLBACK;
|
|
\set VERBOSITY default
|
|
--
|
|
-- check that using the module's functions with unsupported relations will fail
|
|
--
|
|
-- partitioned tables (the parent ones) don't have visibility maps
|
|
create table test_partitioned (a int) partition by list (a);
|
|
-- these should all fail
|
|
select pg_visibility('test_partitioned', 0);
|
|
ERROR: "test_partitioned" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map('test_partitioned');
|
|
ERROR: "test_partitioned" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map_summary('test_partitioned');
|
|
ERROR: "test_partitioned" is not a table, materialized view, or TOAST table
|
|
select pg_check_frozen('test_partitioned');
|
|
ERROR: "test_partitioned" is not a table, materialized view, or TOAST table
|
|
select pg_truncate_visibility_map('test_partitioned');
|
|
ERROR: "test_partitioned" is not a table, materialized view, or TOAST table
|
|
create table test_partition partition of test_partitioned for values in (1);
|
|
create index test_index on test_partition (a);
|
|
-- indexes do not, so these all fail
|
|
select pg_visibility('test_index', 0);
|
|
ERROR: "test_index" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map('test_index');
|
|
ERROR: "test_index" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map_summary('test_index');
|
|
ERROR: "test_index" is not a table, materialized view, or TOAST table
|
|
select pg_check_frozen('test_index');
|
|
ERROR: "test_index" is not a table, materialized view, or TOAST table
|
|
select pg_truncate_visibility_map('test_index');
|
|
ERROR: "test_index" is not a table, materialized view, or TOAST table
|
|
create view test_view as select 1;
|
|
-- views do not have VMs, so these all fail
|
|
select pg_visibility('test_view', 0);
|
|
ERROR: "test_view" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map('test_view');
|
|
ERROR: "test_view" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map_summary('test_view');
|
|
ERROR: "test_view" is not a table, materialized view, or TOAST table
|
|
select pg_check_frozen('test_view');
|
|
ERROR: "test_view" is not a table, materialized view, or TOAST table
|
|
select pg_truncate_visibility_map('test_view');
|
|
ERROR: "test_view" is not a table, materialized view, or TOAST table
|
|
create sequence test_sequence;
|
|
-- sequences do not have VMs, so these all fail
|
|
select pg_visibility('test_sequence', 0);
|
|
ERROR: "test_sequence" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map('test_sequence');
|
|
ERROR: "test_sequence" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map_summary('test_sequence');
|
|
ERROR: "test_sequence" is not a table, materialized view, or TOAST table
|
|
select pg_check_frozen('test_sequence');
|
|
ERROR: "test_sequence" is not a table, materialized view, or TOAST table
|
|
select pg_truncate_visibility_map('test_sequence');
|
|
ERROR: "test_sequence" is not a table, materialized view, or TOAST table
|
|
create foreign data wrapper dummy;
|
|
create server dummy_server foreign data wrapper dummy;
|
|
create foreign table test_foreign_table () server dummy_server;
|
|
-- foreign tables do not have VMs, so these all fail
|
|
select pg_visibility('test_foreign_table', 0);
|
|
ERROR: "test_foreign_table" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map('test_foreign_table');
|
|
ERROR: "test_foreign_table" is not a table, materialized view, or TOAST table
|
|
select pg_visibility_map_summary('test_foreign_table');
|
|
ERROR: "test_foreign_table" is not a table, materialized view, or TOAST table
|
|
select pg_check_frozen('test_foreign_table');
|
|
ERROR: "test_foreign_table" is not a table, materialized view, or TOAST table
|
|
select pg_truncate_visibility_map('test_foreign_table');
|
|
ERROR: "test_foreign_table" is not a table, materialized view, or TOAST table
|
|
-- check some of the allowed relkinds
|
|
create table regular_table (a int);
|
|
insert into regular_table values (1), (2);
|
|
vacuum regular_table;
|
|
select count(*) > 0 from pg_visibility('regular_table');
|
|
?column?
|
|
----------
|
|
t
|
|
(1 row)
|
|
|
|
truncate regular_table;
|
|
select count(*) > 0 from pg_visibility('regular_table');
|
|
?column?
|
|
----------
|
|
f
|
|
(1 row)
|
|
|
|
create materialized view matview_visibility_test as select * from regular_table;
|
|
vacuum matview_visibility_test;
|
|
select count(*) > 0 from pg_visibility('matview_visibility_test');
|
|
?column?
|
|
----------
|
|
f
|
|
(1 row)
|
|
|
|
insert into regular_table values (1), (2);
|
|
refresh materialized view matview_visibility_test;
|
|
select count(*) > 0 from pg_visibility('matview_visibility_test');
|
|
?column?
|
|
----------
|
|
t
|
|
(1 row)
|
|
|
|
-- regular tables which are part of a partition *do* have visibility maps
|
|
insert into test_partition values (1);
|
|
vacuum test_partition;
|
|
select count(*) > 0 from pg_visibility('test_partition', 0);
|
|
?column?
|
|
----------
|
|
t
|
|
(1 row)
|
|
|
|
select count(*) > 0 from pg_visibility_map('test_partition');
|
|
?column?
|
|
----------
|
|
t
|
|
(1 row)
|
|
|
|
select count(*) > 0 from pg_visibility_map_summary('test_partition');
|
|
?column?
|
|
----------
|
|
t
|
|
(1 row)
|
|
|
|
select * from pg_check_frozen('test_partition'); -- hopefully none
|
|
t_ctid
|
|
--------
|
|
(0 rows)
|
|
|
|
select pg_truncate_visibility_map('test_partition');
|
|
pg_truncate_visibility_map
|
|
----------------------------
|
|
|
|
(1 row)
|
|
|
|
-- cleanup
|
|
drop table test_partitioned;
|
|
drop view test_view;
|
|
drop sequence test_sequence;
|
|
drop foreign table test_foreign_table;
|
|
drop server dummy_server;
|
|
drop foreign data wrapper dummy;
|
|
drop materialized view matview_visibility_test;
|
|
drop table regular_table;
|