mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-18 00:11:09 +02:00
af8a8eb542
This commit fixes a set of issues related to the use of the SQL functions in this module when the caller is able to pass down raw page data as input argument: - The page size check was fuzzy in a couple of places, sometimes looking after only a sub-range, but what we are looking for is an exact match on BLCKSZ. After considering a few options here, I have settled down to do a generalization of get_page_from_raw(). Most of the SQL functions already used that, and this is not strictly required if not accessing an 8-byte-wide value from a raw page, but this feels safer in the long run for alignment-picky environment, particularly if a code path begins to access such values. This also reduces the number of strings that need to be translated. - The BRIN function brin_page_items() uses a Relation but it did not check the access method of the opened index, potentially leading to crashes. All the other functions in need of a Relation already did that. - Some code paths could fail on elog(), but we should to use ereport() for failures that can be triggered by the user. Tests are added to stress all the cases that are fixed as of this commit, with some junk raw pages (\set VERBOSITY ensures that this works across all page sizes) and unexpected index types when functions open relations. Author: Michael Paquier, Justin Prysby Discussion: https://postgr.es/m/20220218030020.GA1137@telsasoft.com Backpatch-through: 10
29 lines
1003 B
SQL
29 lines
1003 B
SQL
CREATE TABLE test1 (x int, y int[]);
|
|
INSERT INTO test1 VALUES (1, ARRAY[11, 111]);
|
|
CREATE INDEX test1_y_idx ON test1 USING gin (y) WITH (fastupdate = off);
|
|
|
|
\x
|
|
|
|
SELECT * FROM gin_metapage_info(get_raw_page('test1_y_idx', 0));
|
|
SELECT * FROM gin_metapage_info(get_raw_page('test1_y_idx', 1));
|
|
|
|
SELECT * FROM gin_page_opaque_info(get_raw_page('test1_y_idx', 1));
|
|
|
|
SELECT * FROM gin_leafpage_items(get_raw_page('test1_y_idx', 1));
|
|
|
|
INSERT INTO test1 SELECT x, ARRAY[1,10] FROM generate_series(2,10000) x;
|
|
|
|
SELECT COUNT(*) > 0
|
|
FROM gin_leafpage_items(get_raw_page('test1_y_idx',
|
|
(pg_relation_size('test1_y_idx') /
|
|
current_setting('block_size')::bigint)::int - 1));
|
|
|
|
-- Failure with incorrect page size
|
|
-- Suppress the DETAIL message, to allow the tests to work across various
|
|
-- page sizes.
|
|
\set VERBOSITY terse
|
|
SELECT gin_leafpage_items('aaa'::bytea);
|
|
SELECT gin_metapage_info('bbb'::bytea);
|
|
SELECT gin_page_opaque_info('ccc'::bytea);
|
|
\set VERBOSITY default
|