postgresql

mirror of https://git.postgresql.org/git/postgresql.git synced 2024-10-01 13:41:17 +02:00

History

Tom Lane c35b714caf Fix misbehavior with expression indexes on ON COMMIT DELETE ROWS tables. We implement ON COMMIT DELETE ROWS by truncating tables marked that way, which requires also truncating/rebuilding their indexes. But RelationTruncateIndexes asks the relcache for up-to-date copies of any index expressions, which may cause execution of eval_const_expressions on them, which can result in actual execution of subexpressions. This is a bad thing to have happening during ON COMMIT. Manuel Rigger reported that use of a SQL function resulted in crashes due to expectations that ActiveSnapshot would be set, which it isn't. The most obvious fix perhaps would be to push a snapshot during PreCommit_on_commit_actions, but I think that would just open the door to more problems: CommitTransaction explicitly expects that no user-defined code can be running at this point. Fortunately, since we know that no tuples exist to be indexed, there seems no need to use the real index expressions or predicates during RelationTruncateIndexes. We can set up dummy index expressions instead (we do need something that will expose the right data type, as there are places that build index tupdescs based on this), and just ignore predicates and exclusion constraints. In a green field it'd likely be better to reimplement ON COMMIT DELETE ROWS using the same "init fork" infrastructure used for unlogged relations. That seems impractical without catalog changes though, and even without that it'd be too big a change to back-patch. So for now do it like this. Per private report from Manuel Rigger. This has been broken forever, so back-patch to all supported branches.		2019-12-01 13:09:26 -05:00
..
authentication	Fix use of term "verifier"	2019-10-12 21:41:59 +02:00
examples	Remove useless "return;" lines	2019-11-28 16:48:37 -03:00
isolation	Avoid assertion failure with LISTEN in a serializable transaction.	2019-11-24 15:57:49 -05:00
kerberos
ldap	Be more careful about port selection in src/test/ldap/.	2019-09-09 14:21:40 -04:00
locale
mb
modules	Add a regression test for allow_system_table_mods	2019-11-29 10:22:13 +01:00
perl	Revert commits `290acac92b` and `8a7e9e9dad`.	2019-11-30 08:01:20 +05:30
recovery	Revert commits `290acac92b` and `8a7e9e9dad`.	2019-11-30 08:01:20 +05:30
regress	Fix misbehavior with expression indexes on ON COMMIT DELETE ROWS tables.	2019-12-01 13:09:26 -05:00
ssl	libq support for sslpassword connection param, DER format keys	2019-11-30 15:27:13 -05:00
subscription	Add test coverage for "unchanged toast column" replication code path.	2019-11-22 12:52:26 -05:00
thread
Makefile
README

README

PostgreSQL tests
================

This directory contains a variety of test infrastructure as well as some of the
tests in PostgreSQL. Not all tests are here -- in particular, there are more in
individual contrib/ modules and in src/bin.

Not all these tests get run by "make check". Check src/test/Makefile to see
which tests get run automatically.

authentication/
  Tests for authentication

examples/
  Demonstration programs for libpq that double as regression tests via
  "make check"

isolation/
  Tests for concurrent behavior at the SQL level

locale/
  Sanity checks for locale data, encodings, etc

mb/
  Tests for multibyte encoding (UTF-8) support

modules/
  Extensions used only or mainly for test purposes, generally not suitable
  for installing in production databases

perl/
  Infrastructure for Perl-based TAP tests

recovery/
  Test suite for recovery and replication

regress/
  PostgreSQL's main regression test suite, pg_regress

ssl/
  Tests to exercise and verify SSL certificate handling

subscription/
  Tests for logical replication

thread/
  A thread-safety-testing utility used by configure