mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-01 01:33:24 +02:00
d3a9b83c30
This commit fixes a set of issues related to the use of the SQL functions in this module when the caller is able to pass down raw page data as input argument: - The page size check was fuzzy in a couple of places, sometimes looking after only a sub-range, but what we are looking for is an exact match on BLCKSZ. After considering a few options here, I have settled down to do a generalization of get_page_from_raw(). Most of the SQL functions already used that, and this is not strictly required if not accessing an 8-byte-wide value from a raw page, but this feels safer in the long run for alignment-picky environment, particularly if a code path begins to access such values. This also reduces the number of strings that need to be translated. - The BRIN function brin_page_items() uses a Relation but it did not check the access method of the opened index, potentially leading to crashes. All the other functions in need of a Relation already did that. - Some code paths could fail on elog(), but we should to use ereport() for failures that can be triggered by the user. Tests are added to stress all the cases that are fixed as of this commit, with some junk raw pages (\set VERBOSITY ensures that this works across all page sizes) and unexpected index types when functions open relations. Author: Michael Paquier, Justin Prysby Discussion: https://postgr.es/m/20220218030020.GA1137@telsasoft.com Backpatch-through: 10
180 lines
10 KiB
Plaintext
180 lines
10 KiB
Plaintext
CREATE TABLE test_hash (a int, b text);
|
|
INSERT INTO test_hash VALUES (1, 'one');
|
|
CREATE INDEX test_hash_a_idx ON test_hash USING hash (a);
|
|
\x
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 0));
|
|
-[ RECORD 1 ]--+---------
|
|
hash_page_type | metapage
|
|
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 1));
|
|
-[ RECORD 1 ]--+-------
|
|
hash_page_type | bucket
|
|
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 2));
|
|
-[ RECORD 1 ]--+-------
|
|
hash_page_type | bucket
|
|
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 3));
|
|
-[ RECORD 1 ]--+-------
|
|
hash_page_type | bucket
|
|
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 4));
|
|
-[ RECORD 1 ]--+-------
|
|
hash_page_type | bucket
|
|
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 5));
|
|
-[ RECORD 1 ]--+-------
|
|
hash_page_type | bitmap
|
|
|
|
SELECT hash_page_type(get_raw_page('test_hash_a_idx', 6));
|
|
ERROR: block number 6 is out of range for relation "test_hash_a_idx"
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 0);
|
|
ERROR: invalid overflow block number 0
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 1);
|
|
ERROR: invalid overflow block number 1
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 2);
|
|
ERROR: invalid overflow block number 2
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 3);
|
|
ERROR: invalid overflow block number 3
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 4);
|
|
ERROR: invalid overflow block number 4
|
|
SELECT * FROM hash_bitmap_info('test_hash_a_idx', 5);
|
|
ERROR: invalid overflow block number 5
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 0));
|
|
-[ RECORD 1 ]--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|
|
magic | 105121344
|
|
version | 4
|
|
ntuples | 1
|
|
bsize | 8152
|
|
bmsize | 4096
|
|
bmshift | 15
|
|
maxbucket | 3
|
|
highmask | 7
|
|
lowmask | 3
|
|
ovflpoint | 2
|
|
firstfree | 0
|
|
nmaps | 1
|
|
procid | 450
|
|
spares | {0,0,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0}
|
|
mapp | {5,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0}
|
|
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 1));
|
|
ERROR: page is not a hash meta page
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 2));
|
|
ERROR: page is not a hash meta page
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 3));
|
|
ERROR: page is not a hash meta page
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 4));
|
|
ERROR: page is not a hash meta page
|
|
SELECT magic, version, ntuples, bsize, bmsize, bmshift, maxbucket, highmask,
|
|
lowmask, ovflpoint, firstfree, nmaps, procid, spares, mapp FROM
|
|
hash_metapage_info(get_raw_page('test_hash_a_idx', 5));
|
|
ERROR: page is not a hash meta page
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 0));
|
|
ERROR: page is not a hash bucket or overflow page
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 1));
|
|
-[ RECORD 1 ]---+-----------
|
|
live_items | 0
|
|
dead_items | 0
|
|
page_size | 8192
|
|
hasho_prevblkno | 3
|
|
hasho_nextblkno | 4294967295
|
|
hasho_bucket | 0
|
|
hasho_flag | 2
|
|
hasho_page_id | 65408
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 2));
|
|
-[ RECORD 1 ]---+-----------
|
|
live_items | 0
|
|
dead_items | 0
|
|
page_size | 8192
|
|
hasho_prevblkno | 3
|
|
hasho_nextblkno | 4294967295
|
|
hasho_bucket | 1
|
|
hasho_flag | 2
|
|
hasho_page_id | 65408
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 3));
|
|
-[ RECORD 1 ]---+-----------
|
|
live_items | 1
|
|
dead_items | 0
|
|
page_size | 8192
|
|
hasho_prevblkno | 3
|
|
hasho_nextblkno | 4294967295
|
|
hasho_bucket | 2
|
|
hasho_flag | 2
|
|
hasho_page_id | 65408
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 4));
|
|
-[ RECORD 1 ]---+-----------
|
|
live_items | 0
|
|
dead_items | 0
|
|
page_size | 8192
|
|
hasho_prevblkno | 3
|
|
hasho_nextblkno | 4294967295
|
|
hasho_bucket | 3
|
|
hasho_flag | 2
|
|
hasho_page_id | 65408
|
|
|
|
SELECT live_items, dead_items, page_size, hasho_prevblkno, hasho_nextblkno,
|
|
hasho_bucket, hasho_flag, hasho_page_id FROM
|
|
hash_page_stats(get_raw_page('test_hash_a_idx', 5));
|
|
ERROR: page is not a hash bucket or overflow page
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 0));
|
|
ERROR: page is not a hash bucket or overflow page
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 1));
|
|
(0 rows)
|
|
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 2));
|
|
(0 rows)
|
|
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 3));
|
|
-[ RECORD 1 ]----------
|
|
itemoffset | 1
|
|
ctid | (0,1)
|
|
data | 2389907270
|
|
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 4));
|
|
(0 rows)
|
|
|
|
SELECT * FROM hash_page_items(get_raw_page('test_hash_a_idx', 5));
|
|
ERROR: page is not a hash bucket or overflow page
|
|
-- Failure with non-hash index
|
|
CREATE INDEX test_hash_a_btree ON test_hash USING btree (a);
|
|
SELECT hash_bitmap_info('test_hash_a_btree', 0);
|
|
ERROR: "test_hash_a_btree" is not a hash index
|
|
-- Failure with incorrect page size
|
|
-- Suppress the DETAIL message, to allow the tests to work across various
|
|
-- page sizes.
|
|
\set VERBOSITY terse
|
|
SELECT hash_metapage_info('aaa'::bytea);
|
|
ERROR: invalid page size
|
|
SELECT hash_page_items('bbb'::bytea);
|
|
ERROR: invalid page size
|
|
SELECT hash_page_stats('ccc'::bytea);
|
|
ERROR: invalid page size
|
|
SELECT hash_page_type('ddd'::bytea);
|
|
ERROR: invalid page size
|
|
\set VERBOSITY default
|
|
DROP TABLE test_hash;
|