postgresql/src/port
Michael Paquier 8722c4dacc Fix error handling of readdir() port implementation on first file lookup
The implementation of readdir() in src/port/ which gets used by MSVC has
been added in 399a36a, and since the beginning it considers all errors
on the first file lookup as ENOENT, setting errno accordingly and
letting the routine caller think that the directory is empty.  While
this is normally enough for the case of the backend, this can confuse
callers of this routine on Windows as all errors would map to the same
behavior.  So, for example, even permission errors would be thought as
having an empty directory, while there could be contents in it.

This commit changes the error handling so as readdir() gets a behavior
similar to native implementations: force errno=0 when seeing
ERROR_FILE_NOT_FOUND as error and consider other errors as plain
failures.

While looking at the patch, I noticed that MinGW does not enforce
errno=0 when looking at the first file, but it gets enforced on the next
file lookups.  A comment related to that was incorrect in the code.

Reported-by: Yuri Kurenkov
Diagnosed-by: Yuri Kurenkov, Grigory Smolkin
Author:	Konstantin Knizhnik
Reviewed-by: Andrew Dunstan, Michael Paquier
Discussion: https://postgr.es/m/2cad7829-8d66-e39c-b937-ac825db5203d@postgrespro.ru
Backpatch-through: 9.4
2019-03-04 09:50:02 +09:00
..
.gitignore Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
chklocale.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
crypt.c Phase 2 of pgindent updates. 2017-06-21 15:19:25 -04:00
dirent.c Fix error handling of readdir() port implementation on first file lookup 2019-03-04 09:50:02 +09:00
dirmod.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
erand48.c Fix latent problem with pg_jrand48(). 2018-12-28 14:08:30 -05:00
fls.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
fseeko.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
getaddrinfo.c Clean up assorted misuses of snprintf()'s result value. 2018-08-15 16:29:32 -04:00
getopt_long.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
getopt.c Use our own getopt() on OpenBSD. 2019-01-18 15:06:26 -05:00
getpeereid.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
getrusage.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
gettimeofday.c Phase 3 of pgindent updates. 2017-06-21 15:35:54 -04:00
inet_aton.c Correct include file name in inet_aton fallback. 2017-10-01 17:41:00 -07:00
inet_net_ntop.c Fix file paths in comments 2018-05-14 18:59:43 +02:00
isinf.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
kill.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
Makefile Fix partial-build problems introduced by having more generated headers. 2018-04-09 16:42:10 -04:00
mkdtemp.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
noblock.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
open.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
path.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_crc32c_armv8_choose.c Further improve code for probing the availability of ARM CRC instructions. 2018-05-03 11:32:57 -04:00
pg_crc32c_armv8.c Preliminary work for pgindent run. 2018-04-26 14:45:04 -04:00
pg_crc32c_sb8.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_crc32c_sse42_choose.c Use ARMv8 CRC instructions where available. 2018-04-04 12:22:45 +03:00
pg_crc32c_sse42.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pg_strong_random.c Guard against rare RAND_bytes() failures in pg_strong_random(). 2018-07-20 08:57:08 +01:00
pgcheckdir.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pgmkdirp.c Fix various typos and grammar errors in comments. 2015-04-26 18:42:31 +02:00
pgsleep.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pgstrcasecmp.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pqsignal.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
pthread-win32.h Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
qsort_arg.c Fix a low-probability crash in our qsort implementation. 2015-07-16 22:57:46 -04:00
qsort.c Fix a low-probability crash in our qsort implementation. 2015-07-16 22:57:46 -04:00
quotes.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
random.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
README Refer to OS X as "macOS", except for the port name which is still "darwin". 2016-09-25 15:40:57 -04:00
rint.c Upgrade src/port/rint.c to be POSIX-compliant. 2015-03-25 15:54:18 -04:00
snprintf.c Set snprintf.c's maximum number of NL arguments to be 31. 2018-10-02 12:41:28 -04:00
sprompt.c Fix simple_prompt() to disable echo on Windows when stdin != terminal. 2018-05-23 19:04:34 -04:00
srandom.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
strerror.c Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
strlcat.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
strlcpy.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
strnlen.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
system.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
tar.c Allow pg_basebackup to stream transaction log in tar mode 2016-10-23 15:23:11 +02:00
thread.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
unsetenv.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32.ico Revert binary change in copyright year adjustment. 2012-01-01 19:40:13 -05:00
win32env.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32error.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32security.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32setlocale.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
win32ver.rc Stamp 11.2. 2019-02-11 16:17:27 -05:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter snprintf.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, and macOS use an export list to
control the symbols exported by libpq.