postgresql/src/port
Tom Lane b426bd48ee Simplify coding around path_contains_parent_reference().
Given the existing stipulation that path_contains_parent_reference()
must only be invoked on canonicalized paths, we can simplify things
in the wake of commit c10f830c5.  It is now only possible to see
".." at the start of a relative path.  That means we can simplify
path_contains_parent_reference() itself quite a bit, and it makes
the two existing outside call sites dead code, since they'd already
checked that the path is absolute.

We could now fold path_contains_parent_reference() into its only
remaining caller path_is_relative_and_below_cwd().  But it seems
better to leave it as a separately callable function, in case any
extensions are using it.

Also document the pre-existing requirement for
path_is_relative_and_below_cwd's input to be likewise canonicalized.

Shenhao Wang and Tom Lane

Discussion: https://postgr.es/m/OSBPR01MB4214FA221FFE046F11F2AD74F2D49@OSBPR01MB4214.jpnprd01.prod.outlook.com
2022-01-31 13:53:38 -05:00
..
.gitignore
bsearch_arg.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
chklocale.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
dirent.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
dirmod.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
dlopen.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
explicit_bzero.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
fls.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
getaddrinfo.c Clean up messy API for src/port/thread.c. 2022-01-11 13:46:20 -05:00
getopt_long.c
getopt.c
getpeereid.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
getrusage.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
gettimeofday.c
inet_aton.c
inet_net_ntop.c
kill.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
link.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
Makefile Clean up messy API for src/port/thread.c. 2022-01-11 13:46:20 -05:00
mkdtemp.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
noblock.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
open.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
path.c Simplify coding around path_contains_parent_reference(). 2022-01-31 13:53:38 -05:00
pg_bitutils.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_armv8_choose.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_armv8.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_sb8.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_sse42_choose.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_crc32c_sse42.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pg_strong_random.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pgcheckdir.c Fix various typos, grammar and code style in comments and docs 2022-01-25 09:40:04 +09:00
pgmkdirp.c
pgsleep.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pgstrcasecmp.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pgstrsignal.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pqsignal.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pread.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
preadv.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pthread_barrier_wait.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pthread-win32.h
pwrite.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
pwritev.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
qsort_arg.c Use sort_template.h for qsort() and qsort_arg(). 2021-03-03 17:02:32 +13:00
qsort.c Use sort_template.h for qsort() and qsort_arg(). 2021-03-03 17:02:32 +13:00
quotes.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
README AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS. 2021-09-06 11:27:59 -07:00
setenv.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
snprintf.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
strerror.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
strlcat.c
strlcpy.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
strnlen.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
strtof.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
system.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
tar.c
thread.c Clean up messy API for src/port/thread.c. 2022-01-11 13:46:20 -05:00
unsetenv.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32.ico
win32env.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32error.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32ntdll.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32security.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32setlocale.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32stat.c Update copyright for 2022 2022-01-07 19:04:57 -05:00
win32ver.rc Update copyright for 2022 2022-01-07 19:04:57 -05:00

src/port/README

libpgport
=========

libpgport must have special behavior.  It supplies functions to both
libraries and applications.  However, there are two complexities:

1)  Libraries need to use object files that are compiled with exactly
the same flags as the library.  libpgport might not use the same flags,
so it is necessary to recompile the object files for individual
libraries.  This is done by removing -lpgport from the link line:

        # Need to recompile any libpgport object files
        LIBS := $(filter-out -lpgport, $(LIBS))

and adding infrastructure to recompile the object files:

        OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \
                connect.o misc.o path.o exec.o \
                $(filter strlcat.o, $(LIBOBJS))

The problem is that there is no testing of which object files need to be
added, but missing functions usually show up when linking user
applications.

2) For applications, we use -lpgport before -lpq, so the static files
from libpgport are linked first.  This avoids having applications
dependent on symbols that are _used_ by libpq, but not intended to be
exported by libpq.  libpq's libpgport usage changes over time, so such a
dependency is a problem.  Windows, Linux, AIX, and macOS use an export
list to control the symbols exported by libpq.