postgresql/src/bin/pg_upgrade
Noah Misch 582edc369c Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects.  Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser.  This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".

This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump().  If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear.  Users may fix such errors
by schema-qualifying affected names.  After upgrading, consider watching
server logs for these errors.

The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint.  That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.

Back-patch to 9.3 (all supported versions).

Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.

Security: CVE-2018-1058
2018-02-26 07:39:44 -08:00
..
po Translation updates 2017-08-07 13:55:34 -04:00
.gitignore Fix bit-rot in pg_upgrade's test.sh, and improve documentation. 2017-06-08 13:48:39 -04:00
IMPLEMENTATION Fix wording in pg_upgrade docs 2017-05-05 12:42:21 +02:00
Makefile Revert "Add basic TAP test setup for pg_upgrade" 2017-09-22 16:46:56 -04:00
TESTING Fix bit-rot in pg_upgrade's test.sh, and improve documentation. 2017-06-08 13:48:39 -04:00
check.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
controldata.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
dump.c Ensure that all temp files made during pg_upgrade are non-world-readable. 2018-02-05 10:58:27 -05:00
exec.c pg_upgrade: prevent check on live cluster from generating error 2018-01-08 22:43:51 -05:00
file.c Ensure that all temp files made during pg_upgrade are non-world-readable. 2018-02-05 10:58:27 -05:00
function.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
info.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
nls.mk Translation updates 2017-08-07 13:55:34 -04:00
option.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
parallel.c pg_upgrade: prevent check on live cluster from generating error 2018-01-08 22:43:51 -05:00
pg_upgrade.c Un-break parallel pg_upgrade. 2018-02-25 17:27:20 -05:00
pg_upgrade.h Ensure that all temp files made during pg_upgrade are non-world-readable. 2018-02-05 10:58:27 -05:00
relfilenode.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
server.c Empty search_path in Autovacuum and non-psql/pgbench clients. 2018-02-26 07:39:44 -08:00
tablespace.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
test.sh Update copyright for 2018 2018-01-02 23:30:12 -05:00
util.c Update copyright for 2018 2018-01-02 23:30:12 -05:00
version.c Update copyright for 2018 2018-01-02 23:30:12 -05:00