postgresql/src/bin
Tom Lane d9c366f9e8 Code review for pg_verify_checksums.c.
Use postgres_fe.h, since this is frontend code.  Pretend that we've heard
of project style guidelines for, eg, #include order.  Use BlockNumber not
int arithmetic for block numbers, to avoid misbehavior with relations
exceeding 2^31 blocks.  Avoid an unnecessary strict-aliasing warning
(per report from Michael Banck).  Const-ify assorted stuff.  Avoid
scribbling on the output of readdir() -- perhaps that's safe in practice,
but POSIX forbids it, and this code has so far earned exactly zero
credibility portability-wise.  Editorialize on an ambiguously-worded
message.

I did not touch the problem of the "buf" local variable being possibly
insufficiently aligned; that's not specific to this code, and seems like
it should be fixed as part of a different, larger patch.

Discussion: https://postgr.es/m/1535618100.1286.3.camel@credativ.de
2018-08-31 13:42:28 -04:00
..
initdb Cosmetic cleanups in initdb.c. 2018-08-10 14:14:27 -04:00
pg_archivecleanup Don't fall off the end of perl functions 2018-05-27 09:08:42 -04:00
pg_basebackup Reset properly errno before calling write() 2018-08-05 05:31:18 +09:00
pg_config Translation updates 2018-05-21 12:29:52 -04:00
pg_controldata Translation updates 2018-06-25 12:37:18 +02:00
pg_ctl Translation updates 2018-05-21 12:29:52 -04:00
pg_dump pg_dump: Reorganize getTableAttrs() 2018-08-30 18:09:44 +02:00
pg_resetwal Flip argument order in XLogSegNoOffsetToRecPtr 2018-07-09 14:33:38 -04:00
pg_rewind Rework error messages around file handling 2018-07-18 08:01:23 +09:00
pg_test_fsync Translation updates 2018-05-21 12:29:52 -04:00
pg_test_timing Translation updates 2018-05-21 12:29:52 -04:00
pg_upgrade pg_upgrade: issue helpful error message for use on standbys 2018-08-17 10:25:48 -04:00
pg_verify_checksums Code review for pg_verify_checksums.c. 2018-08-31 13:42:28 -04:00
pg_waldump Rework error messages around file handling 2018-07-18 08:01:23 +09:00
pgbench Fix handling of pgbench's hash when no argument is provided 2018-07-27 13:40:24 +09:00
pgevent Update copyright for 2018 2018-01-02 23:30:12 -05:00
psql doc: Update uses of the word "procedure" 2018-08-22 14:44:49 +02:00
scripts Add semicolons to end of internally run queries 2018-08-30 19:23:22 +02:00
Makefile Allow on-line enabling and disabling of data checksums 2018-04-05 22:04:48 +02:00