mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-18 17:01:10 +02:00
af8a8eb542
This commit fixes a set of issues related to the use of the SQL functions in this module when the caller is able to pass down raw page data as input argument: - The page size check was fuzzy in a couple of places, sometimes looking after only a sub-range, but what we are looking for is an exact match on BLCKSZ. After considering a few options here, I have settled down to do a generalization of get_page_from_raw(). Most of the SQL functions already used that, and this is not strictly required if not accessing an 8-byte-wide value from a raw page, but this feels safer in the long run for alignment-picky environment, particularly if a code path begins to access such values. This also reduces the number of strings that need to be translated. - The BRIN function brin_page_items() uses a Relation but it did not check the access method of the opened index, potentially leading to crashes. All the other functions in need of a Relation already did that. - Some code paths could fail on elog(), but we should to use ereport() for failures that can be triggered by the user. Tests are added to stress all the cases that are fixed as of this commit, with some junk raw pages (\set VERBOSITY ensures that this works across all page sizes) and unexpected index types when functions open relations. Author: Michael Paquier, Justin Prysby Discussion: https://postgr.es/m/20220218030020.GA1137@telsasoft.com Backpatch-through: 10
127 lines
4.0 KiB
Plaintext
127 lines
4.0 KiB
Plaintext
CREATE EXTENSION pageinspect;
|
|
CREATE TABLE test1 (a int, b int);
|
|
INSERT INTO test1 VALUES (16777217, 131584);
|
|
VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM
|
|
-- The page contents can vary, so just test that it can be read
|
|
-- successfully, but don't keep the output.
|
|
SELECT octet_length(get_raw_page('test1', 'main', 0)) AS main_0;
|
|
main_0
|
|
--------
|
|
8192
|
|
(1 row)
|
|
|
|
SELECT octet_length(get_raw_page('test1', 'main', 1)) AS main_1;
|
|
ERROR: block number 1 is out of range for relation "test1"
|
|
SELECT octet_length(get_raw_page('test1', 'fsm', 0)) AS fsm_0;
|
|
fsm_0
|
|
-------
|
|
8192
|
|
(1 row)
|
|
|
|
SELECT octet_length(get_raw_page('test1', 'fsm', 1)) AS fsm_1;
|
|
fsm_1
|
|
-------
|
|
8192
|
|
(1 row)
|
|
|
|
SELECT octet_length(get_raw_page('test1', 'vm', 0)) AS vm_0;
|
|
vm_0
|
|
------
|
|
8192
|
|
(1 row)
|
|
|
|
SELECT octet_length(get_raw_page('test1', 'vm', 1)) AS vm_1;
|
|
ERROR: block number 1 is out of range for relation "test1"
|
|
SELECT octet_length(get_raw_page('xxx', 'main', 0));
|
|
ERROR: relation "xxx" does not exist
|
|
SELECT octet_length(get_raw_page('test1', 'xxx', 0));
|
|
ERROR: invalid fork name
|
|
HINT: Valid fork names are "main", "fsm", "vm", and "init".
|
|
SELECT get_raw_page('test1', 0) = get_raw_page('test1', 'main', 0);
|
|
?column?
|
|
----------
|
|
t
|
|
(1 row)
|
|
|
|
SELECT pagesize, version FROM page_header(get_raw_page('test1', 0));
|
|
pagesize | version
|
|
----------+---------
|
|
8192 | 4
|
|
(1 row)
|
|
|
|
SELECT page_checksum(get_raw_page('test1', 0), 0) IS NOT NULL AS silly_checksum_test;
|
|
silly_checksum_test
|
|
---------------------
|
|
t
|
|
(1 row)
|
|
|
|
SELECT tuple_data_split('test1'::regclass, t_data, t_infomask, t_infomask2, t_bits)
|
|
FROM heap_page_items(get_raw_page('test1', 0));
|
|
tuple_data_split
|
|
-------------------------------
|
|
{"\\x01000001","\\x00020200"}
|
|
(1 row)
|
|
|
|
SELECT * FROM fsm_page_contents(get_raw_page('test1', 'fsm', 0));
|
|
fsm_page_contents
|
|
-------------------
|
|
0: 254 +
|
|
1: 254 +
|
|
3: 254 +
|
|
7: 254 +
|
|
15: 254 +
|
|
31: 254 +
|
|
63: 254 +
|
|
127: 254 +
|
|
255: 254 +
|
|
511: 254 +
|
|
1023: 254 +
|
|
2047: 254 +
|
|
4095: 254 +
|
|
fp_next_slot: 0 +
|
|
|
|
(1 row)
|
|
|
|
DROP TABLE test1;
|
|
-- check that using any of these functions with a partitioned table or index
|
|
-- would fail
|
|
create table test_partitioned (a int) partition by range (a);
|
|
create index test_partitioned_index on test_partitioned (a);
|
|
select get_raw_page('test_partitioned', 0); -- error about partitioned table
|
|
ERROR: cannot get raw page from partitioned table "test_partitioned"
|
|
select get_raw_page('test_partitioned_index', 0); -- error about partitioned index
|
|
ERROR: cannot get raw page from partitioned index "test_partitioned_index"
|
|
-- a regular table which is a member of a partition set should work though
|
|
create table test_part1 partition of test_partitioned for values from ( 1 ) to (100);
|
|
select get_raw_page('test_part1', 0); -- get farther and error about empty table
|
|
ERROR: block number 0 is out of range for relation "test_part1"
|
|
drop table test_partitioned;
|
|
-- check null bitmap alignment for table whose number of attributes is multiple of 8
|
|
create table test8 (f1 int, f2 int, f3 int, f4 int, f5 int, f6 int, f7 int, f8 int);
|
|
insert into test8(f1, f8) values (x'7f00007f'::int, 0);
|
|
select t_bits, t_data from heap_page_items(get_raw_page('test8', 0));
|
|
t_bits | t_data
|
|
----------+--------------------
|
|
10000001 | \x7f00007f00000000
|
|
(1 row)
|
|
|
|
select tuple_data_split('test8'::regclass, t_data, t_infomask, t_infomask2, t_bits)
|
|
from heap_page_items(get_raw_page('test8', 0));
|
|
tuple_data_split
|
|
-------------------------------------------------------------
|
|
{"\\x7f00007f",NULL,NULL,NULL,NULL,NULL,NULL,"\\x00000000"}
|
|
(1 row)
|
|
|
|
drop table test8;
|
|
-- Failure with incorrect page size
|
|
-- Suppress the DETAIL message, to allow the tests to work across various
|
|
-- page sizes.
|
|
\set VERBOSITY terse
|
|
SELECT fsm_page_contents('aaa'::bytea);
|
|
ERROR: invalid page size
|
|
SELECT page_checksum('bbb'::bytea, 0);
|
|
ERROR: invalid page size
|
|
SELECT page_header('ccc'::bytea);
|
|
ERROR: invalid page size
|
|
\set VERBOSITY default
|