mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-08 12:39:21 +02:00
e2f0f8ed25
1. Update our open() wrapper to check for NT's STATUS_DELETE_PENDING and translate it to Unix-like errors. This is done with RtlGetLastNtStatus(), which is dynamically loaded from ntdll. A new file win32ntdll.c centralizes lookup of NT functions, in case we decide to add more in the future. 2. Remove non-working code that was trying to do something similar for stat(), and just reuse the open() wrapper code. As a side effect, stat() also gains resilience against "sharing violation" errors. 3. Since stat() is used very early in process startup, remove the requirement that the Win32 signal event has been created before pgwin32_open_handle() is reached. Instead, teach pg_usleep() to fall back to a non-interruptible sleep if reached before the signal event is available. This could be back-patched, but for now it's in master only. The problem has apparently been with us for a long time and generated only a few complaints. Proposed patches trigger it more often, which led to this investigation and fix. Reviewed-by: Andres Freund <andres@anarazel.de> Reviewed-by: Alexander Lakhin <exclusion@gmail.com> Reviewed-by: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com> Discussion: https://postgr.es/m/CA%2BhUKGJz_pZTF9mckn6XgSv69%2BjGwdgLkxZ6b3NWGLBCVjqUZA%40mail.gmail.com |
||
---|---|---|
.. | ||
.gitignore | ||
bsearch_arg.c | ||
chklocale.c | ||
dirent.c | ||
dirmod.c | ||
dlopen.c | ||
explicit_bzero.c | ||
fls.c | ||
getaddrinfo.c | ||
getopt_long.c | ||
getopt.c | ||
getpeereid.c | ||
getrusage.c | ||
gettimeofday.c | ||
inet_aton.c | ||
inet_net_ntop.c | ||
kill.c | ||
link.c | ||
Makefile | ||
mkdtemp.c | ||
noblock.c | ||
open.c | ||
path.c | ||
pg_bitutils.c | ||
pg_crc32c_armv8_choose.c | ||
pg_crc32c_armv8.c | ||
pg_crc32c_sb8.c | ||
pg_crc32c_sse42_choose.c | ||
pg_crc32c_sse42.c | ||
pg_strong_random.c | ||
pgcheckdir.c | ||
pgmkdirp.c | ||
pgsleep.c | ||
pgstrcasecmp.c | ||
pgstrsignal.c | ||
pqsignal.c | ||
pread.c | ||
preadv.c | ||
pthread_barrier_wait.c | ||
pthread-win32.h | ||
pwrite.c | ||
pwritev.c | ||
qsort_arg.c | ||
qsort.c | ||
quotes.c | ||
README | ||
setenv.c | ||
snprintf.c | ||
strerror.c | ||
strlcat.c | ||
strlcpy.c | ||
strnlen.c | ||
strtof.c | ||
system.c | ||
tar.c | ||
thread.c | ||
unsetenv.c | ||
win32.ico | ||
win32env.c | ||
win32error.c | ||
win32ntdll.c | ||
win32security.c | ||
win32setlocale.c | ||
win32stat.c | ||
win32ver.rc |
src/port/README libpgport ========= libpgport must have special behavior. It supplies functions to both libraries and applications. However, there are two complexities: 1) Libraries need to use object files that are compiled with exactly the same flags as the library. libpgport might not use the same flags, so it is necessary to recompile the object files for individual libraries. This is done by removing -lpgport from the link line: # Need to recompile any libpgport object files LIBS := $(filter-out -lpgport, $(LIBS)) and adding infrastructure to recompile the object files: OBJS= execute.o typename.o descriptor.o data.o error.o prepare.o memory.o \ connect.o misc.o path.o exec.o \ $(filter strlcat.o, $(LIBOBJS)) The problem is that there is no testing of which object files need to be added, but missing functions usually show up when linking user applications. 2) For applications, we use -lpgport before -lpq, so the static files from libpgport are linked first. This avoids having applications dependent on symbols that are _used_ by libpq, but not intended to be exported by libpq. libpq's libpgport usage changes over time, so such a dependency is a problem. Windows, Linux, AIX, and macOS use an export list to control the symbols exported by libpq.