mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-28 15:07:20 +02:00
e81e8f9342
In the previous coding, new backend processes would attempt to create their self-pipe during the OwnLatch call in InitProcess. However, pipe creation could fail if the kernel is short of resources; and the system does not recover gracefully from a FATAL error right there, since we have armed the dead-man switch for this process and not yet set up the on_shmem_exit callback that would disarm it. The postmaster then forces an unnecessary database-wide crash and restart, as reported by Sean Chittenden. There are various ways we could rearrange the code to fix this, but the simplest and sanest seems to be to split out creation of the self-pipe into a new function InitializeLatchSupport, which must be called from a place where failure is allowed. For most processes that gets called in InitProcess or InitAuxiliaryProcess, but processes that don't call either but still use latches need their own calls. Back-patch to 9.1, which has only a part of the latch logic that 9.2 and HEAD have, but nonetheless includes this bug. |
||
|---|---|---|
| .. | ||
| aix | ||
| darwin | ||
| dynloader | ||
| hpux | ||
| tas | ||
| win32 | ||
| .gitignore | ||
| ipc_test.c | ||
| Makefile | ||
| posix_sema.c | ||
| sysv_sema.c | ||
| sysv_shmem.c | ||
| unix_latch.c | ||
| win32_latch.c | ||
| win32_sema.c | ||
| win32_shmem.c | ||