mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-13 21:39:18 +02:00
2ed532ee8c
Most error messages about a relkind that was not supported or
appropriate for the command was of the pattern
"relation \"%s\" is not a table, foreign table, or materialized view"
This style can become verbose and tedious to maintain. Moreover, it's
not very helpful: If I'm trying to create a comment on a TOAST table,
which is not supported, then the information that I could have created
a comment on a materialized view is pointless.
Instead, write the primary error message shorter and saying more
directly that what was attempted is not possible. Then, in the detail
message, explain that the operation is not supported for the relkind
the object was. To simplify that, add a new function
errdetail_relkind_not_supported() that does this.
In passing, make use of RELKIND_HAS_STORAGE() where appropriate,
instead of listing out the relkinds individually.
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/dc35a398-37d0-75ce-07ea-1dd71d98f8ec@2ndquadrant.com
278 lines
12 KiB
Plaintext
278 lines
12 KiB
Plaintext
CREATE EXTENSION pgstattuple;
|
|
--
|
|
-- It's difficult to come up with platform-independent test cases for
|
|
-- the pgstattuple functions, but the results for empty tables and
|
|
-- indexes should be that.
|
|
--
|
|
create table test (a int primary key, b int[]);
|
|
select * from pgstattuple('test');
|
|
table_len | tuple_count | tuple_len | tuple_percent | dead_tuple_count | dead_tuple_len | dead_tuple_percent | free_space | free_percent
|
|
-----------+-------------+-----------+---------------+------------------+----------------+--------------------+------------+--------------
|
|
0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0
|
|
(1 row)
|
|
|
|
select * from pgstattuple('test'::text);
|
|
table_len | tuple_count | tuple_len | tuple_percent | dead_tuple_count | dead_tuple_len | dead_tuple_percent | free_space | free_percent
|
|
-----------+-------------+-----------+---------------+------------------+----------------+--------------------+------------+--------------
|
|
0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0
|
|
(1 row)
|
|
|
|
select * from pgstattuple('test'::name);
|
|
table_len | tuple_count | tuple_len | tuple_percent | dead_tuple_count | dead_tuple_len | dead_tuple_percent | free_space | free_percent
|
|
-----------+-------------+-----------+---------------+------------------+----------------+--------------------+------------+--------------
|
|
0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0
|
|
(1 row)
|
|
|
|
select * from pgstattuple('test'::regclass);
|
|
table_len | tuple_count | tuple_len | tuple_percent | dead_tuple_count | dead_tuple_len | dead_tuple_percent | free_space | free_percent
|
|
-----------+-------------+-----------+---------------+------------------+----------------+--------------------+------------+--------------
|
|
0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0
|
|
(1 row)
|
|
|
|
select pgstattuple(oid) from pg_class where relname = 'test';
|
|
pgstattuple
|
|
---------------------
|
|
(0,0,0,0,0,0,0,0,0)
|
|
(1 row)
|
|
|
|
select pgstattuple(relname) from pg_class where relname = 'test';
|
|
pgstattuple
|
|
---------------------
|
|
(0,0,0,0,0,0,0,0,0)
|
|
(1 row)
|
|
|
|
select version, tree_level,
|
|
index_size / current_setting('block_size')::int as index_size,
|
|
root_block_no, internal_pages, leaf_pages, empty_pages, deleted_pages,
|
|
avg_leaf_density, leaf_fragmentation
|
|
from pgstatindex('test_pkey');
|
|
version | tree_level | index_size | root_block_no | internal_pages | leaf_pages | empty_pages | deleted_pages | avg_leaf_density | leaf_fragmentation
|
|
---------+------------+------------+---------------+----------------+------------+-------------+---------------+------------------+--------------------
|
|
4 | 0 | 1 | 0 | 0 | 0 | 0 | 0 | NaN | NaN
|
|
(1 row)
|
|
|
|
select version, tree_level,
|
|
index_size / current_setting('block_size')::int as index_size,
|
|
root_block_no, internal_pages, leaf_pages, empty_pages, deleted_pages,
|
|
avg_leaf_density, leaf_fragmentation
|
|
from pgstatindex('test_pkey'::text);
|
|
version | tree_level | index_size | root_block_no | internal_pages | leaf_pages | empty_pages | deleted_pages | avg_leaf_density | leaf_fragmentation
|
|
---------+------------+------------+---------------+----------------+------------+-------------+---------------+------------------+--------------------
|
|
4 | 0 | 1 | 0 | 0 | 0 | 0 | 0 | NaN | NaN
|
|
(1 row)
|
|
|
|
select version, tree_level,
|
|
index_size / current_setting('block_size')::int as index_size,
|
|
root_block_no, internal_pages, leaf_pages, empty_pages, deleted_pages,
|
|
avg_leaf_density, leaf_fragmentation
|
|
from pgstatindex('test_pkey'::name);
|
|
version | tree_level | index_size | root_block_no | internal_pages | leaf_pages | empty_pages | deleted_pages | avg_leaf_density | leaf_fragmentation
|
|
---------+------------+------------+---------------+----------------+------------+-------------+---------------+------------------+--------------------
|
|
4 | 0 | 1 | 0 | 0 | 0 | 0 | 0 | NaN | NaN
|
|
(1 row)
|
|
|
|
select version, tree_level,
|
|
index_size / current_setting('block_size')::int as index_size,
|
|
root_block_no, internal_pages, leaf_pages, empty_pages, deleted_pages,
|
|
avg_leaf_density, leaf_fragmentation
|
|
from pgstatindex('test_pkey'::regclass);
|
|
version | tree_level | index_size | root_block_no | internal_pages | leaf_pages | empty_pages | deleted_pages | avg_leaf_density | leaf_fragmentation
|
|
---------+------------+------------+---------------+----------------+------------+-------------+---------------+------------------+--------------------
|
|
4 | 0 | 1 | 0 | 0 | 0 | 0 | 0 | NaN | NaN
|
|
(1 row)
|
|
|
|
select pg_relpages('test');
|
|
pg_relpages
|
|
-------------
|
|
0
|
|
(1 row)
|
|
|
|
select pg_relpages('test_pkey');
|
|
pg_relpages
|
|
-------------
|
|
1
|
|
(1 row)
|
|
|
|
select pg_relpages('test_pkey'::text);
|
|
pg_relpages
|
|
-------------
|
|
1
|
|
(1 row)
|
|
|
|
select pg_relpages('test_pkey'::name);
|
|
pg_relpages
|
|
-------------
|
|
1
|
|
(1 row)
|
|
|
|
select pg_relpages('test_pkey'::regclass);
|
|
pg_relpages
|
|
-------------
|
|
1
|
|
(1 row)
|
|
|
|
select pg_relpages(oid) from pg_class where relname = 'test_pkey';
|
|
pg_relpages
|
|
-------------
|
|
1
|
|
(1 row)
|
|
|
|
select pg_relpages(relname) from pg_class where relname = 'test_pkey';
|
|
pg_relpages
|
|
-------------
|
|
1
|
|
(1 row)
|
|
|
|
create index test_ginidx on test using gin (b);
|
|
select * from pgstatginindex('test_ginidx');
|
|
version | pending_pages | pending_tuples
|
|
---------+---------------+----------------
|
|
2 | 0 | 0
|
|
(1 row)
|
|
|
|
create index test_hashidx on test using hash (b);
|
|
select * from pgstathashindex('test_hashidx');
|
|
version | bucket_pages | overflow_pages | bitmap_pages | unused_pages | live_items | dead_items | free_percent
|
|
---------+--------------+----------------+--------------+--------------+------------+------------+--------------
|
|
4 | 4 | 0 | 1 | 0 | 0 | 0 | 100
|
|
(1 row)
|
|
|
|
-- these should error with the wrong type
|
|
select pgstatginindex('test_pkey');
|
|
ERROR: relation "test_pkey" is not a GIN index
|
|
select pgstathashindex('test_pkey');
|
|
ERROR: relation "test_pkey" is not a hash index
|
|
select pgstatindex('test_ginidx');
|
|
ERROR: relation "test_ginidx" is not a btree index
|
|
select pgstathashindex('test_ginidx');
|
|
ERROR: relation "test_ginidx" is not a hash index
|
|
select pgstatindex('test_hashidx');
|
|
ERROR: relation "test_hashidx" is not a btree index
|
|
select pgstatginindex('test_hashidx');
|
|
ERROR: relation "test_hashidx" is not a GIN index
|
|
-- check that using any of these functions with unsupported relations will fail
|
|
create table test_partitioned (a int) partition by range (a);
|
|
create index test_partitioned_index on test_partitioned(a);
|
|
-- these should all fail
|
|
select pgstattuple('test_partitioned');
|
|
ERROR: cannot get tuple-level statistics for relation "test_partitioned"
|
|
DETAIL: This operation is not supported for partitioned tables.
|
|
select pgstattuple('test_partitioned_index');
|
|
ERROR: cannot get tuple-level statistics for relation "test_partitioned_index"
|
|
DETAIL: This operation is not supported for partitioned indexes.
|
|
select pgstattuple_approx('test_partitioned');
|
|
ERROR: relation "test_partitioned" is of wrong relation kind
|
|
DETAIL: This operation is not supported for partitioned tables.
|
|
select pg_relpages('test_partitioned');
|
|
ERROR: cannot get page count of relation "test_partitioned"
|
|
DETAIL: This operation is not supported for partitioned tables.
|
|
select pgstatindex('test_partitioned');
|
|
ERROR: relation "test_partitioned" is not a btree index
|
|
select pgstatginindex('test_partitioned');
|
|
ERROR: relation "test_partitioned" is not a GIN index
|
|
select pgstathashindex('test_partitioned');
|
|
ERROR: "test_partitioned" is not an index
|
|
create view test_view as select 1;
|
|
-- these should all fail
|
|
select pgstattuple('test_view');
|
|
ERROR: cannot get tuple-level statistics for relation "test_view"
|
|
DETAIL: This operation is not supported for views.
|
|
select pgstattuple_approx('test_view');
|
|
ERROR: relation "test_view" is of wrong relation kind
|
|
DETAIL: This operation is not supported for views.
|
|
select pg_relpages('test_view');
|
|
ERROR: cannot get page count of relation "test_view"
|
|
DETAIL: This operation is not supported for views.
|
|
select pgstatindex('test_view');
|
|
ERROR: relation "test_view" is not a btree index
|
|
select pgstatginindex('test_view');
|
|
ERROR: relation "test_view" is not a GIN index
|
|
select pgstathashindex('test_view');
|
|
ERROR: "test_view" is not an index
|
|
create foreign data wrapper dummy;
|
|
create server dummy_server foreign data wrapper dummy;
|
|
create foreign table test_foreign_table () server dummy_server;
|
|
-- these should all fail
|
|
select pgstattuple('test_foreign_table');
|
|
ERROR: cannot get tuple-level statistics for relation "test_foreign_table"
|
|
DETAIL: This operation is not supported for foreign tables.
|
|
select pgstattuple_approx('test_foreign_table');
|
|
ERROR: relation "test_foreign_table" is of wrong relation kind
|
|
DETAIL: This operation is not supported for foreign tables.
|
|
select pg_relpages('test_foreign_table');
|
|
ERROR: cannot get page count of relation "test_foreign_table"
|
|
DETAIL: This operation is not supported for foreign tables.
|
|
select pgstatindex('test_foreign_table');
|
|
ERROR: relation "test_foreign_table" is not a btree index
|
|
select pgstatginindex('test_foreign_table');
|
|
ERROR: relation "test_foreign_table" is not a GIN index
|
|
select pgstathashindex('test_foreign_table');
|
|
ERROR: "test_foreign_table" is not an index
|
|
-- a partition of a partitioned table should work though
|
|
create table test_partition partition of test_partitioned for values from (1) to (100);
|
|
select pgstattuple('test_partition');
|
|
pgstattuple
|
|
---------------------
|
|
(0,0,0,0,0,0,0,0,0)
|
|
(1 row)
|
|
|
|
select pgstattuple_approx('test_partition');
|
|
pgstattuple_approx
|
|
-----------------------
|
|
(0,0,0,0,0,0,0,0,0,0)
|
|
(1 row)
|
|
|
|
select pg_relpages('test_partition');
|
|
pg_relpages
|
|
-------------
|
|
0
|
|
(1 row)
|
|
|
|
-- toast tables should work
|
|
select pgstattuple((select reltoastrelid from pg_class where relname = 'test'));
|
|
pgstattuple
|
|
---------------------
|
|
(0,0,0,0,0,0,0,0,0)
|
|
(1 row)
|
|
|
|
select pgstattuple_approx((select reltoastrelid from pg_class where relname = 'test'));
|
|
pgstattuple_approx
|
|
-----------------------
|
|
(0,0,0,0,0,0,0,0,0,0)
|
|
(1 row)
|
|
|
|
select pg_relpages((select reltoastrelid from pg_class where relname = 'test'));
|
|
pg_relpages
|
|
-------------
|
|
0
|
|
(1 row)
|
|
|
|
-- not for the index calls though, of course
|
|
select pgstatindex('test_partition');
|
|
ERROR: relation "test_partition" is not a btree index
|
|
select pgstatginindex('test_partition');
|
|
ERROR: relation "test_partition" is not a GIN index
|
|
select pgstathashindex('test_partition');
|
|
ERROR: "test_partition" is not an index
|
|
-- an actual index of a partitioned table should work though
|
|
create index test_partition_idx on test_partition(a);
|
|
create index test_partition_hash_idx on test_partition using hash (a);
|
|
-- these should work
|
|
select pgstatindex('test_partition_idx');
|
|
pgstatindex
|
|
------------------------------
|
|
(4,0,8192,0,0,0,0,0,NaN,NaN)
|
|
(1 row)
|
|
|
|
select pgstathashindex('test_partition_hash_idx');
|
|
pgstathashindex
|
|
---------------------
|
|
(4,8,0,1,0,0,0,100)
|
|
(1 row)
|
|
|
|
drop table test_partitioned;
|
|
drop view test_view;
|
|
drop foreign table test_foreign_table;
|
|
drop server dummy_server;
|
|
drop foreign data wrapper dummy;
|