mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-14 23:03:22 +02:00
eba775345d
The previous tacit assumption that index_form_tuple() hides differences in the TOAST state of its input datums was wrong. Normalize input varlena datums by decompressing compressed values, and forming a new index tuple for fingerprinting using uncompressed inputs. The final normalized representation may actually be compressed once again within index_form_tuple(), though that shouldn't matter. When the original tuple is found to have no datums that are compressed inline, fingerprint the original tuple directly. Normalization avoids false positive reports of corruption in certain cases. For example, the executor can apply toasting with some inline compression to an entire heap tuple because its input has a single external TOAST pointer. Varlena datums for other attributes that are not particularly good candidates for inline compression can be compressed in the heap tuple in passing, without the representation of the same values in index tuples ever receiving concomitant inline compression. Add a test case to recreate the issue in a simpler though less realistic way: by exploiting differences in pg_attribute.attstorage between heap and index relations. This bug was discovered by me during testing of an upcoming set of nbtree enhancements. It was also independently reported by Andreas Kunert, as bug #15597. His test case was rather more realistic than the one I ended up using. Bug: #15597 Discussion: https://postgr.es/m/CAH2-WznrVd9ie+TTJ45nDT+v2nUt6YJwQrT9SebCdQKtAvfPZw@mail.gmail.com Discussion: https://postgr.es/m/15597-294e5d3e7f01c407@postgresql.org Backpatch: 11-, where heapallindexed verification was introduced.
170 lines
5.6 KiB
Plaintext
170 lines
5.6 KiB
Plaintext
CREATE TABLE bttest_a(id int8);
|
|
CREATE TABLE bttest_b(id int8);
|
|
CREATE TABLE bttest_multi(id int8, data int8);
|
|
CREATE TABLE delete_test_table (a bigint, b bigint, c bigint, d bigint);
|
|
-- Stabalize tests
|
|
ALTER TABLE bttest_a SET (autovacuum_enabled = false);
|
|
ALTER TABLE bttest_b SET (autovacuum_enabled = false);
|
|
ALTER TABLE bttest_multi SET (autovacuum_enabled = false);
|
|
ALTER TABLE delete_test_table SET (autovacuum_enabled = false);
|
|
INSERT INTO bttest_a SELECT * FROM generate_series(1, 100000);
|
|
INSERT INTO bttest_b SELECT * FROM generate_series(100000, 1, -1);
|
|
INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i;
|
|
CREATE INDEX bttest_a_idx ON bttest_a USING btree (id);
|
|
CREATE INDEX bttest_b_idx ON bttest_b USING btree (id);
|
|
CREATE UNIQUE INDEX bttest_multi_idx ON bttest_multi
|
|
USING btree (id) INCLUDE (data);
|
|
CREATE ROLE bttest_role;
|
|
-- verify permissions are checked (error due to function not callable)
|
|
SET ROLE bttest_role;
|
|
SELECT bt_index_check('bttest_a_idx'::regclass);
|
|
ERROR: permission denied for function bt_index_check
|
|
SELECT bt_index_parent_check('bttest_a_idx'::regclass);
|
|
ERROR: permission denied for function bt_index_parent_check
|
|
RESET ROLE;
|
|
-- we, intentionally, don't check relation permissions - it's useful
|
|
-- to run this cluster-wide with a restricted account, and as tested
|
|
-- above explicit permission has to be granted for that.
|
|
GRANT EXECUTE ON FUNCTION bt_index_check(regclass) TO bttest_role;
|
|
GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass) TO bttest_role;
|
|
GRANT EXECUTE ON FUNCTION bt_index_check(regclass, boolean) TO bttest_role;
|
|
GRANT EXECUTE ON FUNCTION bt_index_parent_check(regclass, boolean) TO bttest_role;
|
|
SET ROLE bttest_role;
|
|
SELECT bt_index_check('bttest_a_idx');
|
|
bt_index_check
|
|
----------------
|
|
|
|
(1 row)
|
|
|
|
SELECT bt_index_parent_check('bttest_a_idx');
|
|
bt_index_parent_check
|
|
-----------------------
|
|
|
|
(1 row)
|
|
|
|
RESET ROLE;
|
|
-- verify plain tables are rejected (error)
|
|
SELECT bt_index_check('bttest_a');
|
|
ERROR: "bttest_a" is not an index
|
|
SELECT bt_index_parent_check('bttest_a');
|
|
ERROR: "bttest_a" is not an index
|
|
-- verify non-existing indexes are rejected (error)
|
|
SELECT bt_index_check(17);
|
|
ERROR: could not open relation with OID 17
|
|
SELECT bt_index_parent_check(17);
|
|
ERROR: could not open relation with OID 17
|
|
-- verify wrong index types are rejected (error)
|
|
BEGIN;
|
|
CREATE INDEX bttest_a_brin_idx ON bttest_a USING brin(id);
|
|
SELECT bt_index_parent_check('bttest_a_brin_idx');
|
|
ERROR: only B-Tree indexes are supported as targets for verification
|
|
DETAIL: Relation "bttest_a_brin_idx" is not a B-Tree index.
|
|
ROLLBACK;
|
|
-- normal check outside of xact
|
|
SELECT bt_index_check('bttest_a_idx');
|
|
bt_index_check
|
|
----------------
|
|
|
|
(1 row)
|
|
|
|
-- more expansive tests
|
|
SELECT bt_index_check('bttest_a_idx', true);
|
|
bt_index_check
|
|
----------------
|
|
|
|
(1 row)
|
|
|
|
SELECT bt_index_parent_check('bttest_b_idx', true);
|
|
bt_index_parent_check
|
|
-----------------------
|
|
|
|
(1 row)
|
|
|
|
BEGIN;
|
|
SELECT bt_index_check('bttest_a_idx');
|
|
bt_index_check
|
|
----------------
|
|
|
|
(1 row)
|
|
|
|
SELECT bt_index_parent_check('bttest_b_idx');
|
|
bt_index_parent_check
|
|
-----------------------
|
|
|
|
(1 row)
|
|
|
|
-- make sure we don't have any leftover locks
|
|
SELECT * FROM pg_locks
|
|
WHERE relation = ANY(ARRAY['bttest_a', 'bttest_a_idx', 'bttest_b', 'bttest_b_idx']::regclass[])
|
|
AND pid = pg_backend_pid();
|
|
locktype | database | relation | page | tuple | virtualxid | transactionid | classid | objid | objsubid | virtualtransaction | pid | mode | granted | fastpath
|
|
----------+----------+----------+------+-------+------------+---------------+---------+-------+----------+--------------------+-----+------+---------+----------
|
|
(0 rows)
|
|
|
|
COMMIT;
|
|
-- normal check outside of xact for index with included columns
|
|
SELECT bt_index_check('bttest_multi_idx');
|
|
bt_index_check
|
|
----------------
|
|
|
|
(1 row)
|
|
|
|
-- more expansive test for index with included columns
|
|
SELECT bt_index_parent_check('bttest_multi_idx', true);
|
|
bt_index_parent_check
|
|
-----------------------
|
|
|
|
(1 row)
|
|
|
|
-- repeat expansive test for index built using insertions
|
|
TRUNCATE bttest_multi;
|
|
INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i;
|
|
SELECT bt_index_parent_check('bttest_multi_idx', true);
|
|
bt_index_parent_check
|
|
-----------------------
|
|
|
|
(1 row)
|
|
|
|
--
|
|
-- Test for multilevel page deletion/downlink present checks
|
|
--
|
|
INSERT INTO delete_test_table SELECT i, 1, 2, 3 FROM generate_series(1,80000) i;
|
|
ALTER TABLE delete_test_table ADD PRIMARY KEY (a,b,c,d);
|
|
DELETE FROM delete_test_table WHERE a > 40000;
|
|
VACUUM delete_test_table;
|
|
DELETE FROM delete_test_table WHERE a > 10;
|
|
VACUUM delete_test_table;
|
|
SELECT bt_index_parent_check('delete_test_table_pkey', true);
|
|
bt_index_parent_check
|
|
-----------------------
|
|
|
|
(1 row)
|
|
|
|
--
|
|
-- BUG #15597: must not assume consistent input toasting state when forming
|
|
-- tuple. Bloom filter must fingerprint normalized index tuple representation.
|
|
--
|
|
CREATE TABLE toast_bug(buggy text);
|
|
ALTER TABLE toast_bug ALTER COLUMN buggy SET STORAGE plain;
|
|
-- pg_attribute entry for toasty.buggy will have plain storage:
|
|
CREATE INDEX toasty ON toast_bug(buggy);
|
|
-- Whereas pg_attribute entry for toast_bug.buggy now has extended storage:
|
|
ALTER TABLE toast_bug ALTER COLUMN buggy SET STORAGE extended;
|
|
-- Insert compressible heap tuple (comfortably exceeds TOAST_TUPLE_THRESHOLD):
|
|
INSERT INTO toast_bug SELECT repeat('a', 2200);
|
|
-- Should not get false positive report of corruption:
|
|
SELECT bt_index_check('toasty', true);
|
|
bt_index_check
|
|
----------------
|
|
|
|
(1 row)
|
|
|
|
-- cleanup
|
|
DROP TABLE bttest_a;
|
|
DROP TABLE bttest_b;
|
|
DROP TABLE bttest_multi;
|
|
DROP TABLE delete_test_table;
|
|
DROP TABLE toast_bug;
|
|
DROP OWNED BY bttest_role; -- permissions
|
|
DROP ROLE bttest_role;
|