postgresql/src/backend
Tom Lane ec28808ba8 Fix ginEntryInsert's counting of GIN leaf tuples.
As the code stands, nEntries counts the number of ginEntryInsert()
calls, so that's what you end up with at the end of a GIN index build.
However, ginvacuumcleanup() recomputes nEntries as the number of
surviving leaf tuples, and that's generally consistent with the way that
gincostestimate() uses the value.  So let's clearly define nEntries
as the number of leaf tuples, and therefore adjust ginEntryInsert() to
increment it only when we make a new one, not when we add TIDs into an
existing tuple or posting tree.

In practice this inconsistency probably has little impact, so I don't
feel a need to back-patch.

Insung Moon and Keisuke Kuroda

Discussion: https://postgr.es/m/CAEMmqBuH_O-oXL+3_ArQ6F5cJ7kXVow2SGQB3HRacku_T+xkmA@mail.gmail.com
2019-11-04 14:16:42 -05:00
..
access Fix ginEntryInsert's counting of GIN leaf tuples. 2019-11-04 14:16:42 -05:00
bootstrap Fix inconsistencies and typos in the tree 2019-07-16 13:23:53 +09:00
catalog PG_FINALLY 2019-11-01 11:18:03 +01:00
commands Fix failure when creating cloned indexes for a partition 2019-11-02 14:16:04 +09:00
executor Rename some toasting functions based on whether they are heap-specific. 2019-10-04 14:24:46 -04:00
foreign Update copyright for 2019 2019-01-02 12:44:25 -05:00
jit Don't generate EEOP_*_FETCHSOME operations for slots know to be virtual. 2019-09-30 16:06:16 -07:00
lib Fix inconsistencies in the code 2019-07-08 13:15:09 +09:00
libpq PG_FINALLY 2019-11-01 11:18:03 +01:00
main initdb: Remove obsolete locale handling 2019-08-14 06:51:13 +02:00
nodes Avoid trying to release a List's initial allocation via repalloc(). 2019-10-06 12:06:30 -04:00
optimizer Remove last traces of heap_open/close in the tree 2019-10-19 11:18:15 +09:00
parser Fix handling of GENERATED columns in CREATE TABLE LIKE INCLUDING DEFAULTS. 2019-09-25 17:30:42 -04:00
partitioning Update obsolete comment. 2019-10-21 17:30:00 +09:00
po Translation updates 2019-06-17 15:30:20 +02:00
port Remove mingwcompat.c 2019-09-17 11:34:28 +02:00
postmaster Clean up properly error_context_stack in autovacuum worker on exception 2019-10-23 10:25:06 +09:00
regex Fix inconsistencies and typos in the tree, take 9 2019-08-05 12:14:58 +09:00
replication Add some assertions in syncrep.c 2019-11-01 22:51:05 +09:00
rewrite Rationalize use of list_concat + list_copy combinations. 2019-08-12 11:20:18 -04:00
snowball Sync our Snowball stemmer dictionaries with current upstream 2019-07-04 13:26:48 +02:00
statistics Fix typos in the code 2019-10-30 10:03:00 +09:00
storage Fix typos in the code 2019-10-30 10:03:00 +09:00
tcop PG_FINALLY 2019-11-01 11:18:03 +01:00
tsearch Suppress warning from older compilers. 2019-11-03 16:10:23 -05:00
utils Fix some compiler warnings on older compilers 2019-11-04 11:07:32 +01:00
.gitignore Add .gitignore entries for AIX-specific intermediate build artifacts. 2015-07-08 20:44:22 -04:00
common.mk Remove PARTIAL_LINKING build mode. 2018-03-30 17:33:04 -07:00
Makefile Get rid of jsonpath_gram.h and jsonpath_scanner.h 2019-03-20 11:13:34 +03:00
nls.mk Translation updates 2019-05-20 16:00:53 +02:00