mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-08-19 08:43:24 +02:00
ec5896aed3
Heikki noticed in 544E23C0.8090605@vmware.com that slot.c and snapbuild.c were missing the FIN_CRC32 call when computing/checking checksums of on disk files. That doesn't lower the the error detection capabilities of the checksum, but is inconsistent with other usages. In a followup mail Heikki also noticed that, contrary to a comment, the 'version' and 'length' struct fields of replication slot's on disk data where not covered by the checksum. That's not likely to lead to actually missed corruption as those fields are cross checked with the expected version and the actual file length. But it's wrong nonetheless. As fixing these issues makes existing on disk files unreadable, bump the expected versions of on disk files for both slots and logical decoding historic catalog snapshots. This means that loading old files will fail with ERROR: "replication slot file ... has unsupported version 1" and ERROR: "snapbuild state file ... has unsupported version 1 instead of 2" respectively. Given the low likelihood of anybody already using these new features in a production setup that seems acceptable. Fixing these issues made me notice that there's no regression test covering the loading of historic snapshot from disk - so add one. Backpatch to 9.4 where these features were introduced.
74 lines
2.4 KiB
Makefile
74 lines
2.4 KiB
Makefile
# contrib/test_decoding/Makefile
|
|
|
|
MODULES = test_decoding
|
|
PGFILEDESC = "test_decoding - example of a logical decoding output plugin"
|
|
|
|
# Note: because we don't tell the Makefile there are any regression tests,
|
|
# we have to clean those result files explicitly
|
|
EXTRA_CLEAN = $(pg_regress_clean_files) ./regression_output ./isolation_output
|
|
|
|
ifdef USE_PGXS
|
|
PG_CONFIG = pg_config
|
|
PGXS := $(shell $(PG_CONFIG) --pgxs)
|
|
include $(PGXS)
|
|
else
|
|
subdir = contrib/test_decoding
|
|
top_builddir = ../..
|
|
include $(top_builddir)/src/Makefile.global
|
|
include $(top_srcdir)/contrib/contrib-global.mk
|
|
endif
|
|
|
|
# Disabled because these tests require "wal_level=logical", which
|
|
# typical installcheck users do not have (e.g. buildfarm clients).
|
|
installcheck:;
|
|
|
|
# But it can nonetheless be very helpful to run tests on preexisting
|
|
# installation, allow to do so, but only if requested explicitly.
|
|
installcheck-force: regresscheck-install-force isolationcheck-install-force
|
|
|
|
check: regresscheck isolationcheck
|
|
|
|
submake-regress:
|
|
$(MAKE) -C $(top_builddir)/src/test/regress all
|
|
|
|
submake-isolation:
|
|
$(MAKE) -C $(top_builddir)/src/test/isolation all
|
|
|
|
submake-test_decoding:
|
|
$(MAKE) -C $(top_builddir)/contrib/test_decoding
|
|
|
|
REGRESSCHECKS=ddl rewrite toast permissions decoding_in_xact binary prepared
|
|
|
|
regresscheck: all | submake-regress submake-test_decoding
|
|
$(MKDIR_P) regression_output
|
|
$(pg_regress_check) \
|
|
--temp-config $(top_srcdir)/contrib/test_decoding/logical.conf \
|
|
--temp-install=./tmp_check \
|
|
--extra-install=contrib/test_decoding \
|
|
--outputdir=./regression_output \
|
|
$(REGRESSCHECKS)
|
|
|
|
regresscheck-install-force: | submake-regress submake-test_decoding
|
|
$(pg_regress_installcheck) \
|
|
--extra-install=contrib/test_decoding \
|
|
$(REGRESSCHECKS)
|
|
|
|
ISOLATIONCHECKS=mxact delayed_startup ondisk_startup concurrent_ddl_dml
|
|
|
|
isolationcheck: all | submake-isolation submake-test_decoding
|
|
$(MKDIR_P) isolation_output
|
|
$(pg_isolation_regress_check) \
|
|
--temp-config $(top_srcdir)/contrib/test_decoding/logical.conf \
|
|
--extra-install=contrib/test_decoding \
|
|
--outputdir=./isolation_output \
|
|
$(ISOLATIONCHECKS)
|
|
|
|
isolationcheck-install-force: all | submake-isolation submake-test_decoding
|
|
$(pg_isolation_regress_installcheck) \
|
|
--extra-install=contrib/test_decoding \
|
|
$(ISOLATIONCHECKS)
|
|
|
|
PHONY: submake-test_decoding submake-regress check \
|
|
regresscheck regresscheck-install-force \
|
|
isolationcheck isolationcheck-install-force
|