mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-16 08:31:09 +02:00
afa358786b
Hostile objects located within the installation-time search_path could
capture references in an extension's installation or upgrade script.
If the extension is being installed with superuser privileges, this
opens the door to privilege escalation. While such hazards have existed
all along, their urgency increases with the v13 "trusted extensions"
feature, because that lets a non-superuser control the installation path
for a superuser-privileged script. Therefore, make a number of changes
to make such situations more secure:
* Tweak the construction of the installation-time search_path to ensure
that references to objects in pg_catalog can't be subverted; and
explicitly add pg_temp to the end of the path to prevent attacks using
temporary objects.
* Disable check_function_bodies within installation/upgrade scripts,
so that any security gaps in SQL-language or PL-language function bodies
cannot create a risk of unwanted installation-time code execution.
* Adjust lookup of type input/receive functions and join estimator
functions to complain if there are multiple candidate functions. This
prevents capture of references to functions whose signature is not the
first one checked; and it's arguably more user-friendly anyway.
* Modify various contrib upgrade scripts to ensure that catalog
modification queries are executed with secure search paths. (These
are in-place modifications with no extension version changes, since
it is the update process itself that is at issue, not the end result.)
Extensions that depend on other extensions cannot be made fully secure
by these methods alone; therefore, revert the "trusted" marking that
commit eb67623c9 applied to earthdistance and hstore_plperl, pending
some better solution to that set of issues.
Also add documentation around these issues, to help extension authors
write secure installation scripts.
Patch by me, following an observation by Andres Freund; thanks
to Noah Misch for review.
Security: CVE-2020-14350
126 lines
7.1 KiB
PL/PgSQL
126 lines
7.1 KiB
PL/PgSQL
/* contrib/intarray/intarray--unpackaged--1.0.sql */
|
|
|
|
-- complain if script is sourced in psql, rather than via CREATE EXTENSION
|
|
\echo Use "CREATE EXTENSION intarray FROM unpackaged" to load this file. \quit
|
|
|
|
ALTER EXTENSION intarray ADD type query_int;
|
|
ALTER EXTENSION intarray ADD function bqarr_in(cstring);
|
|
ALTER EXTENSION intarray ADD function bqarr_out(query_int);
|
|
ALTER EXTENSION intarray ADD function querytree(query_int);
|
|
ALTER EXTENSION intarray ADD function boolop(integer[],query_int);
|
|
ALTER EXTENSION intarray ADD function rboolop(query_int,integer[]);
|
|
ALTER EXTENSION intarray ADD operator ~~(query_int,integer[]);
|
|
ALTER EXTENSION intarray ADD operator @@(integer[],query_int);
|
|
ALTER EXTENSION intarray ADD function _int_contains(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function _int_contained(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function _int_overlap(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function _int_same(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function _int_different(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function _int_union(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function _int_inter(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD operator &&(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD operator <@(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD operator @>(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD operator ~(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD operator @(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function intset(integer);
|
|
ALTER EXTENSION intarray ADD function icount(integer[]);
|
|
ALTER EXTENSION intarray ADD operator #(NONE,integer[]);
|
|
ALTER EXTENSION intarray ADD function sort(integer[],text);
|
|
ALTER EXTENSION intarray ADD function sort(integer[]);
|
|
ALTER EXTENSION intarray ADD function sort_asc(integer[]);
|
|
ALTER EXTENSION intarray ADD function sort_desc(integer[]);
|
|
ALTER EXTENSION intarray ADD function uniq(integer[]);
|
|
ALTER EXTENSION intarray ADD function idx(integer[],integer);
|
|
ALTER EXTENSION intarray ADD operator #(integer[],integer);
|
|
ALTER EXTENSION intarray ADD function subarray(integer[],integer,integer);
|
|
ALTER EXTENSION intarray ADD function subarray(integer[],integer);
|
|
ALTER EXTENSION intarray ADD function intarray_push_elem(integer[],integer);
|
|
ALTER EXTENSION intarray ADD operator +(integer[],integer);
|
|
ALTER EXTENSION intarray ADD function intarray_push_array(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD operator +(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function intarray_del_elem(integer[],integer);
|
|
ALTER EXTENSION intarray ADD operator -(integer[],integer);
|
|
ALTER EXTENSION intarray ADD function intset_union_elem(integer[],integer);
|
|
ALTER EXTENSION intarray ADD operator |(integer[],integer);
|
|
ALTER EXTENSION intarray ADD operator |(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function intset_subtract(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD operator -(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD operator &(integer[],integer[]);
|
|
ALTER EXTENSION intarray ADD function g_int_consistent(internal,integer[],integer,oid,internal);
|
|
ALTER EXTENSION intarray ADD function g_int_compress(internal);
|
|
ALTER EXTENSION intarray ADD function g_int_decompress(internal);
|
|
ALTER EXTENSION intarray ADD function g_int_penalty(internal,internal,internal);
|
|
ALTER EXTENSION intarray ADD function g_int_picksplit(internal,internal);
|
|
ALTER EXTENSION intarray ADD function g_int_union(internal,internal);
|
|
ALTER EXTENSION intarray ADD function g_int_same(integer[],integer[],internal);
|
|
ALTER EXTENSION intarray ADD operator family gist__int_ops using gist;
|
|
ALTER EXTENSION intarray ADD operator class gist__int_ops using gist;
|
|
ALTER EXTENSION intarray ADD type intbig_gkey;
|
|
ALTER EXTENSION intarray ADD function _intbig_in(cstring);
|
|
ALTER EXTENSION intarray ADD function _intbig_out(intbig_gkey);
|
|
ALTER EXTENSION intarray ADD function g_intbig_consistent(internal,internal,integer,oid,internal);
|
|
ALTER EXTENSION intarray ADD function g_intbig_compress(internal);
|
|
ALTER EXTENSION intarray ADD function g_intbig_decompress(internal);
|
|
ALTER EXTENSION intarray ADD function g_intbig_penalty(internal,internal,internal);
|
|
ALTER EXTENSION intarray ADD function g_intbig_picksplit(internal,internal);
|
|
ALTER EXTENSION intarray ADD function g_intbig_union(internal,internal);
|
|
ALTER EXTENSION intarray ADD function g_intbig_same(internal,internal,internal);
|
|
ALTER EXTENSION intarray ADD operator family gist__intbig_ops using gist;
|
|
ALTER EXTENSION intarray ADD operator class gist__intbig_ops using gist;
|
|
ALTER EXTENSION intarray ADD operator family gin__int_ops using gin;
|
|
ALTER EXTENSION intarray ADD operator class gin__int_ops using gin;
|
|
|
|
-- These functions had different signatures in 9.0. We can't just
|
|
-- drop and recreate them because they are linked into the GIN opclass,
|
|
-- so we need some ugly hacks.
|
|
|
|
-- First, absorb them into the extension under their old identities.
|
|
|
|
ALTER EXTENSION intarray ADD function ginint4_queryextract(internal,internal,smallint,internal,internal);
|
|
ALTER EXTENSION intarray ADD function ginint4_consistent(internal,smallint,internal,integer,internal,internal);
|
|
|
|
-- Next, fix the parameter lists by means of direct UPDATE on the pg_proc
|
|
-- entries. This is ugly as can be, but there's no other way to do it
|
|
-- while preserving the identities (OIDs) of the functions.
|
|
|
|
DO LANGUAGE plpgsql
|
|
$$
|
|
DECLARE
|
|
my_schema_unquoted pg_catalog.text := pg_catalog.current_schema();
|
|
my_schema pg_catalog.text := pg_catalog.quote_ident(pg_catalog.current_schema());
|
|
old_path pg_catalog.text := pg_catalog.current_setting('search_path');
|
|
BEGIN
|
|
-- for safety, transiently set search_path to just pg_catalog+pg_temp
|
|
PERFORM pg_catalog.set_config('search_path', 'pg_catalog, pg_temp', true);
|
|
|
|
UPDATE pg_catalog.pg_proc
|
|
SET pronargs = 7, proargtypes = '2281 2281 21 2281 2281 2281 2281'
|
|
WHERE oid = (my_schema || '.ginint4_queryextract(internal,internal,smallint,internal,internal)')::pg_catalog.regprocedure;
|
|
|
|
UPDATE pg_catalog.pg_proc
|
|
SET pronargs = 8, proargtypes = '2281 21 2281 23 2281 2281 2281 2281'
|
|
WHERE oid = (my_schema || '.ginint4_consistent(internal,smallint,internal,integer,internal,internal)')::pg_catalog.regprocedure;
|
|
|
|
-- intarray also relies on the core function ginarrayextract, which changed
|
|
-- signature in 9.1. To support upgrading, pg_catalog contains entries
|
|
-- for ginarrayextract with both 2 and 3 args, and the former is what would
|
|
-- have been added to our opclass during initial restore of a 9.0 dump script.
|
|
-- Avert your eyes while we hack the pg_amproc entry to make it link to the
|
|
-- 3-arg form ...
|
|
|
|
UPDATE pg_catalog.pg_amproc
|
|
SET amproc = 'pg_catalog.ginarrayextract(anyarray,internal,internal)'::pg_catalog.regprocedure
|
|
WHERE amprocfamily =
|
|
(SELECT oid FROM pg_catalog.pg_opfamily WHERE opfname = 'gin__int_ops' AND
|
|
opfnamespace = (SELECT oid FROM pg_catalog.pg_namespace
|
|
WHERE nspname = my_schema_unquoted))
|
|
AND amproclefttype = 'integer[]'::pg_catalog.regtype
|
|
AND amprocrighttype = 'integer[]'::pg_catalog.regtype
|
|
AND amprocnum = 2
|
|
AND amproc = 'pg_catalog.ginarrayextract(anyarray,internal)'::pg_catalog.regprocedure;
|
|
|
|
PERFORM pg_catalog.set_config('search_path', old_path, true);
|
|
END
|
|
$$;
|