postgresql/contrib/pg_trgm
Tom Lane 586dd5d6a5 Replace a bunch more uses of strncpy() with safer coding.
strncpy() has a well-deserved reputation for being unsafe, so make an
effort to get rid of nearly all occurrences in HEAD.

A large fraction of the remaining uses were passing length less than or
equal to the known strlen() of the source, in which case no null-padding
can occur and the behavior is equivalent to memcpy(), though doubtless
slower and certainly harder to reason about.  So just use memcpy() in
these cases.

In other cases, use either StrNCpy() or strlcpy() as appropriate (depending
on whether padding to the full length of the destination buffer seems
useful).

I left a few strncpy() calls alone in the src/timezone/ code, to keep it
in sync with upstream (the IANA tzcode distribution).  There are also a
few such calls in ecpg that could possibly do with more analysis.

AFAICT, none of these changes are more than cosmetic, except for the four
occurrences in fe-secure-openssl.c, which are in fact buggy: an overlength
source leads to a non-null-terminated destination buffer and ensuing
misbehavior.  These don't seem like security issues, first because no stack
clobber is possible and second because if your values of sslcert etc are
coming from untrusted sources then you've got problems way worse than this.
Still, it's undesirable to have unpredictable behavior for overlength
inputs, so back-patch those four changes to all active branches.
2015-01-24 13:05:42 -05:00
..
data
expected Make contrib/pg_trgm also support regex searches with GiST indexes. 2013-04-10 13:31:02 -04:00
sql Make contrib/pg_trgm also support regex searches with GiST indexes. 2013-04-10 13:31:02 -04:00
.gitignore Support "make check" in contrib 2011-04-25 22:27:11 +03:00
Makefile Add file version information to most installed Windows binaries. 2014-07-14 14:07:52 -04:00
pg_trgm--1.0--1.1.sql Fix typo in update scripts for some contrib modules. 2013-07-19 04:13:01 +09:00
pg_trgm--1.1.sql Fix volatility markings of some contrib I/O functions. 2014-11-05 11:34:11 -05:00
pg_trgm--unpackaged--1.0.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pg_trgm.control Support indexing of regular-expression searches in contrib/pg_trgm. 2013-04-09 01:06:54 -04:00
trgm_gin.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
trgm_gist.c pgindent run for 9.4 2014-05-06 12:12:18 -04:00
trgm_op.c Switch to CRC-32C in WAL and other places. 2014-11-04 11:39:48 +02:00
trgm_regexp.c Replace a bunch more uses of strncpy() with safer coding. 2015-01-24 13:05:42 -05:00
trgm.h Make contrib/pg_trgm also support regex searches with GiST indexes. 2013-04-10 13:31:02 -04:00