postgresql/contrib/tablefunc
Tom Lane 09cecdf285 Fix a number of places that produced XX000 errors in the regression tests.
It's against project policy to use elog() for user-facing errors, or to
omit an errcode() selection for errors that aren't supposed to be "can't
happen" cases.  Fix all the violations of this policy that result in
ERRCODE_INTERNAL_ERROR log entries during the standard regression tests,
as errors that can reliably be triggered from SQL surely should be
considered user-facing.

I also looked through all the files touched by this commit and fixed
other nearby problems of the same ilk.  I do not claim to have fixed
all violations of the policy, just the ones in these files.

In a few places I also changed existing ERRCODE choices that didn't
seem particularly appropriate; mainly replacing ERRCODE_SYNTAX_ERROR
by something more specific.

Back-patch to 9.5, but no further; changing ERRCODE assignments in
stable branches doesn't seem like a good idea.
2015-08-02 23:49:19 -04:00
..
data
expected Handle unexpected query results, especially NULLs, safely in connectby(). 2015-01-29 20:18:33 -05:00
sql Handle unexpected query results, especially NULLs, safely in connectby(). 2015-01-29 20:18:33 -05:00
.gitignore
Makefile Add file version information to most installed Windows binaries. 2014-07-14 14:07:52 -04:00
tablefunc--1.0.sql
tablefunc--unpackaged--1.0.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
tablefunc.c Fix a number of places that produced XX000 errors in the regression tests. 2015-08-02 23:49:19 -04:00
tablefunc.control
tablefunc.h Update copyright for 2015 2015-01-06 11:43:47 -05:00