mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-07-17 09:21:10 +02:00
c7b8998ebb
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4d wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
78 lines
2.3 KiB
C
78 lines
2.3 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* date.h
|
|
* Definitions for the SQL "date" and "time" types.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/utils/date.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef DATE_H
|
|
#define DATE_H
|
|
|
|
#include <math.h>
|
|
|
|
#include "fmgr.h"
|
|
|
|
|
|
typedef int32 DateADT;
|
|
|
|
typedef int64 TimeADT;
|
|
|
|
typedef struct
|
|
{
|
|
TimeADT time; /* all time units other than months and years */
|
|
int32 zone; /* numeric time zone, in seconds */
|
|
} TimeTzADT;
|
|
|
|
/*
|
|
* Infinity and minus infinity must be the max and min values of DateADT.
|
|
*/
|
|
#define DATEVAL_NOBEGIN ((DateADT) PG_INT32_MIN)
|
|
#define DATEVAL_NOEND ((DateADT) PG_INT32_MAX)
|
|
|
|
#define DATE_NOBEGIN(j) ((j) = DATEVAL_NOBEGIN)
|
|
#define DATE_IS_NOBEGIN(j) ((j) == DATEVAL_NOBEGIN)
|
|
#define DATE_NOEND(j) ((j) = DATEVAL_NOEND)
|
|
#define DATE_IS_NOEND(j) ((j) == DATEVAL_NOEND)
|
|
#define DATE_NOT_FINITE(j) (DATE_IS_NOBEGIN(j) || DATE_IS_NOEND(j))
|
|
|
|
/*
|
|
* Macros for fmgr-callable functions.
|
|
*
|
|
* For TimeADT, we make use of the same support routines as for int64.
|
|
* Therefore TimeADT is pass-by-reference if and only if int64 is!
|
|
*/
|
|
#define MAX_TIME_PRECISION 6
|
|
|
|
#define DatumGetDateADT(X) ((DateADT) DatumGetInt32(X))
|
|
#define DatumGetTimeADT(X) ((TimeADT) DatumGetInt64(X))
|
|
#define DatumGetTimeTzADTP(X) ((TimeTzADT *) DatumGetPointer(X))
|
|
|
|
#define DateADTGetDatum(X) Int32GetDatum(X)
|
|
#define TimeADTGetDatum(X) Int64GetDatum(X)
|
|
#define TimeTzADTPGetDatum(X) PointerGetDatum(X)
|
|
|
|
#define PG_GETARG_DATEADT(n) DatumGetDateADT(PG_GETARG_DATUM(n))
|
|
#define PG_GETARG_TIMEADT(n) DatumGetTimeADT(PG_GETARG_DATUM(n))
|
|
#define PG_GETARG_TIMETZADT_P(n) DatumGetTimeTzADTP(PG_GETARG_DATUM(n))
|
|
|
|
#define PG_RETURN_DATEADT(x) return DateADTGetDatum(x)
|
|
#define PG_RETURN_TIMEADT(x) return TimeADTGetDatum(x)
|
|
#define PG_RETURN_TIMETZADT_P(x) return TimeTzADTPGetDatum(x)
|
|
|
|
|
|
/* date.c */
|
|
extern int32 anytime_typmod_check(bool istz, int32 typmod);
|
|
extern double date2timestamp_no_overflow(DateADT dateVal);
|
|
extern void EncodeSpecialDate(DateADT dt, char *str);
|
|
extern DateADT GetSQLCurrentDate(void);
|
|
extern TimeTzADT *GetSQLCurrentTime(int32 typmod);
|
|
extern TimeADT GetSQLLocalTime(int32 typmod);
|
|
|
|
#endif /* DATE_H */
|