mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-09-28 22:21:58 +02:00
500d49794f
spgrescan would first reset traversalCxt, and then traverse a
potentially non-empty stack containing pointers to traversalValues
which had been allocated in those contexts, freeing them a second
time. This bug originates in commit ccd6eb49a where traversalValue was
introduced.
Repair by traversing the stack before the context reset; this isn't
ideal, since it means doing retail pfree in a context that's about to
be reset, but the freeing of a stack entry is also done in other
places in the code during the scan so it's not worth trying to
refactor it further. Regression test added.
Backpatch to 9.6 where the problem was introduced.
Per bug #15378; analysis and patch by me, originally from a report on
IRC by user velix; see also PostGIS ticket #4174; review by Alexander
Korotkov.
Discussion: https://postgr.es/m/153663176628.23136.11901365223750051490@wrigleys.postgresql.org
74 lines
2.8 KiB
SQL
74 lines
2.8 KiB
SQL
--
|
|
-- Test SP-GiST indexes.
|
|
--
|
|
-- There are other tests to test different SP-GiST opclasses. This is for
|
|
-- testing SP-GiST code itself.
|
|
|
|
create table spgist_point_tbl(id int4, p point);
|
|
create index spgist_point_idx on spgist_point_tbl using spgist(p) with (fillfactor = 75);
|
|
|
|
-- Test vacuum-root operation. It gets invoked when the root is also a leaf,
|
|
-- i.e. the index is very small.
|
|
insert into spgist_point_tbl (id, p)
|
|
select g, point(g*10, g*10) from generate_series(1, 10) g;
|
|
delete from spgist_point_tbl where id < 5;
|
|
vacuum spgist_point_tbl;
|
|
|
|
-- Insert more data, to make the index a few levels deep.
|
|
insert into spgist_point_tbl (id, p)
|
|
select g, point(g*10, g*10) from generate_series(1, 10000) g;
|
|
insert into spgist_point_tbl (id, p)
|
|
select g+100000, point(g*10+1, g*10+1) from generate_series(1, 10000) g;
|
|
|
|
-- To test vacuum, delete some entries from all over the index.
|
|
delete from spgist_point_tbl where id % 2 = 1;
|
|
|
|
-- And also delete some concentration of values. (SP-GiST doesn't currently
|
|
-- attempt to delete pages even when they become empty, but if it did, this
|
|
-- would exercise it)
|
|
delete from spgist_point_tbl where id < 10000;
|
|
|
|
vacuum spgist_point_tbl;
|
|
|
|
-- Test rescan paths (cf. bug #15378)
|
|
-- use box and && rather than point, so that rescan happens when the
|
|
-- traverse stack is non-empty
|
|
|
|
create table spgist_box_tbl(id serial, b box);
|
|
insert into spgist_box_tbl(b)
|
|
select box(point(i,j),point(i+s,j+s))
|
|
from generate_series(1,100,5) i,
|
|
generate_series(1,100,5) j,
|
|
generate_series(1,10) s;
|
|
create index spgist_box_idx on spgist_box_tbl using spgist (b);
|
|
|
|
select count(*)
|
|
from (values (point(5,5)),(point(8,8)),(point(12,12))) v(p)
|
|
where exists(select * from spgist_box_tbl b where b.b && box(v.p,v.p));
|
|
|
|
-- The point opclass's choose method only uses the spgMatchNode action,
|
|
-- so the other actions are not tested by the above. Create an index using
|
|
-- text opclass, which uses the others actions.
|
|
|
|
create table spgist_text_tbl(id int4, t text);
|
|
create index spgist_text_idx on spgist_text_tbl using spgist(t);
|
|
|
|
insert into spgist_text_tbl (id, t)
|
|
select g, 'f' || repeat('o', 100) || g from generate_series(1, 10000) g
|
|
union all
|
|
select g, 'baaaaaaaaaaaaaar' || g from generate_series(1, 1000) g;
|
|
|
|
-- Do a lot of insertions that have to split an existing node. Hopefully
|
|
-- one of these will cause the page to run out of space, causing the inner
|
|
-- tuple to be moved to another page.
|
|
insert into spgist_text_tbl (id, t)
|
|
select -g, 'f' || repeat('o', 100-g) || 'surprise' from generate_series(1, 100) g;
|
|
|
|
-- Test out-of-range fillfactor values
|
|
create index spgist_point_idx2 on spgist_point_tbl using spgist(p) with (fillfactor = 9);
|
|
create index spgist_point_idx2 on spgist_point_tbl using spgist(p) with (fillfactor = 101);
|
|
|
|
-- Modify fillfactor in existing index
|
|
alter index spgist_point_idx set (fillfactor = 90);
|
|
reindex index spgist_point_idx;
|