postgresql/contrib/pageinspect
Michael Paquier 5378d55cb2 pageinspect: Fix handling of all-zero pages
Getting from get_raw_page() an all-zero page is considered as a valid
case by the buffer manager and it can happen for example when finding a
corrupted page with zero_damaged_pages enabled (using zero_damaged_pages
to look at corrupted pages happens), or after a crash when a relation
file is extended before any WAL for its new data is generated (before a
vacuum or autovacuum job comes in to do some cleanup).

However, all the functions of pageinspect, as of the index AMs (except
hash that has its own idea of new pages), heap, the FSM or the page
header have never worked with all-zero pages, causing various crashes
when going through the page internals.

This commit changes all the pageinspect functions to be compliant with
all-zero pages, where the choice is made to return NULL or no rows for
SRFs when finding a new page.  get_raw_page() still works the same way,
returning a batch of zeros in the bytea of the page retrieved.  A hard
error could be used but NULL, while more invasive, is useful when
scanning relation files in full to get a batch of results for a single
relation in one query.  Tests are added for all the code paths
impacted.

Reported-by: Daria Lepikhova
Author: Michael Paquier
Discussion: https://postgr.es/m/561e187b-3549-c8d5-03f5-525c14e65bd0@postgrespro.ru
Backpatch-through: 10
2022-04-14 15:09:39 +09:00
..
expected pageinspect: Fix handling of all-zero pages 2022-04-14 15:09:39 +09:00
sql pageinspect: Fix handling of all-zero pages 2022-04-14 15:09:39 +09:00
.gitignore pageinspect: Add tests 2016-11-01 14:02:16 -04:00
Makefile Skip full index scan during cleanup of B-tree indexes when possible 2018-04-04 19:29:00 +03:00
brinfuncs.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:09:39 +09:00
btreefuncs.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:09:39 +09:00
fsmfuncs.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:09:39 +09:00
ginfuncs.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:09:39 +09:00
hashfuncs.c pageinspect: Add more sanity checks to prevent out-of-bound reads 2022-03-27 17:53:59 +09:00
heapfuncs.c Only allow heap in a number of contrib modules. 2019-04-01 14:57:21 -07:00
pageinspect--1.0--1.1.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pageinspect--1.1--1.2.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pageinspect--1.2--1.3.sql pageinspect/BRIN: minor tweaks 2014-12-02 12:20:50 -03:00
pageinspect--1.3--1.4.sql Add forgotten file in commit d6061f83a1 2015-11-25 16:59:07 +03:00
pageinspect--1.4--1.5.sql Update pageinspect extension for parallel query. 2016-06-09 17:18:09 -04:00
pageinspect--1.5--1.6.sql pageinspect: Add bt_page_items function with bytea argument 2017-04-04 23:52:55 -04:00
pageinspect--1.5.sql Update pageinspect extension for parallel query. 2016-06-09 17:18:09 -04:00
pageinspect--1.6--1.7.sql Skip full index scan during cleanup of B-tree indexes when possible 2018-04-04 19:29:00 +03:00
pageinspect--unpackaged--1.0.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:37 +02:00
pageinspect.control Skip full index scan during cleanup of B-tree indexes when possible 2018-04-04 19:29:00 +03:00
pageinspect.h Update copyright for 2019 2019-01-02 12:44:25 -05:00
rawpage.c pageinspect: Fix handling of all-zero pages 2022-04-14 15:09:39 +09:00